- dev - lists.frrouting.org

[frr] ietf-idr-bgp-shutdown draft
by Donald Sharp 07 Mar '17

07 Mar '17

All - Thanks to David Lamparter and Christian Franke for their hard-work on getting this draft into FRR. 'neighbor <A.B.C.D|X:X::X:X|WORD> shutdown message MSG...' https://tools.ietf.org/html/draft-ietf-idr-shutdown-06 thanks! donald

1 0

[frr] Technical Meeting Agenda 11 am EST
by Donald Sharp 07 Mar '17

07 Mar '17

https://bluejeans.com/9192742159 1) 2.0 status 2) Issues 3) PR 4) EIGRP 5) Anything Else? donald

1 0

[frr] New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Mar '17

05 Mar '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1414724: Code maintainability issues (UNUSED_VALUE) /ldpd/address.c: 89 in send_address() ________________________________________________________________________________________________________ *** CID 1414724: Code maintainability issues (UNUSED_VALUE) /ldpd/address.c: 89 in send_address() 83 if ((buf = ibuf_open(size)) == NULL) 84 fatal(__func__); 85 86 err |= gen_ldp_hdr(buf, size); 87 size -= LDP_HDR_SIZE; 88 err |= gen_msg_hdr(buf, msg_type, size); >>> CID 1414724: Code maintainability issues (UNUSED_VALUE) >>> Assigning value from "size - 8" to "size" here, but that stored value is overwritten before it can be used. 89 size -= LDP_MSG_SIZE; 90 err |= gen_address_list_tlv(buf, af, addr_list, tlv_addr_count); 91 if (err) { 92 address_list_clr(addr_list); 93 ibuf_free(buf); 94 return; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

[frr] Lightening talk at Apricot - can I name some/all of your companies?
by Martin Winter 02 Mar '17

02 Mar '17

So I’m planning to present a lightening talk this thursday at Apricot (I won’t know until Wed late if I get a slot, so no guarantee) Part of the talk I wanted to list who is behind FRR and wanted to check if you all are ok or if I should not mention any of your companies. So please clarify either in private or public reply if you are ok or not Thinking about mentioning: - NetDEF / OpenSourceRouting - Cumulus - LabN - Orange - 6Wind (happy to add more - just shoot me an email and let me know who else to add) Regards, Martin Winter

4 6

[frr] New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 Mar '17

01 Mar '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1413930: Uninitialized variables (UNINIT) /zebra/rt_netlink.c: 268 in netlink_route_change_read_unicast() ________________________________________________________________________________________________________ *** CID 1413930: Uninitialized variables (UNINIT) /zebra/rt_netlink.c: 268 in netlink_route_change_read_unicast() 262 } 263 264 if (IS_ZEBRA_DEBUG_KERNEL) 265 { 266 char buf[PREFIX_STRLEN]; 267 char buf2[PREFIX_STRLEN]; >>> CID 1413930: Uninitialized variables (UNINIT) >>> Using uninitialized value "src_p.prefixlen". 268 zlog_debug ("%s %s%s%s vrf %u", 269 nl_msg_type_to_str (h->nlmsg_type), 270 prefix2str (&p, buf, sizeof(buf)), 271 src_p.prefixlen ? " from " : "", 272 src_p.prefixlen ? prefix2str(&src_p, buf2, sizeof(buf2)) : "", 273 vrf_id); ** CID 1413929: (RESOURCE_LEAK) /bgpd/bgp_encap.c: 609 in show_bgp_ipv4_encap_neighbor_routes() /bgpd/bgp_encap.c: 612 in show_bgp_ipv4_encap_neighbor_routes() ________________________________________________________________________________________________________ *** CID 1413929: (RESOURCE_LEAK) /bgpd/bgp_encap.c: 609 in show_bgp_ipv4_encap_neighbor_routes() 603 } 604 605 peer = peer_lookup (NULL, su); 606 if (! peer || ! peer->afc[AFI_IP][SAFI_ENCAP]) 607 { 608 vty_out (vty, "%% No such neighbor or address family%s", VTY_NEWLINE); >>> CID 1413929: (RESOURCE_LEAK) >>> Variable "su" going out of scope leaks the storage it points to. 609 return CMD_WARNING; 610 } 611 612 return bgp_show_encap (vty, AFI_IP, NULL, bgp_show_type_neighbor, su, 0); 613 } 614 /bgpd/bgp_encap.c: 612 in show_bgp_ipv4_encap_neighbor_routes() 606 if (! peer || ! peer->afc[AFI_IP][SAFI_ENCAP]) 607 { 608 vty_out (vty, "%% No such neighbor or address family%s", VTY_NEWLINE); 609 return CMD_WARNING; 610 } 611 >>> CID 1413929: (RESOURCE_LEAK) >>> Variable "su" going out of scope leaks the storage it points to. 612 return bgp_show_encap (vty, AFI_IP, NULL, bgp_show_type_neighbor, su, 0); 613 } 614 615 DEFUN (show_bgp_ipv6_encap_neighbor_routes, 616 show_bgp_ipv6_encap_neighbor_routes_cmd, 617 "show [ip] bgp ipv6 encap neighbors A.B.C.D routes", ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

[frr] Technical Meeting Agenda
by Donald Sharp 28 Feb '17

28 Feb '17

https://bluejeans.com/9192742159 1) Bugs 2) Pull Requests 3) FRR Name 4) Anything Else? donald

2 1

[frr] FRR logo poll
by JR Rivers 27 Feb '17

27 Feb '17

Hi, wanted to update everyone on the logo poll. The final results, with 23 people voting are design #105 (the abstract chicken screenshots below) as the clear favorite. I've posted the tallies below along with a link to the poll. cheers, JR The last set of numbers are the number of people that votes 5 stars, 4 stars, 3 stars, 2 stars, and 1 star. Note that not all people voted for each design, so these numbers don't all sum up to 23 (except for #105). #105 - abstract chicken - 3.8 average rating - 12, 3, 2, 4, 2 #100 - frr arrow letters - 3.4 average rating - 4, 7, 4, 2, 3 #95 - fr with arrows in the white space - 3 average rating - 1, 8, 4, 2, 4 #96 - abstract asian FR - 2.5 average rating - 1, 3, 5, 3, 5 #104 - fr with looping r arrow - 2.3 average rating - 0, 2, 7, 4, 6 #102 - red-black R's with whitespace F - 2.2 average rating - 0, 4, 4, 3, 8 #101 - frr with arrow heads and reversed r's - 2.2 average rating - 1, 2, 3, 5, 7 #94 - FR in a circle - 2.1 average rating - 0, 3, 3, 6, 7 https://99designs.com/contests/poll/s7xxvf [image: Inline image 1] [image: Inline image 2]

3 3

[frr] Draft Support for ISIS backoff Algorithm
by Donald Sharp 24 Feb '17

24 Feb '17

All - Thanks to Stephane Litkowski, Olivier Dugeon and Christian Franke for working on this. We now have https://datatracker.ietf.org/doc/draft-ietf-rtgwg-backoff-algo/ Implemented into FRR. It is available on master. thanks! donald

2 1

[frr] New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Feb '17

24 Feb '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1411668: Resource leaks (RESOURCE_LEAK) /isisd/isis_route.c: 577 in isis_route_validate_merge() ________________________________________________________________________________________________________ *** CID 1411668: Resource leaks (RESOURCE_LEAK) /isisd/isis_route.c: 577 in isis_route_validate_merge() 571 else if (family == AF_INET6) 572 table = area->route_table6[0]; 573 else 574 { 575 zlog_warn ("ISIS-Rte (%s) %s called for unknown family %d", 576 area->area_tag, __func__, family); >>> CID 1411668: Resource leaks (RESOURCE_LEAK) >>> Variable "merge" going out of scope leaks the storage it points to. 577 return; 578 } 579 580 for (rnode = route_top (table); rnode; rnode = route_next (rnode)) 581 { 582 if (rnode->info == NULL) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

[frr] What FRR domain name should we use?
by sharpd＠cumulusnetworks.com 23 Feb '17

23 Feb '17

I've invited you to fill out the following form: FRR domain Name To fill it out, visit: https://docs.google.com/forms/d/e/1FAIpQLSeVgLYddhlvQkIJe_wzFOhmNf4fysAevGD… All - We've narrowed it down to two final domain names and would like input from the community on what we want to use. Thanks! donald Google Forms: Create and analyze surveys.

3 2