- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Nov '24

27 Nov '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1602058: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgpd.c: 5706 in peer_update_source_addr_set() ________________________________________________________________________________________________________ *** CID 1602058: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgpd.c: 5706 in peer_update_source_addr_set() 5700 SET_FLAG(member->flags, PEER_FLAG_UPDATE_SOURCE); 5701 member->update_source = sockunion_dup(su); 5702 XFREE(MTYPE_PEER_UPDATE_SOURCE, member->update_if); 5703 member->last_reset = PEER_DOWN_UPDATE_SOURCE_CHANGE; 5704 5705 /* Send notification or reset peer depending on state. */ >>> CID 1602058: Incorrect expression (COPY_PASTE_ERROR) >>> "peer" in "peer->connection" looks like a copy-paste error. 5706 if (!peer_notify_config_change(peer->connection)) 5707 bgp_session_reset(member); 5708 5709 /* Apply new source configuration to BFD session. */ 5710 if (member->bfd_config) 5711 bgp_peer_bfd_update_source(member); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Nov '24

17 Nov '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1601875: Error handling issues (CHECKED_RETURN) /pimd/pim_rp.c: 1544 in pim_embedded_rp_new() ________________________________________________________________________________________________________ *** CID 1601875: Error handling issues (CHECKED_RETURN) /pimd/pim_rp.c: 1544 in pim_embedded_rp_new() 1538 pim_rp_refresh_group_to_rp_mapping(pim); 1539 if (PIM_DEBUG_PIM_NHT_RP) 1540 zlog_debug("%s: NHT Register RP addr %pPA grp %pFX with Zebra", __func__, 1541 &rp_info->rp.rpf_addr, &rp_info->group); 1542 1543 pim_find_or_track_nexthop(pim, rp_info->rp.rpf_addr, NULL, rp_info, NULL); >>> CID 1601875: Error handling issues (CHECKED_RETURN) >>> Calling "pim_ecmp_nexthop_lookup" without checking return value (as is done elsewhere 8 out of 9 times). 1544 pim_ecmp_nexthop_lookup(pim, &rp_info->rp.source_nexthop, rp_info->rp.rpf_addr, 1545 &rp_info->group, 1); 1546 } 1547 1548 void pim_embedded_rp_delete(struct pim_instance *pim, const pim_addr *group) 1549 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 Nov '24

13 Nov '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1601739: Control flow issues (DEADCODE) /bgpd/bgp_ecommunity.c: 770 in ecommunity_gettoken() ________________________________________________________________________________________________________ *** CID 1601739: Control flow issues (DEADCODE) /bgpd/bgp_ecommunity.c: 770 in ecommunity_gettoken() 764 * upon overflow). 765 */ 766 if (*endptr != '\0' || tmp_as > BGP_AS4_MAX || 767 errno) 768 goto error; 769 if (*token == ecommunity_token_color && as > 3) >>> CID 1601739: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "goto error;". 770 goto error; 771 as = (as_t)tmp_as; 772 } 773 } else if (*p == '.') { 774 if (separator) 775 goto error; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 08 Nov '24

08 Nov '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1601478: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1601478: Uninitialized variables (UNINIT) /lib/routemap.c: 2757 in route_map_apply_ext() 2751 else 2752 *pref = 65536; 2753 } 2754 2755 if (map) { 2756 GETRUSAGE(&mafter); >>> CID 1601478: Uninitialized variables (UNINIT) >>> Using uninitialized value "mbefore.real.tv_usec" when calling "event_consumed_time". 2757 event_consumed_time(&mafter, &mbefore, &cputime); 2758 map->cputime += cputime; 2759 } 2760 2761 return (ret); 2762 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 02 Nov '24

02 Nov '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1601428: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1601428: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty_clippy.c: 549 in ospf_timers_lsa_min_arrival() 543 #if 1 /* anything that can fail? */ 544 if (_failcnt) 545 return CMD_WARNING; 546 #endif 547 #endif 548 >>> CID 1601428: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "min_arrival_str" to "ospf_timers_lsa_min_arrival_magic", which dereferences it. 549 return ospf_timers_lsa_min_arrival_magic(self, vty, argc, argv, no, min_arrival, min_arrival_str); 550 } 551 552 /* ospf_timers_lsa_min_arrival_deprecated => "timers lsa min-arrival [(5001-60000)]$min_arrival" */ 553 DEFUN_CMD_FUNC_DECL(ospf_timers_lsa_min_arrival_deprecated) 554 #define funcdecl_ospf_timers_lsa_min_arrival_deprecated static int ospf_timers_lsa_min_arrival_deprecated_magic(\ ** CID 1601427: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1601427: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_vty_clippy.c: 495 in ospf_timers_min_ls_interval() 489 #if 1 /* anything that can fail? */ 490 if (_failcnt) 491 return CMD_WARNING; 492 #endif 493 #endif 494 >>> CID 1601427: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "lsa_refresh_interval_str" to "ospf_timers_min_ls_interval_magic", which dereferences it. 495 return ospf_timers_min_ls_interval_magic(self, vty, argc, argv, no, lsa_refresh_interval, lsa_refresh_interval_str); 496 } 497 498 /* ospf_timers_lsa_min_arrival => "[no] timers lsa min-arrival ![(0-5000)]$min_arrival" */ 499 DEFUN_CMD_FUNC_DECL(ospf_timers_lsa_min_arrival) 500 #define funcdecl_ospf_timers_lsa_min_arrival static int ospf_timers_lsa_min_arrival_magic(\ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

Results of the FRR TSC 2024 election.
by Alistair Woodman 29 Oct '24

29 Oct '24

All, As there were no new candidates, who requested to stand for the TSC, the existing TSC members are all reconfirmed to the TSC for the next 12-month term. /a

1 0

Third and final request for nominations for candidates for the 2024 TSC election.
by Alistair Woodman 25 Oct '24

25 Oct '24

All, This is the third and final request for nominations for candidates for the 2024 TSC election. I will close the nominations window tomorrow, Friday 25th of October at UTC 23:59 At the moment, all existing TSC members are re-standing and no other maintainers are standing: i.e. there are 6 candidates for 6 seats. Please contact / unicast me with nominations or questions. 1) Self-nominations are welcome. 2) All nominees must be active FRR maintainers in order to stand. 3) Present TSC members must opt-out of being auto-nominated. 4) If you plan to nominate someone else, please get their approval first. /a (your friendly FRR community elections officer)

1 0

Second request for nominations for candidates for the 2024 TSC election.
by Alistair Woodman 22 Oct '24

22 Oct '24

All, This is the second request for nominations for candidates for the 2024 TSC election. Please contact / unicast me with nominations or questions. 1) Self-nominations are welcome. 2) All nominees must be active FRR maintainers in order to stand. 3) Present TSC members must opt-out of being auto-nominated. 4) If you plan to nominate someone else, please get their approval first. /a (your friendly FRR community elections officer)

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Oct '24

17 Oct '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1600812: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1600812: Null pointer dereferences (NULL_RETURNS) /zebra/connected.c: 194 in connected_remove_kernel_for_connected() 188 { 189 struct route_node *rn; 190 struct route_entry *re; 191 rib_dest_t *dest; 192 struct route_table *table = zebra_vrf_table(afi, SAFI_UNICAST, zvrf->vrf->vrf_id); 193 >>> CID 1600812: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "table" when calling "route_node_match". 194 rn = route_node_match(table, p); 195 if (!rn) 196 return; 197 198 if (!prefix_same(&rn->p, p)) 199 return; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 15 Oct '24

15 Oct '24

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1600779: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_bmp.c: 506 in bmp_peerstate() ________________________________________________________________________________________________________ *** CID 1600779: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_bmp.c: 506 in bmp_peerstate() 500 stream_put_in_addr(s, &peer->su_local->sin.sin_addr); 501 } 502 503 /* Local Port, Remote Port */ 504 if (is_locrib) 505 stream_putw(s, 0); >>> CID 1600779: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "peer->su_local". 506 else if (peer->su_local->sa.sa_family == AF_INET6) 507 stream_putw(s, htons(peer->su_local->sin6.sin6_port)); 508 else if (peer->su_local->sa.sa_family == AF_INET) 509 stream_putw(s, htons(peer->su_local->sin.sin_port)); 510 511 if (is_locrib) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0