- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Mar '20

24 Mar '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1491788: Control flow issues (DEADCODE) /nhrpd/nhrp_vty.c: 626 in show_ip_nhrp_cache() ________________________________________________________________________________________________________ *** CID 1491788: Control flow issues (DEADCODE) /nhrpd/nhrp_vty.c: 626 in show_ip_nhrp_cache() 620 sockunion2str(&c->cur.peer->vc->remote.nbma, 621 buf[1], sizeof(buf[1])); 622 else 623 snprintf(buf[1], sizeof(buf[1]), "-"); 624 625 if (json) { >>> CID 1491788: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "json = json_object_new_obje...". 626 json = json_object_new_object(); 627 json_object_string_add(json, "interface", c->ifp->name); 628 json_object_string_add(json, "type", 629 nhrp_cache_type_str[c->cur.type]); 630 json_object_string_add(json, "protocol", buf[0]); 631 json_object_string_add(json, "nbma", buf[1]); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

BGP Attribute meeting
by Donald Sharp 20 Mar '20

20 Mar '20

All - We've had some recent code get into BGP that has substantially grown the `struct attr`. We need to come up with a methodology to bring this down. I am proposing we have a meeting at 10am EST( 7am Pacific ) this Friday. If you are interested in attending this meeting please let me know and I'll add you to the meeting invite. donald

1 2

Next Telco meeting 18/03
by olivier.dugeon＠orange.com 19 Mar '20

19 Mar '20

Dear all, The next Telco meeting will take place tomorrow 18/03 at 16h00 Paris Time (4 PM GMT+1) as usual. But, it seems that my original invitation has not automatically adjust the appointment to the summer time, in particular for US which has already switch 2 weeks ago. Please adjust the invit if you are concern. Regards Olivier -- Orange logo <http://www.orange.com> Olivier Dugeon Orange Expert, Future Networks Open Source Referent Orange/IMT/OLN/WTC/IEE/iTeQ fixe : +33 2 96 07 28 80 mobile : +33 6 82 90 37 85 olivier.dugeon(a)orange.com <mailto:olivier.dugeon@orange.com> _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 1

Northbound discussions agenda - 20032020
by Santosh P K 19 Mar '20

19 Mar '20

Hello All, Agenda for tomorrow’s call. 1. Progress till now. 2. Implementation issues that we faced for config and operational model. 3. Standard yang landing on FRR. 4. Unified yang server. Thanks Santosh P K

1 0

EVPN-MPLS discussion
by Pat Ruddy 17 Mar '20

17 Mar '20

Hi I've been working on the first phase of the above (RFC7432) for some weeks now and I'm going to give an overview of my work at the weekly meeting next Tuesday 24th March. Since much of the groundwork for this consists of generalizing the core of the existing EVPN-VXLAN functionality so that it can be used by both flavours it would be good to get input from the VXLAN folks. Thanks -pr

1 0

FRR & DANOS integration
by olivier.dugeon＠orange.com 17 Mar '20

17 Mar '20

Hi all, Here it is the PR about the integration of IS-IS into DANOS CLI. The PR re-create a new IS-IS yang model while northbound API define one's: https://github.com/danos/vyatta-protocols-frr/pull/3 I try to convince DANOS contributors to upgrade to latest FRR release and use FRR IS-IS yang verbatim, but it remains some dependency problem i.e. IS-IS depends to interface yang model while DANOS already define a yang model for interface. Integration will take time and will be certainly hard. We could discuss this problem during the Telco meeting tomorrow. Regards Olivier -- Orange logo <http://www.orange.com> Olivier Dugeon Orange Expert, Future Networks Open Source Referent Orange/IMT/OLN/WTC/IEE/iTeQ fixe : +33 2 96 07 28 80 mobile : +33 6 82 90 37 85 olivier.dugeon(a)orange.com <mailto:olivier.dugeon@orange.com> _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Mar '20

17 Mar '20

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 35 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1491755: Memory - illegal accesses (USE_AFTER_FREE) /pimd/pim_vxlan.c: 792 in pim_vxlan_sg_del() ________________________________________________________________________________________________________ *** CID 1491755: Memory - illegal accesses (USE_AFTER_FREE) /pimd/pim_vxlan.c: 792 in pim_vxlan_sg_del() 786 787 vxlan_sg = pim_vxlan_sg_find(pim, sg); 788 if (!vxlan_sg) 789 return; 790 791 pim_vxlan_sg_del_item(vxlan_sg); >>> CID 1491755: Memory - illegal accesses (USE_AFTER_FREE) >>> Passing freed pointer "vxlan_sg" as an argument to "hash_release". 792 hash_release(pim->vxlan.sg_hash, vxlan_sg); 793 } 794 795 /******************************* MLAG handling *******************************/ 796 bool pim_vxlan_do_mlag_reg(void) 797 { ** CID 1491754: Null pointer dereferences (REVERSE_INULL) /lib/mlag.c: 90 in mlag_lib_decode_mlag_hdr() ________________________________________________________________________________________________________ *** CID 1491754: Null pointer dereferences (REVERSE_INULL) /lib/mlag.c: 90 in mlag_lib_decode_mlag_hdr() 84 int mlag_lib_decode_mlag_hdr(struct stream *s, struct mlag_msg *msg, 85 size_t *length) 86 { 87 #define LIB_MLAG_HDR_LENGTH 8 88 *length = stream_get_endp(s); 89 >>> CID 1491754: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "s" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 90 if (s == NULL || msg == NULL || *length < LIB_MLAG_HDR_LENGTH) 91 return -1; 92 93 *length -= LIB_MLAG_HDR_LENGTH; 94 95 STREAM_GETL(s, msg->msg_type); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/ls/click?upn=nJaKvJSIH-2FPAfmty-2BK5tYpPkl…

1 0

Canceled: Northbound discussion
by Santosh P K 13 Mar '20

13 Mar '20

Today’s meeting is cancelled as I am not available and could not find anyone to run it. We will meet next Friday for the same. I will update ongoing progress. Thanks Santosh P K

1 0

Northbound discussion
by Santosh P K 12 Mar '20

12 Mar '20

Edited series to accommodate day light savings. Thanks Santosh P K

1 0

Canceled: Northbound discussion
by Santosh P K 12 Mar '20

12 Mar '20

Adjusting day light saving. Thanks Santosh P K

1 0