- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 28 Oct '19

28 Oct '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1487381: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_nhg.c: 889 in nhg_ctx_process_finish() ________________________________________________________________________________________________________ *** CID 1487381: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_nhg.c: 889 in nhg_ctx_process_finish() 883 884 nh = nhg_ctx_get_nh(ctx); 885 886 nexthop_del_labels(nh); 887 888 done: >>> CID 1487381: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 889 if (ctx) 890 nhg_ctx_free(ctx); 891 } 892 893 static int queue_add(struct nhg_ctx *ctx) 894 { ** CID 1487380: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_nhg.c: 1007 in depends_find() ________________________________________________________________________________________________________ *** CID 1487380: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_nhg.c: 1007 in depends_find() 1001 struct nexthop *lookup = NULL; 1002 struct nhg_hash_entry *nhe = NULL; 1003 1004 copy_nexthops(&lookup, nh, NULL); 1005 1006 /* Clear it, in case its a group */ >>> CID 1487380: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "lookup". 1007 nexthops_free(lookup->next); 1008 nexthops_free(lookup->prev); 1009 lookup->next = NULL; 1010 lookup->prev = NULL; 1011 1012 nhe = zebra_nhg_find_nexthop(0, lookup, afi, 0); ** CID 1487379: Null pointer dereferences (REVERSE_INULL) /zebra/rt_netlink.c: 2284 in netlink_nexthop_process_nh() ________________________________________________________________________________________________________ *** CID 1487379: Null pointer dereferences (REVERSE_INULL) /zebra/rt_netlink.c: 2284 in netlink_nexthop_process_nh() 2278 memcpy(&(nh.gate), gate, sz); 2279 2280 if (if_index) 2281 nh.ifindex = if_index; 2282 2283 *ifp = if_lookup_by_index_per_ns(zebra_ns_lookup(ns_id), nh.ifindex); >>> CID 1487379: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ifp" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 2284 if (ifp) 2285 nh.vrf_id = (*ifp)->vrf_id; 2286 else { 2287 flog_warn( 2288 EC_ZEBRA_UNKNOWN_INTERFACE, 2289 "%s: Unknown nexthop interface %u received, defaulting to VRF_DEFAULT", ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

TSC Election Notification. Election in Progress.
by Alistair Woodman 28 Oct '19

28 Oct '19

@Maintainers, I sent out a SurveyMonkey form for the TSC election last night. The email was sent to each of the 17 maintainers on https://github.com/orgs/FRRouting/teams/maintainers/members Please vote ASAP. If you haven’t found the email, please check your spam folders and then unicast me if you haven’t yet received instructions. /a

1 0

FRR Slack channel
by Adam Casella 28 Oct '19

28 Oct '19

Hey All, Looking to join the FRR slack channel. I am looking to help contribute. Let me know what I need to do in order to obtain an invite. Thanks, Adam

3 4

The following candidates have agreed to stand for the TSC election
by Alistair Woodman 25 Oct '19

25 Oct '19

The following individuals have agreed to stand for election to the TSC. Lou Berger Philippe Guibert Donald Sharp (Sri) Mohan Singamsetty Russ White Martin Winter Quentin Young I will send out voting invitations and instructions to all the FRR maintainers tomorrow /a

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Oct '19

24 Oct '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 14 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1487305: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 643 in evpn_type5_prefix_match() ________________________________________________________________________________________________________ *** CID 1487305: Memory - corruptions (ARRAY_VS_SINGLETON) /lib/prefix.c: 643 in evpn_type5_prefix_match() 637 return 0; 638 639 offset = prefixlen / PNBBY; 640 shift = prefixlen % PNBBY; 641 642 if (shift) >>> CID 1487305: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Using "np" as an array. This might corrupt or misinterpret adjacent memory locations. 643 if (maskbit[shift] & (np[offset] ^ pp[offset])) 644 return 0; 645 646 while (offset--) 647 if (np[offset] != pp[offset]) 648 return 0; ** CID 1485637: Incorrect expression (SIZEOF_MISMATCH) /qpb/qpb_allocator.h: 57 in qpb_alloc_ptr_array() ________________________________________________________________________________________________________ *** CID 1485637: Incorrect expression (SIZEOF_MISMATCH) /qpb/qpb_allocator.h: 57 in qpb_alloc_ptr_array() 51 * 52 * Allocate space for the specified number of pointers. 53 */ 54 static inline void *qpb_alloc_ptr_array(qpb_allocator_t *allocator, 55 size_t num_ptrs) 56 { >>> CID 1485637: Incorrect expression (SIZEOF_MISMATCH) >>> Passing argument "num_ptrs * 8UL /* sizeof (void *) */" to function "qpb_alloc" which returns a value of type "void *" is suspicious. 57 return qpb_alloc(allocator, num_ptrs * sizeof(void *)); 58 } 59 60 /* 61 * qpb_free 62 */ ** CID 1485635: Incorrect expression (SIZEOF_MISMATCH) /qpb/qpb.h: 124 in qpb__l3_prefix__get() ________________________________________________________________________________________________________ *** CID 1485635: Incorrect expression (SIZEOF_MISMATCH) /qpb/qpb.h: 124 in qpb__l3_prefix__get() 118 uint8_t family, struct prefix *prefix) 119 { 120 121 switch (family) { 122 123 case AF_INET: >>> CID 1485635: Incorrect expression (SIZEOF_MISMATCH) >>> Passing argument "prefix" of type "struct prefix *" and argument "16UL" ("sizeof (struct prefix_ipv4)") to function "memset" is suspicious because a multiple of "sizeof (struct prefix) /*48*/" is expected. 124 memset(prefix, 0, sizeof(struct prefix_ipv4)); 125 break; 126 127 case AF_INET6: 128 memset(prefix, 0, sizeof(struct prefix_ipv6)); 129 break; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Northbound Presentation Slides
by Quentin Young 23 Oct '19

23 Oct '19

Here are the slides for today’s Northbound presentation. Thanks for attending. https://docs.google.com/presentation/d/1Jl29gLBFz31QbgFcwBZ9-uzFntpILG-3UW7… <https://docs.google.com/presentation/d/1Jl29gLBFz31QbgFcwBZ9-uzFntpILG-3UW7…> Quentin

1 0

Slack Invite
by Lee Clements 23 Oct '19

23 Oct '19

Hello, I am using FRRouting for some edge routing and have a few development and use-case scenario questions that may be better answered in a chat format than a bug report or e-mail format. Can I get an invite to the FRRouting slack? Thanks!

2 1

BFD dampening
by Heidi net 22 Oct '19

22 Oct '19

Hi, Is there any plan to add dampening for BFD, similar to https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/iproute_bfd/configuration… <https://www.cisco.com/c/en/us/td/docs/ios-xml/ios/iproute_bfd/configuration…> thanks - Heidi

1 0

Reminder: Northbound API meeting tomorrow at 11 am EST
by Quentin Young 22 Oct '19

22 Oct '19

Just a short reminder that we are having the meeting to go over the current NB implementation tomorrow at 11 am PST. I’ll be covering the architecture, components and some implementation details of the Northbound. I plan to keep it around 1 hour long. I’ll be hosting on my personal bluejeans meeting here: https://bluejeans.com/4072831423 <https://bluejeans.com/4072831423> Quentin

1 1

Segment Routing for ISIS status discussion
by Mark Stapp 22 Oct '19

22 Oct '19

We had some update about the ongoing SR work for ISIS from Renato W and Olivier D during the weekly dev meeting this week. We are planning to hold a call this Friday, 25 October, to continue the discussion and look for ways to move forward. I'll propose 11am Eastern US time, and we'll plan to use the familiar bluejeans number: https://bluejeans.com/9192742159/ Regards, Mark

1 0