- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Aug '17

31 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 78 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1455230: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_packet.c: 275 in eigrp_make_sha256_digest() ________________________________________________________________________________________________________ *** CID 1455230: Resource leaks (RESOURCE_LEAK) /eigrpd/eigrp_packet.c: 275 in eigrp_make_sha256_digest() 269 if (keychain) 270 key = key_lookup_for_send(keychain); 271 272 if (!key) { 273 zlog_warn("Interface %s: Expected key value not found in config", 274 ei->ifp->name); >>> CID 1455230: Resource leaks (RESOURCE_LEAK) >>> Variable "auth_TLV" going out of scope leaks the storage it points to. 275 return 0; 276 } 277 278 inet_ntop(AF_INET, &ei->address->u.prefix4, source_ip, PREFIX_STRLEN); 279 280 memset(&ctx, 0, sizeof(ctx)); ** CID 1455229: (BUFFER_SIZE_WARNING) /eigrpd/eigrp_packet.c: 625 in eigrp_read() /eigrpd/eigrp_packet.c: 626 in eigrp_read() ________________________________________________________________________________________________________ *** CID 1455229: (BUFFER_SIZE_WARNING) /eigrpd/eigrp_packet.c: 625 in eigrp_read() 619 start of the eigrp TLVs */ 620 opcode = eigrph->opcode; 621 622 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 623 char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; 624 >>> CID 1455229: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 51 bytes on destination array "src" of size 51 bytes might leave the destination string unterminated. 625 strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN); 626 strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); 627 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 628 lookup_msg(eigrp_packet_type_str, opcode, NULL), 629 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 630 IF_NAME(ei), src, dst); /eigrpd/eigrp_packet.c: 626 in eigrp_read() 620 opcode = eigrph->opcode; 621 622 if (IS_DEBUG_EIGRP_TRANSMIT(0, RECV)) { 623 char src[PREFIX_STRLEN], dst[PREFIX_STRLEN]; 624 625 strncpy(src, inet_ntoa(iph->ip_src), PREFIX_STRLEN); >>> CID 1455229: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 51 bytes on destination array "dst" of size 51 bytes might leave the destination string unterminated. 626 strncpy(dst, inet_ntoa(iph->ip_dst), PREFIX_STRLEN); 627 zlog_debug("Received [%s][%d/%d] length [%u] via [%s] src [%s] dst [%s]", 628 lookup_msg(eigrp_packet_type_str, opcode, NULL), 629 ntohl(eigrph->sequence), ntohl(eigrph->ack), length, 630 IF_NAME(ei), src, dst); 631 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Aug '17

30 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1455175: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_vxlan.c: 3935 in zebra_vxlan_add_del_gw_macip() ________________________________________________________________________________________________________ *** CID 1455175: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_vxlan.c: 3935 in zebra_vxlan_add_del_gw_macip() 3929 NULL; /* link info for the SVI = bridge info */ 3930 3931 svi_if_zif = ifp->info; 3932 svi_if_link = 3933 if_lookup_by_index_per_ns(zebra_ns_lookup(NS_DEFAULT), 3934 svi_if_zif->link_ifindex); >>> CID 1455175: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "svi_if_zif" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 3935 if (svi_if_zif && svi_if_link) 3936 zvni = zvni_map_svi(ifp, svi_if_link); 3937 } else if (IS_ZEBRA_IF_BRIDGE(ifp)) { 3938 zvni = zvni_map_svi(ifp, ifp); 3939 } 3940 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Aug '17

30 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1455174: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 105 in ip_route() ________________________________________________________________________________________________________ *** CID 1455174: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 105 in ip_route() 99 #if 10 /* anything to parse? */ 100 int _i; 101 #if 1 /* anything that can fail? */ 102 unsigned _fail = 0, _failcnt = 0; 103 #endif 104 const char *no = NULL; >>> CID 1455174: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix" = "NULL". 105 const char *prefix = NULL; 106 struct in_addr mask = { INADDR_ANY }; 107 const char *mask_str = NULL; 108 struct in_addr gate = { INADDR_ANY }; 109 const char *gate_str = NULL; 110 const char *ifname = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 25 Aug '17

25 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 76 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1454848: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 397 in eigrp_network() ________________________________________________________________________________________________________ *** CID 1454848: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 397 in eigrp_network() 391 "EIGRP network prefix\n") 392 { 393 VTY_DECLVAR_CONTEXT(eigrp, eigrp); 394 struct prefix p; 395 int ret; 396 >>> CID 1454848: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix" without checking return value (as is done elsewhere 66 out of 80 times). 397 str2prefix(argv[1]->arg, &p); 398 399 ret = eigrp_network_set(eigrp, &p); 400 401 if (ret == 0) { 402 vty_out(vty, "There is already same network statement.\n"); ** CID 1454847: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 420 in no_eigrp_network() ________________________________________________________________________________________________________ *** CID 1454847: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_vty.c: 420 in no_eigrp_network() 414 "EIGRP network prefix\n") 415 { 416 VTY_DECLVAR_CONTEXT(eigrp, eigrp); 417 struct prefix p; 418 int ret; 419 >>> CID 1454847: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix" without checking return value (as is done elsewhere 66 out of 80 times). 420 str2prefix(argv[2]->arg, &p); 421 422 ret = eigrp_network_unset(eigrp, &p); 423 424 if (ret == 0) { 425 vty_out(vty, "Can't find specified network configuration.\n"); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Aug '17

24 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1454646: Control flow issues (DEADCODE) /ospf6d/ospf6_zebra.c: 238 in ospf6_zebra_read_route() ________________________________________________________________________________________________________ *** CID 1454646: Control flow issues (DEADCODE) /ospf6d/ospf6_zebra.c: 238 in ospf6_zebra_read_route() 232 prefix2str((struct prefix *)&api.prefix, prefixstr, 233 sizeof(prefixstr)); 234 if (nexthop) 235 inet_ntop(AF_INET6, nexthop, nexthopstr, 236 sizeof(nexthopstr)); 237 else >>> CID 1454646: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "snprintf(nexthopstr, 128UL,...". 238 snprintf(nexthopstr, sizeof(nexthopstr), "::"); 239 240 zlog_debug( 241 "Zebra Receive route %s: %s %s nexthop %s ifindex %ld tag %" ROUTE_TAG_PRI, 242 (command == ZEBRA_REDISTRIBUTE_ROUTE_ADD ? "add" 243 : "delete"), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Re: [dev] (no subject)
by Renato Westphal 23 Aug '17

23 Aug '17

Hi Yuet Siu, The long term goal is to write a plugin for VPP in FRR. We're already working on a new southbound interface in zebra to make this possible. The problem with the VPPsb's router plugin is that it relies on Netlink messages to mirror the kernel's FIB into VPP's FIB, and Netlink is not a reliable protocol (think about thousands of routes being installed at the same time). Also, we need to have a tighter FRR/VPP integration in order to support advances features like VRF, MPLS L2/L3 VPNs, etc. Unfortunately we have no ETA for the moment. Cheers, Renato. On Wed, Aug 23, 2017 at 9:12 AM, Yuet Siu via dev <dev(a)lists.frrouting.org> wrote: > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev > > > ---------- Forwarded message ---------- > From: Yuet Siu <yfsiu1998(a)yahoo.com> > To: "dev(a)lists.frrouting.org" <dev(a)lists.frrouting.org> > Cc: > Bcc: > Date: Wed, 23 Aug 2017 02:31:52 +0000 (UTC) > Subject: > Hello, > > I'm a developer interested in the FRR project. I'd like to know about the status of the vpp sandbox part: > > VPP Sandbox/router - fd.io > > VPP Sandbox/router - fd.io > > > > Has it been committed to official vpp lineup yet? > > Does the FRR-routing project has newer software updates as compared to the instructions in: > > FRRouting/frr > > FRRouting/frr > > frr - The FRRouting Protocol Suite > > > Thanks a lot, > > Yuet Siu > > -- Renato Westphal

1 0

(no subject)
by Yuet Siu 23 Aug '17

23 Aug '17

Hello, I'm a developer interested in the FRR project. I'd like to know about the status of the vpp sandbox part: VPP Sandbox/router - fd.io | | | | | | | | | | | VPP Sandbox/router - fd.io | | | | Has it been committed to official vpp lineup yet? Does the FRR-routing project has newer software updates as compared to the instructions in: FRRouting/frr | | | | | | | | | | | FRRouting/frr frr - The FRRouting Protocol Suite | | | | Thanks a lot, Yuet Siu

1 0

evpn on ovs
by Raymond Burkholder 22 Aug '17

22 Aug '17

Using https://vincent.bernat.im/en/blog/2017-vxlan-bgp-evpn as a guideline, I was able to get a test environment up and running. I used brctl for local bridging of test and vxlan interfaces. I switched over to openvswitch using ovs-vsctl commands, and was unsuccessful. When running the following, I am missing a "Master (bridge) ifindex __" line. Everything else seems similar, well, other than Type showing up as Ethernet rather than unknown. Is there a bit of secret sauce to run this against openvswitch, or is this not doable at the moment? I havn't poked at the source code to see how the interaction happens. # sh inter vxlan10 Interface vxlan10 is up, line protocol is up Link ups: 0 last: (never) Link downs: 0 last: (never) PTM status: disabled vrf: Default-IP-Routing-Table index 10 metric 0 mtu 1500 speed 0 flags: <UP,BROADCAST,RUNNING,MULTICAST> Type: Ethernet HWaddr: 2e:69:54:74:05:72 inet6 fe80::2c69:54ff:fe74:572/64 Interface Type Vxlan VxLAN Id 10 VTEP IP: 10.10.10.10 Access VLAN Id 1 -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

1 0

Reindent issues
by Bingen Eguzkitza 22 Aug '17

22 Aug '17

Hi, I was trying to apply instructions here (rebase case): https://github.com/FRRouting/frr/wiki/Reindenting but for stable/3.0, and maybe I'm missing something, but it's not working as I would expect. To make it easy to reproduce, and to discard causes related to my branch, what I'm doing is: $ git checkout reindent-3.0-before $ git checkout -b test_reindent $ git cherry-pick reindent-3.0-before Now I have a new branch identical to reindent-3.0-after, can be checked with: $ git diff test_reindent reindent-3.0-after I do this so the script treats it as a new non-rebased branch. Then: $ python git-reindent-branch.py test_reindent I would expect that reindented branch is still identical to reindent-3.0-after, but it's not: $ git diff --stat reindented-branch reindent-3.0-after (...) <- see attached for details 598 files changed, 269745 insertions(+), 244747 deletions(-) How was the reindentation for stable-3.0 done? Was this script used? Thanks, ßingen.

2 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Aug '17

22 Aug '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() ________________________________________________________________________________________________________ *** CID 1454535: Error handling issues (CHECKED_RETURN) /eigrpd/eigrp_hello.c: 419 in eigrp_sw_version_initialize() 413 char ver_string[] = VERSION; 414 char *dash = strstr(ver_string, "-"); 415 416 if (dash) 417 dash[0] = '\0'; 418 >>> CID 1454535: Error handling issues (CHECKED_RETURN) >>> Calling "sscanf" without checking return value (as is done elsewhere 37 out of 41 times). 419 sscanf(ver_string, "%d.%d", &FRR_MAJOR, &FRR_MINOR); 420 } 421 422 /** 423 * @fn eigrp_sw_version_encode 424 * ** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() ________________________________________________________________________________________________________ *** CID 1454534: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1333 in zread_ipv4_delete() 1327 * by label, but 1328 * we don't care for delete. 1329 */ 1330 if (CHECK_FLAG(api.message, ZAPI_MESSAGE_LABEL)) 1331 stream_forward_getp(s, 1332 sizeof(u_int32_t)); >>> CID 1454534: Memory - corruptions (OVERRUN) >>> Assigning: "nexthop_p" = "&nexthop". "nexthop_p" now points to byte 0 of "nexthop" (which consists of 4 bytes). 1333 nexthop_p = (union g_addr *)&nexthop; 1334 break; 1335 case NEXTHOP_TYPE_IPV4_IFINDEX: 1336 nexthop.s_addr = stream_get_ipv4(s); 1337 nexthop_p = (union g_addr *)&nexthop; 1338 ifindex = stream_getl(s); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0