- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 May '17

18 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1436344: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_clist.c: 1175 in extcommunity_list_set() ________________________________________________________________________________________________________ *** CID 1436344: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_clist.c: 1175 in extcommunity_list_set() 1169 if (ecom) 1170 ecom->str = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_DISPLAY, 0); 1171 1172 entry = community_entry_new (); 1173 entry->direct = direct; 1174 entry->style = style; >>> CID 1436344: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "str" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1175 entry->any = (str ? 0 : 1); 1176 if (ecom) 1177 entry->config = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_COMMUNITY_LIST, 0); 1178 else if (regex) 1179 entry->config = XSTRDUP (MTYPE_COMMUNITY_LIST_CONFIG, str); 1180 ** CID 1436343: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_clist.c: 1175 in extcommunity_list_set() ________________________________________________________________________________________________________ *** CID 1436343: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_clist.c: 1175 in extcommunity_list_set() 1169 if (ecom) 1170 ecom->str = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_DISPLAY, 0); 1171 1172 entry = community_entry_new (); 1173 entry->direct = direct; 1174 entry->style = style; >>> CID 1436343: Null pointer dereferences (FORWARD_NULL) >>> Comparing "str" to null implies that "str" might be null. 1175 entry->any = (str ? 0 : 1); 1176 if (ecom) 1177 entry->config = ecommunity_ecom2str (ecom, ECOMMUNITY_FORMAT_COMMUNITY_LIST, 0); 1178 else if (regex) 1179 entry->config = XSTRDUP (MTYPE_COMMUNITY_LIST_CONFIG, str); 1180 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 May '17

17 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1436247: Memory - corruptions (OVERRUN) /zebra/zebra_vty.c: 2349 in static_config() ________________________________________________________________________________________________________ *** CID 1436247: Memory - corruptions (OVERRUN) /zebra/zebra_vty.c: 2349 in static_config() 2343 switch (si->type) 2344 { 2345 case STATIC_IPV4_GATEWAY: 2346 vty_out (vty, " %s", inet_ntoa (si->addr.ipv4)); 2347 break; 2348 case STATIC_IPV6_GATEWAY: >>> CID 1436247: Memory - corruptions (OVERRUN) >>> Overrunning array "buf" of 109 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192U". 2349 vty_out (vty, " %s", inet_ntop (AF_INET6, &si->addr.ipv6, buf, BUFSIZ)); 2350 break; 2351 case STATIC_IFINDEX: 2352 vty_out (vty, " %s", si->ifname); 2353 break; 2354 case STATIC_BLACKHOLE: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 May '17

16 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1435757: Memory - corruptions (ARRAY_VS_SINGLETON) /vtysh/vtysh.c: 3256 in vtysh_init_vty() ________________________________________________________________________________________________________ *** CID 1435757: Memory - corruptions (ARRAY_VS_SINGLETON) /vtysh/vtysh.c: 3256 in vtysh_init_vty() 3250 vty = vty_new (); 3251 vty->type = VTY_SHELL; 3252 vty->node = VIEW_NODE; 3253 3254 /* Initialize commands. */ 3255 cmd_init (0); >>> CID 1435757: Memory - corruptions (ARRAY_VS_SINGLETON) >>> Taking address with "&vtysh_var_handler" yields a singleton pointer. 3256 cmd_variable_handler_register(&vtysh_var_handler); 3257 3258 /* Install nodes. */ 3259 install_node (&bgp_node, NULL); 3260 install_node (&rip_node, NULL); 3261 install_node (&interface_node, NULL); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Announcing tab completion of interface names, prefix-lists, route-maps and BGP peer names
by Donald Sharp 15 May '17

15 May '17

All - We have pushed the ability for tab completion of interface names, prefix-lists, route-maps and BGP peer names into the master branch. For a quick demo of this feature watch this video: https://www.youtube.com/watch?v=1sbgdZRJNJ0 I'd like to thank David for getting this feature into FRR. thanks! donald

1 0

Fuzz testing tools
by Christian Franke 11 May '17

11 May '17

Hello everyone, as I mentioned during yesterdays call when we discussed fuzz testing, I have made very positive experience with using AFL. [1] In contrast to more basic fuzzers, afl uses instrumentation on the code that is added at compile time. The instrumentation is used to more efficiently generate fuzz input that causes the use of new branches in the code. An example to that effect is that when fuzzing libjpeg and using an 'a' point for fuzzing, afl will quickly come up with various broken and valid jpeg files, something most simple fuzzers wouldn't. Also, afl can generate a minimized corpus of input files from the fuzzing process that still has the maximum branch coverage achieved during fuzzing, which is useful to test for regressions without running the complete fuzzing process again. I wrote a small tool called wuschl which wraps around afl and collects the minimized corpus to use it for regression testing. [2] To make use of wuschl one needs to install afl and wuschl and write one test function that passes its input to the function to be fuzzed. Having that, one can run fuzzing and then collect the minimal corpus. After that, regression tests based on the corpus can be run without any need for wuschl or afl. Just wanted to point out the existance of AFL and also wuschl since I think that they might be useful to implement fuzzing for FRR and get the test coverage up. -Christian [1] http://lcamtuf.coredump.cx/afl/ [2] https://github.com/cfra/wuschl

3 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 10 May '17

10 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1434357: Error handling issues (CHECKED_RETURN) /bgpd/bgp_btoa.c: 241 in main() ________________________________________________________________________________________________________ *** CID 1434357: Error handling issues (CHECKED_RETURN) /bgpd/bgp_btoa.c: 241 in main() 235 break; 236 } 237 } 238 239 printf ("len: %zd\n", len); 240 >>> CID 1434357: Error handling issues (CHECKED_RETURN) >>> "fread(void * restrict, size_t, size_t, FILE * restrict)" returns the number of bytes read, but it is ignored. 241 fread (s->data + 12, len, 1, fp); 242 if (feof (fp)) 243 { 244 printf ("ENDOF FILE 2\n"); 245 break; 246 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 10 May '17

10 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1434255: Null pointer dereferences (FORWARD_NULL) /lib/thread.c: 837 in funcname_thread_add_read_write() ________________________________________________________________________________________________________ *** CID 1434255: Null pointer dereferences (FORWARD_NULL) /lib/thread.c: 837 in funcname_thread_add_read_write() 831 pthread_mutex_unlock (&thread->mtx); 832 } 833 834 if (t_ptr) 835 { 836 *t_ptr = thread; >>> CID 1434255: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "thread". 837 thread->ref = t_ptr; 838 } 839 } 840 pthread_mutex_unlock (&m->mtx); 841 } 842 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

graceful restart for ospf
by Akshata Danivasa 10 May '17

10 May '17

Hi, I wanted to know if support for graceful restart is present on FRR or if it is planned in future. Thanks, Akshata

3 5

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 May '17

09 May '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1433546: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /tools/permutations.c: 90 in () ________________________________________________________________________________________________________ *** CID 1433546: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /tools/permutations.c: 90 in () 84 } 85 else 86 { 87 bool skip = false; 88 if (stok->type == FORK_TKN && tok->type != FORK_TKN) 89 for (ALL_LIST_ELEMENTS_RO (position, ln, gnn)) >>> CID 1433546: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) >>> use of "=" where "==" may have been intended 90 if (gnn == gn && (skip = true)) 91 break; 92 if (!skip) 93 permute (gn); 94 } 95 } 96 list_delete_node (position, listtail(position)); ** CID 1433545: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /lib/command.c: 1626 in () ________________________________________________________________________________________________________ *** CID 1433545: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) /lib/command.c: 1626 in () 1620 } 1621 else 1622 { 1623 bool skip = false; 1624 if (stok->type == FORK_TKN && tok->type != FORK_TKN) 1625 for (ALL_LIST_ELEMENTS_RO (position, ln, gnn)) >>> CID 1433545: Incorrect expression (PW.ASSIGN_WHERE_COMPARE_MEANT) >>> use of "=" where "==" may have been intended 1626 if (gnn == gn && (skip = true)) 1627 break; 1628 if (!skip) 1629 permute (gn, vty); 1630 } 1631 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Announcing EIGRP
by Donald Sharp 09 May '17

09 May '17

All - I'd like to thank Jan Janovic, Peter Paluch and Donnie Savage for working with us to get EIGRP into FRR. It is available from the master branch. If you run into any issues feel free to file issues on github. thanks! donald

2 1