- dev - lists.frrouting.org

Please add me to the slack group for FRR
by Mary Manohar 04 May '17

04 May '17

3 4

Proposal to change CLI syntax of 'show ip rib <u_addr> to 'show ip pim rib <u_addr>
by Chirag Shah 03 May '17

03 May '17

Hello All, The CLI command 'show ip rib <unicast addr> is in pim_cmd.c which invokes zebra lookup for nexthops and return the first available path to user. Ideally the command is for PIMd (Zebra Client for nexthop info). I would like to propose to change to CLI to specific to PIMd 'show ip *pim *rib <uincat addr> rather generic than "ip rib" term. Please share your opinion. Kind Regards, Chirag Shah P.S. : Cli implementation from pim_cli.c DEFUN (show_ip_rib, show_ip_rib_cmd, "*show ip rib A.B.C.D*", SHOW_STR IP_STR RIB_STR "Unicast address\n") { struct in_addr addr; const char *addr_str; struct pim_nexthop nexthop; char nexthop_addr_str[PREFIX_STRLEN]; int result; memset (&nexthop, 0, sizeof (nexthop)); addr_str = argv[0]; result = inet_pton(AF_INET, addr_str, &addr); if (result <= 0) { vty_out(vty, "Bad unicast address %s: errno=%d: %s%s", addr_str, errno, safe_strerror(errno), VTY_NEWLINE); return CMD_WARNING; } if (*pim_nexthop_lookup*(&nexthop, addr, 0)) { vty_out(vty, "Failure querying RIB nexthop for unicast address %s%s", addr_str, VTY_NEWLINE); return CMD_WARNING; } vty_out(vty, "Address NextHop Interface Metric Preference%s", VTY_NEWLINE); pim_addr_dump("<nexthop?>", &nexthop.mrib_nexthop_addr, nexthop_addr_str, sizeof(nexthop_addr_str)); vty_out(vty, "%-15s %-15s %-9s %6d %10d%s", addr_str, nexthop_addr_str, nexthop.interface ? nexthop.interface->name : "<ifname?>", nexthop.mrib_route_metric, nexthop.mrib_metric_preference, VTY_NEWLINE); return CMD_SUCCESS; }

3 3

BGP v4 labeled unicast
by Donald Sharp 03 May '17

03 May '17

All - Thanks to the efforts of Vivek Venkatraman, Don Slice and Daniel Walton we now have BGP labeled unicast. - https://datatracker.ietf.org/doc/draft-rosen-idr-rfc3107bis/ And with a partial implementation of - https://datatracker.ietf.org/doc/draft-ietf-idr-bgp-prefix-sid/ This code is available in the master branch. thanks! donald

1 0

Technical Meeting Agenda May 2 2017 11 am PDT
by Donald Sharp 02 May '17

02 May '17

https://bluejeans.com/9192742159 1) TSC Election info 2) Time decision 3) 3.0 issues 4) Issues 5) PR's 6) Reference Packaging 7) Slack channels thanks! donald

2 3

ISIS-MT support
by Donald Sharp 01 May '17

01 May '17

All -- We now have https://tools.ietf.org/html/rfc5120 support for FRR. This code is in the master branch, expect it to be part of an upcoming future release. I'd like to thank Christian Franke for taking the time and effort to get this code in! thanks! donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 28 Apr '17

28 Apr '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1432078: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1432078: Memory - corruptions (OVERRUN) /isisd/isis_spf.c: 943 in isis_spf_preload_tent() 937 continue; 938 if (spftree->mtid == ISIS_MT_IPV4_UNICAST && !speaks (&adj->nlpids, spftree->family)) 939 continue; 940 switch (adj->sys_type) 941 { 942 case ISIS_SYSTYPE_ES: >>> CID 1432078: Memory - corruptions (OVERRUN) >>> Overrunning array "adj->sysid" of 6 bytes by passing it to a function which accesses it at byte offset 6. 943 isis_spf_add_local (spftree, VTYPE_ES, adj->sysid, adj, 944 circuit->te_metric[spftree->level - 1], 945 parent); 946 break; 947 case ISIS_SYSTYPE_IS: 948 case ISIS_SYSTYPE_L1_IS: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Apr '17

27 Apr '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1431868: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1602 in zread_ipv6_add() ________________________________________________________________________________________________________ *** CID 1431868: Memory - corruptions (OVERRUN) /zebra/zserv.c: 1602 in zread_ipv6_add() 1596 /* For labeled-unicast, each nexthop is followed by label. */ 1597 if (CHECK_FLAG (message, ZAPI_MESSAGE_LABEL)) 1598 { 1599 label = (mpls_label_t)stream_getl (s); 1600 labels[nh_count++] = label; 1601 } >>> CID 1431868: Memory - corruptions (OVERRUN) >>> Overrunning array "nexthops" of 64 16-byte elements at element index 64 (byte offset 1024) using index "nh_count++" (which evaluates to 64). 1602 nexthops[nh_count++] = nhop_addr; 1603 } 1604 break; 1605 case NEXTHOP_TYPE_IFINDEX: 1606 if (if_count < multipath_num) { 1607 ifindices[if_count++] = stream_getl (s); ** CID 1431867: Null pointer dereferences (FORWARD_NULL) /lib/nexthop.c: 108 in nexthop_labels_match() ________________________________________________________________________________________________________ *** CID 1431867: Null pointer dereferences (FORWARD_NULL) /lib/nexthop.c: 108 in nexthop_labels_match() 102 103 nhl1 = nh1->nh_label; 104 nhl2 = nh2->nh_label; 105 if ((nhl1 && !nhl2) || (!nhl1 && nhl2)) 106 return 0; 107 >>> CID 1431867: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "nhl1". 108 if (nhl1->num_labels != nhl2->num_labels) 109 return 0; 110 111 if (memcmp (nhl1->label, nhl2->label, nhl1->num_labels)) 112 return 0; 113 ** CID 1431866: Error handling issues (CHECKED_RETURN) /zebra/zebra_mpls.c: 922 in lsp_schedule() ________________________________________________________________________________________________________ *** CID 1431866: Error handling issues (CHECKED_RETURN) /zebra/zebra_mpls.c: 922 in lsp_schedule() 916 static void 917 lsp_schedule (struct hash_backet *backet, void *ctxt) 918 { 919 zebra_lsp_t *lsp; 920 921 lsp = (zebra_lsp_t *) backet->data; >>> CID 1431866: Error handling issues (CHECKED_RETURN) >>> Calling "lsp_processq_add" without checking return value (as is done elsewhere 5 out of 6 times). 922 lsp_processq_add (lsp); 923 } 924 925 /* 926 * Process a LSP entry that is in the queue. Recalculate best NHLFE and 927 * any multipaths and update or delete from the kernel, as needed. ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Apr '17

26 Apr '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1431864: (NO_EFFECT) /ldpd/ldpe.c: 146 in ldpe_init() /ldpd/ldpe.c: 148 in ldpe_init() ________________________________________________________________________________________________________ *** CID 1431864: (NO_EFFECT) /ldpd/ldpe.c: 146 in ldpe_init() 140 } 141 142 void 143 ldpe_init(struct ldpd_init *init) 144 { 145 /* drop privileges */ >>> CID 1431864: (NO_EFFECT) >>> Comparing an array to null is not useful: "init->user", since the test will always evaluate as true. 146 if (init->user) 147 ldpe_privs.user = init->user; 148 if (init->group) 149 ldpe_privs.group = init->group; 150 zprivs_init(&ldpe_privs); 151 /ldpd/ldpe.c: 148 in ldpe_init() 142 void 143 ldpe_init(struct ldpd_init *init) 144 { 145 /* drop privileges */ 146 if (init->user) 147 ldpe_privs.user = init->user; >>> CID 1431864: (NO_EFFECT) >>> Comparing an array to null is not useful: "init->group", since the test will always evaluate as true. 148 if (init->group) 149 ldpe_privs.group = init->group; 150 zprivs_init(&ldpe_privs); 151 152 /* listen on ldpd control socket */ 153 strlcpy(ctl_sock_path, init->ctl_sock_path, sizeof(ctl_sock_path)); ** CID 1431863: (NO_EFFECT) /ldpd/lde.c: 167 in lde_init() /ldpd/lde.c: 169 in lde_init() ________________________________________________________________________________________________________ *** CID 1431863: (NO_EFFECT) /ldpd/lde.c: 167 in lde_init() 161 } 162 163 void 164 lde_init(struct ldpd_init *init) 165 { 166 /* drop privileges */ >>> CID 1431863: (NO_EFFECT) >>> Comparing an array to null is not useful: "init->user", since the test will always evaluate as true. 167 if (init->user) 168 lde_privs.user = init->user; 169 if (init->group) 170 lde_privs.group = init->group; 171 zprivs_init(&lde_privs); 172 /ldpd/lde.c: 169 in lde_init() 163 void 164 lde_init(struct ldpd_init *init) 165 { 166 /* drop privileges */ 167 if (init->user) 168 lde_privs.user = init->user; >>> CID 1431863: (NO_EFFECT) >>> Comparing an array to null is not useful: "init->group", since the test will always evaluate as true. 169 if (init->group) 170 lde_privs.group = init->group; 171 zprivs_init(&lde_privs); 172 173 #ifdef HAVE_PLEDGE 174 if (pledge("stdio recvfd unix", NULL) == -1) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Time to start thinking about moving meeting time
by Donald Sharp 26 Apr '17

26 Apr '17

All - The Weekly meeting is currently at 11 am EDT( 15:00 GMT I believe ) on Tuesdays. I'd like to keep the meeting on Tuesday but think about changing the time. We are starting to get enough people and it's been ~6months since we last changed it. My goal is to move the meeting around every 6 months or so, so that it is eventually painful for everyone. If you would like to attend the meeting or do attend the meeting, please take a minute or so responding to this email with times that you are available to meet based upon GMT time and hopefully we can work out a new time for people to attend. I am available all day on Tuesdays 11 am GMT -> onwards donald

8 8

Technical Meeting Agenda 4/25/27 11 am EDT
by Donald Sharp 25 Apr '17

25 Apr '17

https://bluejeans.com/9192742159 1) Meeting Time. Received 1 email, please update your time! 2) TSC election news. 3) branch rename status 4) 3.0 issues 5) PR's 6) Anything else people would like to talk about? donald

1 1