- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Apr '22

27 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1517454: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 663 in ipv6_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1517454: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 663 in ipv6_mld_group_watermark_magic() 657 "ipv6 mld watermark-warn (1-65535)$limit", 658 IPV6_STR 659 MLD_STR 660 "Configure group limit for watermark warning\n" 661 "Group count to generate watermark warning\n") 662 { >>> CID 1517454: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 663 PIM_DECLVAR_CONTEXT(vrf, pim); 664 /* TBD Depends on MLD data structure changes */ 665 return CMD_SUCCESS; 666 } 667 668 DEFPY (no_ipv6_mld_group_watermark, ** CID 1517453: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 677 in no_ipv6_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1517453: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 677 in no_ipv6_mld_group_watermark_magic() 671 NO_STR 672 IPV6_STR 673 MLD_STR 674 "Unconfigure group limit for watermark warning\n" 675 IGNORED_IN_NO_STR) 676 { >>> CID 1517453: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 677 PIM_DECLVAR_CONTEXT(vrf, pim); 678 /* TBD Depends on MLD data structure changes */ 679 return CMD_SUCCESS; 680 } 681 682 DEFPY (interface_ipv6_mld_query_max_response_time, ** CID 1517452: Memory - corruptions (OVERRUN) /pimd/pim_zlookup.c: 265 in zclient_read_nexthop() ________________________________________________________________________________________________________ *** CID 1517452: Memory - corruptions (OVERRUN) /pimd/pim_zlookup.c: 265 in zclient_read_nexthop() 259 stream_get(&nexthop_tab[num_ifindex].nexthop_addr, s, 260 sizeof(struct in6_addr)); 261 nexthop_tab[num_ifindex].ifindex = stream_getl(s); 262 263 p.family = AF_INET6; 264 p.prefixlen = IPV6_MAX_BITLEN; >>> CID 1517452: Memory - corruptions (OVERRUN) >>> Overrunning struct type pim_addr of 4 bytes by passing it to a function which accesses it at byte offset 15 using argument "16UL". 265 memcpy(&p.u.prefix6, 266 &nexthop_tab[num_ifindex].nexthop_addr, 267 sizeof(struct in6_addr)); 268 269 /* 270 * If we are sending v6 secondary assume we receive v6 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Weekly discussion on MGMT infra and YANG
by Pushpasis Sarkar 12 Apr '22

12 Apr '22

Hi All, As discussed in today’s weekly meeting, setting up this weekly meeting for anyone to bringup and discuss any issues or points regarding the new MGMT work and any other related to YANG infra in general. Individuals who want to discuss anything on these meetings are requested to send the agenda on the ‘yang’ slack channel first. Without any agenda from any member the particular instance of the meeting shall stand cancelled. Thanks and regards -Pushpasis

1 0

Running FRR rpm in container with VPP
by Girish Patoliya 07 Apr '22

07 Apr '22

Hi, I am running ldpd daemon in container where ldpd uses vpp tap as interface. My ldp session gets rejected with error "No Hello", I see lot of below errors: pending_conn_timeout: no adjacency with remote end: 127.0.0.6 What I understand from this is LDP somehow not able to get proper source peer IP from hello message, is that correct? Any idea what could be going wrong ? Thanks a lot Girish ________________________________ This e-mail message may contain confidential or proprietary information of Mavenir Systems, Inc. or its affiliates and is intended solely for the use of the intended recipient(s). If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies in your control and contact us by e-mailing to security(a)mavenir.com. This message contains the views of its author and may not necessarily reflect the views of Mavenir Systems, Inc. or its affiliates, who employ systems to monitor email messages, but make no representation that such messages are authorized, secure, uncompromised, or free from computer viruses, malware, or other defects. Thank You

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Apr '22

06 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1515741: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 636 in mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1515741: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 636 in mld_group_watermark_magic() 630 "ipv6 mld watermark-warn (1-65535)$limit", 631 IPV6_STR 632 MLD_STR 633 "Configure group limit for watermark warning\n" 634 "Group count to generate watermark warning\n") 635 { >>> CID 1515741: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 636 PIM_DECLVAR_CONTEXT(vrf, pim); 637 /* TBD Depends on MLD data structure changes */ 638 return CMD_SUCCESS; 639 } 640 641 DEFPY (no_mld_group_watermark, ** CID 1515740: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 650 in no_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1515740: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 650 in no_mld_group_watermark_magic() 644 NO_STR 645 IPV6_STR 646 MLD_STR 647 "Unconfigure group limit for watermark warning\n" 648 IGNORED_IN_NO_STR) 649 { >>> CID 1515740: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 650 PIM_DECLVAR_CONTEXT(vrf, pim); 651 /* TBD Depends on MLD data structure changes */ 652 return CMD_SUCCESS; 653 } 654 655 DEFPY (interface_ipv6_mld_query_max_response_time, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Announcing the GRRouting fork
by David Lamparter 01 Apr '22

01 Apr '22

Dear all, it is with a heavy heart that I have to announce that due to the way the FRR project has been developing, another fork has become inevitable. I expect that a majority of you are already aware of the ongoing issues we've been having with the community. There simply is no opportunity for any real expression of anger and disdain at the project maintenance. This is very concerning and alienates a large portion of amoeba from participating and contributing constructively. As such, I have been left with no other choice than to create the GRRouting fork. GRRouting's goals and objectives are summarized handily by our new slogan: "putting the GRR back in routing." Of course this applies to development and community standards as well. Our goals will be to deliver software capable of evoking high-quality cursing at your routers. The very first feature will be to implement IP GRR, also known as anGry ReRoute. The plan for this feature is to incorporate a VoIP client and speech synthesis software to expedite waking up network administrators at 3 AM to have them drive to a datacenter to plug some cable. I am confident everyone sees the absolute necessity of this fork. You can find further information at https://grrouting.org/ Saddened but relieved by this finally being out in public, equi

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 Apr '22

01 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1515546: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1515546: Null pointer dereferences (NULL_RETURNS) /pimd/pim_zlookup.c: 391 in zclient_lookup_read_pipe() 385 { 386 struct zclient *zlookup = THREAD_ARG(thread); 387 struct pim_instance *pim = pim_get_pim_instance(VRF_DEFAULT); 388 struct pim_zlookup_nexthop nexthop_tab[10]; 389 struct in_addr l = {.s_addr = INADDR_ANY}; 390 >>> CID 1515546: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "pim" when calling "zclient_lookup_nexthop_once". 391 zclient_lookup_nexthop_once(pim, nexthop_tab, 10, l); 392 thread_add_timer(router->master, zclient_lookup_read_pipe, zlookup, 60, 393 &zlookup_read); 394 } 395 396 int zclient_lookup_nexthop(struct pim_instance *pim, ** CID 1515545: (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1515545: (NULL_RETURNS) /pimd/pim_vxlan.c: 902 in pim_vxlan_mlag_update() 896 if (vxlan_mlag.peerlink_rif) 897 pim_ifp = (struct pim_interface *)vxlan_mlag.peerlink_rif->info; 898 if ((vxlan_mlag.flags & PIM_VXLAN_MLAGF_ENABLED) && 899 pim_ifp && (pim_ifp->mroute_vif_index > 0)) 900 pim_vxlan_set_peerlink_rif(pim, peerlink_rif); 901 else >>> CID 1515545: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "pim" when calling "pim_vxlan_set_peerlink_rif". 902 pim_vxlan_set_peerlink_rif(pim, NULL); 903 } 904 905 /****************************** misc callbacks *******************************/ 906 static void pim_vxlan_set_default_iif(struct pim_instance *pim, 907 struct interface *ifp) /pimd/pim_vxlan.c: 900 in pim_vxlan_mlag_update() 894 895 /* process changes */ 896 if (vxlan_mlag.peerlink_rif) 897 pim_ifp = (struct pim_interface *)vxlan_mlag.peerlink_rif->info; 898 if ((vxlan_mlag.flags & PIM_VXLAN_MLAGF_ENABLED) && 899 pim_ifp && (pim_ifp->mroute_vif_index > 0)) >>> CID 1515545: (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "pim" when calling "pim_vxlan_set_peerlink_rif". 900 pim_vxlan_set_peerlink_rif(pim, peerlink_rif); 901 else 902 pim_vxlan_set_peerlink_rif(pim, NULL); 903 } 904 905 /****************************** misc callbacks *******************************/ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 Mar '22

16 Mar '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1515356: Uninitialized members (UNINIT_CTOR) /lib/northbound_grpc.cpp: 139 in RpcStateBase::RpcStateBase(const char *)() ________________________________________________________________________________________________________ *** CID 1515356: Uninitialized members (UNINIT_CTOR) /lib/northbound_grpc.cpp: 139 in RpcStateBase::RpcStateBase(const char *)() 133 { 134 public: 135 virtual void do_request(::frr::Northbound::AsyncService *service, 136 ::grpc::ServerCompletionQueue *cq, 137 bool no_copy) = 0; 138 >>> CID 1515356: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "entered_state" is not initialized in this constructor nor in any functions that it calls. 139 RpcStateBase(const char *name) : name(name){}; 140 141 virtual ~RpcStateBase() = default; 142 143 CallState get_state() const 144 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

bgp connection between 2 Nodes with IPv6 on global IPs and want to route via global ipv6 address not via ipv6 link local address
by SANDEEP KUMAR 16 Mar '22

16 Mar '22

Hi All, BGP connection between 2 Nodes with IPv6 on global IPs and want to route via global ipv6 address not via ipv6 link local address I have made the bgp connection with global ipv6 address of interface and advertising the ipv6 route when advertising the route then bgp route added on Node2 for *2003:4001:5001::/64 via **fe80::6548:ed45:d5d:b578:link address of Node1 **but i want route with via * *5001:1::9 global ipv6 address (**2003:4001:5001::/64 via **5001:1::9) * Similarly when we advertise 8001:1::/64 from Node2, *So want help so that I can achieve the bgp route added on Node1 and Node2 via global ipv6 address not with ipv6 link address* 2003:4001:5001::/64 ------------[Node1]<===========================>[Node2]------------- 8001:1::/64 ASN:65001 ASN:65002 *5001:1::9:global * *5001:1::10:global* *fe80::6548:ed45:d5d:b578:link * *fe80::2938:1046:591:8387:link* *[Node1 configuration and interface info]* [root@localhost centosecmp]#* ifconfig ens5|grep inet* inet 10.5.10.9 netmask 255.255.255.0 broadcast 10.5.10.255 *inet6 5001:1::9 prefixlen 64 scopeid 0x0<global>* *inet6 fe80::6548:ed45:d5d:b578 prefixlen 64 scopeid 0x20<link>* localhost.localdomain(config-router)# *do show running-config* Building configuration... Current configuration: ! frr version 7.2 frr defaults traditional hostname localhost.localdomain ! *router bgp 65001 bgp router-id 1.1.1.1 no bgp default ipv4-unicast neighbor 5001:1::10 remote-as 65002 ! address-family ipv6 unicast network 2003:4001:5001::/64 neighbor 5001:1::10 activate exit-address-family* ! line vty ! end localhost.localdomain(config-router)#* do show ip bgp ipv6 summary* IPv6 Unicast Summary: BGP router identifier 1.1.1.1, local AS number 65001 vrf-id 0 BGP table version 2 RIB entries 3, using 552 bytes of memory Peers 1, using 20 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd *5001:1::10 4 65002 7 7 0 0 0 00:02:13 1* Total number of neighbors 1 localhost.localdomain(config-router)# *do show ipv6 route bgp* Codes: K - kernel route, C - connected, S - static, R - RIPng, O - OSPFv3, I - IS-IS, B - BGP, N - NHRP, T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP, F - PBR, f - OpenFabric, > - selected route, * - FIB route, q - queued route, r - rejected route *B>* 8001:1::/64 [20/0] via fe80::2938:1046:591:8387, ens5, 00:02:19* *[Node2 configuration and interface info]* [root@localhost centosecmp]# *ifconfig ens4|grep inet* inet 10.5.10.10 netmask 255.255.255.0 broadcast 10.5.10.255 *inet6 fe80::2938:1046:591:8387 prefixlen 64 scopeid 0x20<link>* * inet6 5001:1::10 prefixlen 64 scopeid 0x0<global>* localhost.localdomain(config-router)# *do show running-config* Building configuration... Current configuration: ! frr version 7.2 frr defaults traditional hostname localhost.localdomain ! *router bgp 65002 bgp router-id 222.222.222.222 no bgp default ipv4-unicast neighbor 5001:1::9 remote-as 65001 ! address-family ipv6 unicast network 8001:1::/64 neighbor 5001:1::9 activate exit-address-family* ! line vty ! end localhost.localdomain(config-router)# *do show ip bgp ipv6 summary* IPv6 Unicast Summary: BGP router identifier 222.222.222.222, local AS number 65002 vrf-id 0 BGP table version 2 RIB entries 3, using 552 bytes of memory Peers 1, using 20 KiB of memory Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd *5001:1::9 4 65001 9 9 0 0 0 00:04:48 1* Total number of neighbors 1 localhost.localdomain(config-router)# *do show ipv6 route bgp* Codes: K - kernel route, C - connected, S - static, R - RIPng, O - OSPFv3, I - IS-IS, B - BGP, N - NHRP, T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP, F - PBR, f - OpenFabric, > - selected route, * - FIB route, q - queued route, r - rejected route *B>* 2003:4001:5001::/64 [20/0] via fe80::6548:ed45:d5d:b578, ens4, 00:05:08* Thanks & Regards, Sandeep Kumar

2 1

Announcing FRR Release 8.2.2
by Jafar Al-Gharaibeh 15 Mar '22

15 Mar '22

Hi all, We are pleased to announce FRR 8.2.2 release. This release brings a long list of enhancements and fixes with more than 800 commits from 58 developers. Packages: Debian Packages - https://deb.frrouting.org/ <https://deb.frrouting.org/> RPM Packages - https://rpm.frrouting.org/ <https://rpm.frrouting.org/> Snaps - https://snapcraft.io/frr <https://snapcraft.io/frr> Docker - frrouting/frr:v8.2.2 https://hub.docker.com/layers/frrouting/frr/v8.2.2/images/sha256-b236f9d9d6… Some major highlights: - BGP Long-lived graceful restart capability (http://docs.frrouting.org/en/stable-8.2/bgp.html#long-lived-graceful-restart) - BGP Extended Optional Parameters Length for BGP OPEN Message (http://docs.frrouting.org/en/stable-8.2/bgp.html#clicmd-neighbor-PEER-exten…) - BGP Extended BGP Administrative Shutdown Communication - IS-IS Link State Traffic Engineering support (http://docs.frrouting.org/en/stable-8.2/isisd.html#traffic-engineering) - OSPFv3 Support for NSSA Type-7 address ranges (http://docs.frrouting.org/en/stable-8.2/ospf6d.html#ospf6-area) - PBR VLAN actions support (http://docs.frrouting.org/en/stable-8.2/pbr.html#pbr-maps) Please see the release notes for the detailed changelog: * Github release: https://github.com/FRRouting/frr/releases/tag/frr-8.2.2 * FRRouting website: https://frrouting.org/release/8.2.2/ Thanks to all contributors! Cheers, The FRR Development Team!

1 0

Re: [dev] How to communicate on /run/frr/ldpd.vty unix socket
by William Herrin 12 Mar '22

12 Mar '22

On Fri, Mar 11, 2022 at 12:10 PM Girish Patoliya via dev <dev(a)lists.frrouting.org> wrote: > currently write() is failing with bad file descriptor error. Since it's a socket not a pipe, maybe you have to send() instead of write()? -- William Herrin bill(a)herrin.us https://bill.herrin.us/

2 1