- dev - lists.frrouting.org

Ubuntu 22 Question
by Fatih Ünlü 18 Jun '22

18 Jun '22

Hello Dear Dev Team, Thank you for great software. My cloud provider provides me arm based server only with Ubuntu 22. Frr on official repo is a bit outdated which is 8.1 Is there any plan from your side to support Ubuntu 22 on your repo? Thank you BR Fatih

1 0

Question about BGP NLRI structure
by johnjdunbar＠disroot.org 10 Jun '22

10 Jun '22

I'm trying to implement https://datatracker.ietf.org/doc/draft-ietf-idr-sdwan-edge-discovery/ into frr/bgpd. Looking through the code I have some questions for which I hope someone can help me RFC 4760 defines the mp_reach_nlri attributes as this +---------------------------------------------------------+ | Address Family Identifier (2 octets) | +---------------------------------------------------------+ | Subsequent Address Family Identifier (1 octet) | +---------------------------------------------------------+ | Length of Next Hop Network Address (1 octet) | +---------------------------------------------------------+ | Network Address of Next Hop (variable) | +---------------------------------------------------------+ | Reserved (1 octet) | +---------------------------------------------------------+ | Network Layer Reachability Information (variable) | +---------------------------------------------------------+ Is the following structure in /bgpd/bgpd.h representing the table above? struct bgp_nlri { /* AFI. */ uint16_t afi; /* iana_afi_t */ /* SAFI. */ uint8_t safi; /* iana_safi_t */ /* Pointer to NLRI byte stream. */ uint8_t *nlri; /* Length of whole NLRI. */ bgp_size_t length; }; If yes, does uint8_t *nlri map to [Network Layer Reachability Information (variable)]? does bgp_size_t length map to [Length of Next Hop Network Address (1 octet)]? If not, can someone please tell me what this structure maps to? I appreciate anyone who has insights to help me out. Thank you, John

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 08 Jun '22

08 Jun '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1518122: Memory - illegal accesses (OVERRUN) /ospfd/ospf_api.c: 676 in new_msg_reachable_change() ________________________________________________________________________________________________________ *** CID 1518122: Memory - illegal accesses (OVERRUN) /ospfd/ospf_api.c: 676 in new_msg_reachable_change() 670 if (nremove > (nmax - nadd)) 671 nremove = (nmax - nadd); 672 673 if (nadd) 674 memcpy(nmsg->router_ids, add, nadd * insz); 675 if (nremove) >>> CID 1518122: Memory - illegal accesses (OVERRUN) >>> Overrunning array of 1536 bytes at byte offset 1536 by dereferencing pointer "&nmsg->router_ids[nadd]". 676 memcpy(&nmsg->router_ids[nadd], remove, nremove * insz); 677 678 nmsg->nadd = htons(nadd); 679 nmsg->nremove = htons(nremove); 680 len = sizeof(*nmsg) + insz * (nadd + nremove); 681 682 return msg_new(MSG_REACHABLE_CHANGE, nmsg, seqnum, len); 683 } 684 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 May '22

20 May '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1517953: Error handling issues (CHECKED_RETURN) /zebra/kernel_netlink.c: 313 in netlink_socket() ________________________________________________________________________________________________________ *** CID 1517953: Error handling issues (CHECKED_RETURN) /zebra/kernel_netlink.c: 313 in netlink_socket() 307 memset(&snl, 0, sizeof(snl)); 308 snl.nl_family = AF_NETLINK; 309 snl.nl_groups = groups; 310 311 #if defined SOL_NETLINK 312 if (ext_groups) >>> CID 1517953: Error handling issues (CHECKED_RETURN) >>> Calling "setsockopt(sock, 270, 1, &ext_groups, 8U)" without checking return value. This library function may fail and return an error code. 313 setsockopt(sock, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, 314 &ext_groups, sizeof(ext_groups)); 315 #endif 316 317 /* Bind the socket to the netlink structure for anything. */ 318 ret = bind(sock, (struct sockaddr *)&snl, sizeof(snl)); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 May '22

13 May '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1517751: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1517751: Uninitialized variables (UNINIT) /bgpd/bgp_evpn_vty.c: 1648 in show_ip_bgp_l2vpn_evpn_rd_neighbor_routes() 1642 1643 1644 if (rd_all) 1645 return bgp_show_ethernet_vpn(vty, NULL, bgp_show_type_neighbor, 1646 peer, SHOW_DISPLAY_STANDARD, uj); 1647 else >>> CID 1517751: Uninitialized variables (UNINIT) >>> Using uninitialized element of array "prd.val" when calling "bgp_show_ethernet_vpn". 1648 return bgp_show_ethernet_vpn(vty, &prd, bgp_show_type_neighbor, 1649 peer, SHOW_DISPLAY_STANDARD, uj); 1650 } 1651 1652 DEFUN(show_ip_bgp_l2vpn_evpn_neighbor_advertised_routes, 1653 show_ip_bgp_l2vpn_evpn_neighbor_advertised_routes_cmd, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 29 Apr '22

29 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1517499: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 5710 in bgp_nlri_parse_ip() ________________________________________________________________________________________________________ *** CID 1517499: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 5710 in bgp_nlri_parse_ip() 5704 "%s [Error] Update packet error (prefix length %d too large for prefix storage %zu)", 5705 peer->host, p.prefixlen, sizeof(p.u)); 5706 return BGP_NLRI_PARSE_ERROR_PACKET_LENGTH; 5707 } 5708 5709 /* Fetch prefix from NLRI packet. */ >>> CID 1517499: Memory - corruptions (OVERRUN) >>> Overrunning array "p.u.val" of 16 bytes by passing it to a function which accesses it at byte offset 47 using argument "psize" (which evaluates to 48). 5710 memcpy(p.u.val, pnt, psize); 5711 5712 /* Check address. */ 5713 if (afi == AFI_IP && safi == SAFI_UNICAST) { 5714 if (IN_CLASSD(ntohl(p.u.prefix4.s_addr))) { 5715 /* From RFC4271 Section 6.3: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Apr '22

27 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1517454: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 663 in ipv6_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1517454: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 663 in ipv6_mld_group_watermark_magic() 657 "ipv6 mld watermark-warn (1-65535)$limit", 658 IPV6_STR 659 MLD_STR 660 "Configure group limit for watermark warning\n" 661 "Group count to generate watermark warning\n") 662 { >>> CID 1517454: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 663 PIM_DECLVAR_CONTEXT(vrf, pim); 664 /* TBD Depends on MLD data structure changes */ 665 return CMD_SUCCESS; 666 } 667 668 DEFPY (no_ipv6_mld_group_watermark, ** CID 1517453: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 677 in no_ipv6_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1517453: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 677 in no_ipv6_mld_group_watermark_magic() 671 NO_STR 672 IPV6_STR 673 MLD_STR 674 "Unconfigure group limit for watermark warning\n" 675 IGNORED_IN_NO_STR) 676 { >>> CID 1517453: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 677 PIM_DECLVAR_CONTEXT(vrf, pim); 678 /* TBD Depends on MLD data structure changes */ 679 return CMD_SUCCESS; 680 } 681 682 DEFPY (interface_ipv6_mld_query_max_response_time, ** CID 1517452: Memory - corruptions (OVERRUN) /pimd/pim_zlookup.c: 265 in zclient_read_nexthop() ________________________________________________________________________________________________________ *** CID 1517452: Memory - corruptions (OVERRUN) /pimd/pim_zlookup.c: 265 in zclient_read_nexthop() 259 stream_get(&nexthop_tab[num_ifindex].nexthop_addr, s, 260 sizeof(struct in6_addr)); 261 nexthop_tab[num_ifindex].ifindex = stream_getl(s); 262 263 p.family = AF_INET6; 264 p.prefixlen = IPV6_MAX_BITLEN; >>> CID 1517452: Memory - corruptions (OVERRUN) >>> Overrunning struct type pim_addr of 4 bytes by passing it to a function which accesses it at byte offset 15 using argument "16UL". 265 memcpy(&p.u.prefix6, 266 &nexthop_tab[num_ifindex].nexthop_addr, 267 sizeof(struct in6_addr)); 268 269 /* 270 * If we are sending v6 secondary assume we receive v6 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Weekly discussion on MGMT infra and YANG
by Pushpasis Sarkar 12 Apr '22

12 Apr '22

Hi All, As discussed in today’s weekly meeting, setting up this weekly meeting for anyone to bringup and discuss any issues or points regarding the new MGMT work and any other related to YANG infra in general. Individuals who want to discuss anything on these meetings are requested to send the agenda on the ‘yang’ slack channel first. Without any agenda from any member the particular instance of the meeting shall stand cancelled. Thanks and regards -Pushpasis

1 0

Running FRR rpm in container with VPP
by Girish Patoliya 07 Apr '22

07 Apr '22

Hi, I am running ldpd daemon in container where ldpd uses vpp tap as interface. My ldp session gets rejected with error "No Hello", I see lot of below errors: pending_conn_timeout: no adjacency with remote end: 127.0.0.6 What I understand from this is LDP somehow not able to get proper source peer IP from hello message, is that correct? Any idea what could be going wrong ? Thanks a lot Girish ________________________________ This e-mail message may contain confidential or proprietary information of Mavenir Systems, Inc. or its affiliates and is intended solely for the use of the intended recipient(s). If you are not the intended recipient of this message, you are hereby notified that any review, use or distribution of this information is absolutely prohibited and we request that you delete all copies in your control and contact us by e-mailing to security(a)mavenir.com. This message contains the views of its author and may not necessarily reflect the views of Mavenir Systems, Inc. or its affiliates, who employ systems to monitor email messages, but make no representation that such messages are authorized, secure, uncompromised, or free from computer viruses, malware, or other defects. Thank You

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Apr '22

06 Apr '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1515741: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 636 in mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1515741: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 636 in mld_group_watermark_magic() 630 "ipv6 mld watermark-warn (1-65535)$limit", 631 IPV6_STR 632 MLD_STR 633 "Configure group limit for watermark warning\n" 634 "Group count to generate watermark warning\n") 635 { >>> CID 1515741: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 636 PIM_DECLVAR_CONTEXT(vrf, pim); 637 /* TBD Depends on MLD data structure changes */ 638 return CMD_SUCCESS; 639 } 640 641 DEFPY (no_mld_group_watermark, ** CID 1515740: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 650 in no_mld_group_watermark_magic() ________________________________________________________________________________________________________ *** CID 1515740: Null pointer dereferences (NULL_RETURNS) /pimd/pim6_cmd.c: 650 in no_mld_group_watermark_magic() 644 NO_STR 645 IPV6_STR 646 MLD_STR 647 "Unconfigure group limit for watermark warning\n" 648 IGNORED_IN_NO_STR) 649 { >>> CID 1515740: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim", which is known to be "NULL". 650 PIM_DECLVAR_CONTEXT(vrf, pim); 651 /* TBD Depends on MLD data structure changes */ 652 return CMD_SUCCESS; 653 } 654 655 DEFPY (interface_ipv6_mld_query_max_response_time, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0