- dev - lists.frrouting.org

Weekly FRR YANG Meeting
by Pushpasis Sarkar 14 Nov '22

14 Nov '22

Hi Resending the meeting invite for the weekly YANG meeting. Whoever are interested in the ongoing YANG related work in FRR community, are welcome to join this Bluejeans meeting. https://bluejeans.com/377688464 Thanks and regards, -Pushasis

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 Nov '22

09 Nov '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1527246: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1527246: Null pointer dereferences (FORWARD_NULL) /isisd/isis_route.c: 500 in isis_route_update() 494 /* Install route. */ 495 if (area) 496 isis_zebra_route_add_route(area->isis, prefix, src_p, 497 route_info); 498 /* Install/reinstall Prefix-SID label. */ 499 if (route_info->sr.present) >>> CID 1527246: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "area" to "isis_zebra_prefix_sid_install", which dereferences it. 500 isis_zebra_prefix_sid_install(area, prefix, route_info, 501 &route_info->sr); 502 hook_call(isis_route_update_hook, area, prefix, route_info); 503 504 SET_FLAG(route_info->flag, ISIS_ROUTE_FLAG_ZEBRA_SYNCED); 505 UNSET_FLAG(route_info->flag, ISIS_ROUTE_FLAG_ZEBRA_RESYNC); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Results of the 2022 TSC Vote
by Alistair Woodman 08 Nov '22

08 Nov '22

Results of the 2022 TSC Vote All, 21 of 23 maintainers have voted in the TSC Election for the 2022-2023 session. By the single transferable vote algorithm, the following candidates are elected to the TSC. (in alphabetical, not ranked order) · Jafar Al-Gharaibeh · Lou Berger · Donald Sharp · Mark Stapp · Russ White · Martin Winter Your elections officer P.S. I’d like to apologize for the issues with voting via SurveyMonkey. I will look into other options for next year. (Suggestions welcome). /a

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Oct '22

26 Oct '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1526738: Control flow issues (DEADCODE) /lib/zclient.c: 2398 in zebra_interface_link_params_read() ________________________________________________________________________________________________________ *** CID 1526738: Control flow issues (DEADCODE) /lib/zclient.c: 2398 in zebra_interface_link_params_read() 2392 *changed = true; 2393 else 2394 *changed = false; 2395 } else if (!iflp_prev_set && !iflp) 2396 *changed = false; 2397 else >>> CID 1526738: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "*changed = true;". 2398 *changed = true; 2399 2400 return ifp; 2401 2402 stream_failure: 2403 return NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

FWD: FRR TSC Vote for 2022
by Alistair Woodman 21 Oct '22

21 Oct '22

All, you should have received your invite to take part in the TSC elections. At the time of writing I have 13 votes completed. This evening I have re-sent invites to personal address of 4 voters who had registered ‘non-receipt’ of the original. Reach out to either Donald or me if you cannot find the voting invite. I have attached my (demo) email from Survey Monkey so that you can see the format and check your spam filters. (to be clear, I do not vote in the elections as I’m not a maintainers) /a > From: "awoodman(a)netdef.org via SurveyMonkey" <member(a)surveymonkeyuser.com> > Date: October 18, 2022 at 08:01:44 PDT > To: awoodman(a)netdef.org > Subject: FRR TSC Vote for 2022 > Reply-To: awoodman(a)netdef.org > > > > FRR Community. 2022-10 TSC Vote > > > > This is the invition to vote for the TSC of the FRR community. Please stack rank your choices. > (There are 7 candidates for 6 seats on the TSC. Voting is by single transferable vote.) > > > > > Begin Survey > > > > Please do not forward this email as its survey link is unique to you. > Privacy | Unsubscribe > > > >

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Oct '22

19 Oct '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1526378: Control flow issues (DEADCODE) /bgpd/bgp_evpn_vty.c: 6631 in bgp_config_write_evpn_info() ________________________________________________________________________________________________________ *** CID 1526378: Control flow issues (DEADCODE) /bgpd/bgp_evpn_vty.c: 6631 in bgp_config_write_evpn_info() 6625 if (CHECK_FLAG(l3rt->flags, BGP_VRF_RT_WILD)) { 6626 char *vni_str = NULL; 6627 6628 vni_str = strchr(ecom_str, ':') + 1; 6629 6630 if (!vni_str) >>> CID 1526378: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "continue;". 6631 continue; /* This should never happen */ 6632 6633 vty_out(vty, " route-target import *:%s\n", 6634 vni_str); 6635 6636 } else ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 13 Oct '22

13 Oct '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1526337: (SIZEOF_MISMATCH) /ospfd/ospf_spf.c: 1845 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1837 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1847 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1849 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1843 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1835 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1841 in ospf_spf_calculation_reason2str() /ospfd/ospf_spf.c: 1839 in ospf_spf_calculation_reason2str() ________________________________________________________________________________________________________ *** CID 1526337: (SIZEOF_MISMATCH) /ospfd/ospf_spf.c: 1845 in ospf_spf_calculation_reason2str() 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1845 strlcat(rbuf, "ASBR, ", sizeof(rbuf)); 1846 if (spf_reason_flags & (1 << SPF_FLAG_MAXAGE)) 1847 strlcat(rbuf, "M, ", sizeof(rbuf)); 1848 if (spf_reason_flags & (1 << SPF_FLAG_ORR_ROOT_CHANGE)) 1849 strlcat(rbuf, "ORR, ", sizeof(rbuf)); 1850 /ospfd/ospf_spf.c: 1837 in ospf_spf_calculation_reason2str() 1831 { 1832 rbuf[0] = '\0'; 1833 if (spf_reason_flags) { 1834 if (spf_reason_flags & (1 << SPF_FLAG_ROUTER_LSA_INSTALL)) 1835 strlcat(rbuf, "R, ", sizeof(rbuf)); 1836 if (spf_reason_flags & (1 << SPF_FLAG_NETWORK_LSA_INSTALL)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1837 strlcat(rbuf, "N, ", sizeof(rbuf)); 1838 if (spf_reason_flags & (1 << SPF_FLAG_SUMMARY_LSA_INSTALL)) 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) /ospfd/ospf_spf.c: 1847 in ospf_spf_calculation_reason2str() 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) 1845 strlcat(rbuf, "ASBR, ", sizeof(rbuf)); 1846 if (spf_reason_flags & (1 << SPF_FLAG_MAXAGE)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1847 strlcat(rbuf, "M, ", sizeof(rbuf)); 1848 if (spf_reason_flags & (1 << SPF_FLAG_ORR_ROOT_CHANGE)) 1849 strlcat(rbuf, "ORR, ", sizeof(rbuf)); 1850 1851 size_t rbuflen = strlen(rbuf); 1852 if (rbuflen >= 2) /ospfd/ospf_spf.c: 1849 in ospf_spf_calculation_reason2str() 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) 1845 strlcat(rbuf, "ASBR, ", sizeof(rbuf)); 1846 if (spf_reason_flags & (1 << SPF_FLAG_MAXAGE)) 1847 strlcat(rbuf, "M, ", sizeof(rbuf)); 1848 if (spf_reason_flags & (1 << SPF_FLAG_ORR_ROOT_CHANGE)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1849 strlcat(rbuf, "ORR, ", sizeof(rbuf)); 1850 1851 size_t rbuflen = strlen(rbuf); 1852 if (rbuflen >= 2) 1853 rbuf[rbuflen - 2] = '\0'; /* skip the last ", " */ 1854 else /ospfd/ospf_spf.c: 1843 in ospf_spf_calculation_reason2str() 1837 strlcat(rbuf, "N, ", sizeof(rbuf)); 1838 if (spf_reason_flags & (1 << SPF_FLAG_SUMMARY_LSA_INSTALL)) 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) 1845 strlcat(rbuf, "ASBR, ", sizeof(rbuf)); 1846 if (spf_reason_flags & (1 << SPF_FLAG_MAXAGE)) 1847 strlcat(rbuf, "M, ", sizeof(rbuf)); 1848 if (spf_reason_flags & (1 << SPF_FLAG_ORR_ROOT_CHANGE)) /ospfd/ospf_spf.c: 1835 in ospf_spf_calculation_reason2str() 1829 /* Print Reason for SPF calculation */ 1830 static void ospf_spf_calculation_reason2str(char *rbuf) 1831 { 1832 rbuf[0] = '\0'; 1833 if (spf_reason_flags) { 1834 if (spf_reason_flags & (1 << SPF_FLAG_ROUTER_LSA_INSTALL)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1835 strlcat(rbuf, "R, ", sizeof(rbuf)); 1836 if (spf_reason_flags & (1 << SPF_FLAG_NETWORK_LSA_INSTALL)) 1837 strlcat(rbuf, "N, ", sizeof(rbuf)); 1838 if (spf_reason_flags & (1 << SPF_FLAG_SUMMARY_LSA_INSTALL)) 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) /ospfd/ospf_spf.c: 1841 in ospf_spf_calculation_reason2str() 1835 strlcat(rbuf, "R, ", sizeof(rbuf)); 1836 if (spf_reason_flags & (1 << SPF_FLAG_NETWORK_LSA_INSTALL)) 1837 strlcat(rbuf, "N, ", sizeof(rbuf)); 1838 if (spf_reason_flags & (1 << SPF_FLAG_SUMMARY_LSA_INSTALL)) 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) 1845 strlcat(rbuf, "ASBR, ", sizeof(rbuf)); 1846 if (spf_reason_flags & (1 << SPF_FLAG_MAXAGE)) /ospfd/ospf_spf.c: 1839 in ospf_spf_calculation_reason2str() 1833 if (spf_reason_flags) { 1834 if (spf_reason_flags & (1 << SPF_FLAG_ROUTER_LSA_INSTALL)) 1835 strlcat(rbuf, "R, ", sizeof(rbuf)); 1836 if (spf_reason_flags & (1 << SPF_FLAG_NETWORK_LSA_INSTALL)) 1837 strlcat(rbuf, "N, ", sizeof(rbuf)); 1838 if (spf_reason_flags & (1 << SPF_FLAG_SUMMARY_LSA_INSTALL)) >>> CID 1526337: (SIZEOF_MISMATCH) >>> Passing argument "rbuf" of type "char *" and argument "8UL /* sizeof (rbuf) */" to function "strlcat" is suspicious. 1839 strlcat(rbuf, "S, ", sizeof(rbuf)); 1840 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_SUMMARY_LSA_INSTALL)) 1841 strlcat(rbuf, "AS, ", sizeof(rbuf)); 1842 if (spf_reason_flags & (1 << SPF_FLAG_ABR_STATUS_CHANGE)) 1843 strlcat(rbuf, "ABR, ", sizeof(rbuf)); 1844 if (spf_reason_flags & (1 << SPF_FLAG_ASBR_STATUS_CHANGE)) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Final request for nominations of candidates for the 2022 FRR TSC election.
by Alistair Woodman 04 Oct '22

04 Oct '22

All, This is the final call for candidates for the 2022 FRR TSC election. Standing down from the TSC are: 1) Quentin Young 2) Sri Mohana Singamsetty Already nominated are: 1) Jafar Al-Gharaibeh 2) Mark Stapp 3) Mobashshera Rasool 4) Pushpasis Sarkar (plus the remaining 4 TSC members) As things stand, this means there are at present 8 candidates for 6 positions. I will close the nominations window in 48 hours and plan to start the voting by week’s end. /a FRR elections officer

1 0

Discussion on Flex-Algo library
by Pushpasis Sarkar 29 Sep '22

29 Sep '22

Hi all, Rescheduling it to week of 10th Oct as per Louis’ request. Thanks -Pushpasis ========================================= Hi all, Like discussed in this week FRR meeting, we need to meet and discuss to choose between the versions of lib/flex_algo component being added in both PRs 11667 (ISIS Flex-Algo) and 11849 (OSPFv2 Flex-Algo). Looking forward to your participation Thanks and regards -Pushpasis

1 0

First request for nominations of candidates for the 2022 TSC election.
by Alistair Woodman 28 Sep '22

28 Sep '22

All, This is the first request for nominations for candidates for the 2022 TSC elections. Please contact me with nominations or questions. 1) Self-nominations are welcome. 2) All nominees must be active FRR maintainers in order to stand. 3) Present TSC members must opt-out of being auto-nominated. 4) If you plan to nominate someone else, please get their approval first. /a (your friendly FRR community elections officer)

2 1