- dev - lists.frrouting.org

Researchers Uncover New BGP Flaws in Popular Internet Routing Protocol Software
by Turritopsis Dohrnii Teo En Ming 10 May '23

10 May '23

Subject: Researchers Uncover New BGP Flaws in Popular Internet Routing Protocol Software Good day from Singapore, I have just come across this article. Thought of sharing it. Article: Researchers Uncover New BGP Flaws in Popular Internet Routing Protocol Software Link: https://thehackernews.com/2023/05/researchers-uncover-new-bgp-flaws-in.html Thank you. Regards, Mr. Turritopsis Dohrnii Teo En Ming Targeted Individual in Singapore Blogs: https://tdtemcerts.blogspot.com https://tdtemcerts.wordpress.com GIMP also stands for Government-Induced Medical Problems.

1 0

Re: [sonic-dev] [sonic-wg-routing] A reminder for 5/4 SONiC Routing WG kick off meeting
by Eddie Ruan 04 May '23

04 May '23

Thanks Lucy for bringing this issue up. I will ask our in house BGP folks to evaluate these three issues. In general, I would expect this is the issue for SONiC deployment as we use FRR BGP. Thanks Eddie ------------------------------------------------------------------ From:Lucy Hyde <lhyde(a)linuxfoundation.org> Sent At:2023 May 3 (Wed.) 19:21 To:sonic-wg-routing@lists.sonicfoundation.dev <sonic-wg-routing(a)lists.sonicfoundation.dev>; sonic-dev <sonic-dev(a)lists.sonicfoundation.dev>; Praveen Bhagwatula (pbhagwat) <pbhagwat(a)cisco.com>; Syed Hasan Raza Naqvi <syed.naqvi(a)broadcom.com>; Rita Hui <Rita.Hui(a)microsoft.com>; dev <dev(a)lists.frrouting.org> Cc:Yanzhao Zhang <yanzhaoz(a)microsoft.com>; Lihua Yuan <Lihua.Yuan(a)microsoft.com> Subject:Re: [sonic-dev] [sonic-wg-routing] A reminder for 5/4 SONiC Routing WG kick off meeting Hello SONiC Routing Working Group, I’m not sure if this is the appropriate place to ask this question and will also bring it up to the TSC- but I saw the note about using FRR in SONiC below and this article was flagged to me for investigation this morning: https://thehackernews.com/2023/05/researchers-uncover-new-bgp-flaws-in.html… <https://thehackernews.com/2023/05/researchers-uncover-new-bgp-flaws-in.html… > It discusses three vulnerabilities in FRRouting, and specifically mentions Cumulus, DENT, and SONiC. Please let me know if this is already being worked (so I can let Arpit know) and if not, if I can provide any assistance with regard to security scanning and audit and how you would like to proceed. Best, Lucy Lucy Hyde Program Manager | LF Projects in AI & Networking The Linux Foundation From: sonic-wg-routing(a)lists.sonicfoundation.dev <sonic-wg-routing(a)lists.sonicfoundation.dev> on behalf of Eddie Ruan via lists.sonicfoundation.dev <eddie.ruan=alibaba-inc.com(a)lists.sonicfoundation.dev> Date: Wednesday, May 3, 2023 at 12:15 PM To: sonic-wg-routing <sonic-wg-routing(a)lists.sonicfoundation.dev>, sonic-dev <sonic-dev(a)lists.sonicfoundation.dev>, Praveen Bhagwatula (pbhagwat) <pbhagwat(a)cisco.com>, Syed Hasan Raza Naqvi <syed.naqvi(a)broadcom.com>, Rita Hui <Rita.Hui(a)microsoft.com>, dev <dev(a)lists.frrouting.org> Cc: Yanzhao Zhang <yanzhaoz(a)microsoft.com>, Lihua Yuan <Lihua.Yuan(a)microsoft.com> Subject: [sonic-wg-routing] A reminder for 5/4 SONiC Routing WG kick off meeting Hi, Just a friendly reminder that we will have routing WG kick off meeting on 5/4 5:30-6:30pm PST (5/5 8:30-9:30 am China time). The zoom info could be found below. You could subscribe this WG via https://lists.sonicfoundation.dev/g/sonic-wg-routing <https://lists.sonicfoundation.dev/g/sonic-wg-routing > * Subscribe: sonic-wg-routing+subscribe(a)lists.sonicfoundation.dev <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > I also include FRR email alias as well, since we use FRR as routing stack in SONiC and there are some enhancements needed from both FRR and SONiC to fully support routing features. Thanks Praveen, Hasan, Rita, Eddie Please download and import the following iCalendar (.ics) files to your calendar system. Weekly: https://zoom.us/meeting/tJEvdOCpqjsoG9dYQnhKle_6lwCLbPogZgPq/ics?icsToken=9… <https://zoom.us/meeting/tJEvdOCpqjsoG9dYQnhKle_6lwCLbPogZgPq/ics?icsToken=9… > Join Zoom Meeting https://zoom.us/j/95239140213 <https://zoom.us/j/95239140213 > Meeting ID: 952 3914 0213 One tap mobile +13126266799,,95239140213# US (Chicago) +16465588656,,95239140213# US (New York) Dial by your location +1 312 626 6799 US (Chicago) +1 646 558 8656 US (New York) +1 646 931 3860 US +1 301 715 8592 US (Washington DC) +1 305 224 1968 US +1 309 205 3325 US +1 360 209 5623 US +1 386 347 5053 US +1 507 473 4847 US +1 564 217 2000 US +1 669 444 9171 US +1 669 900 6833 US (San Jose) +1 689 278 1000 US +1 719 359 4580 US +1 253 205 0468 US +1 253 215 8782 US (Tacoma) +1 346 248 7799 US (Houston) 877 369 0926 US Toll-free 855 880 1246 US Toll-free +1 204 272 7920 Canada +1 438 809 7799 Canada +1 587 328 1099 Canada +1 647 374 4685 Canada +1 647 558 0588 Canada +1 778 907 2071 Canada +1 780 666 0144 Canada 855 703 8985 Canada Toll-free Meeting ID: 952 3914 0213 Find your local number: https://zoom.us/u/aewVD44sd4 <https://zoom.us/u/aewVD44sd4 > _._,_._,_ Links: You receive all messages sent to this group. View/Reply Online (#278) <https://lists.sonicfoundation.dev/g/sonic-dev/message/278 > | Reply To Sender <mailto:lhyde@linuxfoundation.org?subject=Private:%20Re:%20Re%3A%20%5Bsonic-dev%5D%20%5Bsonic-wg-routing%5D%20A%20reminder%20for%205%2F4%20SONiC%20Routing%20WG%20kick%20off%20meeting > | Reply To Group <mailto:sonic-dev@lists.sonicfoundation.dev?subject=Re:%20Re%3A%20%5Bsonic-dev%5D%20%5Bsonic-wg-routing%5D%20A%20reminder%20for%205%2F4%20SONiC%20Routing%20WG%20kick%20off%20meeting > | Mute This Topic <https://lists.sonicfoundation.dev/mt/98676540/7341548 > | New Topic <https://lists.sonicfoundation.dev/g/sonic-dev/post > Your Subscription <https://lists.sonicfoundation.dev/g/sonic-dev/editsub/7341548 > | Contact Group Owner <mailto:sonic-dev+owner@lists.sonicfoundation.dev > | Unsubscribe <https://lists.sonicfoundation.dev/g/sonic-dev/leave/11873633/7341548/944543… > [eddie.ruan(a)alibaba-inc.com] _._,_._,_

1 0

A reminder for 5/4 SONiC Routing WG kick off meeting
by Eddie Ruan 03 May '23

03 May '23

Hi, Just a friendly reminder that we will have routing WG kick off meeting on 5/4 5:30-6:30pm PST (5/5 8:30-9:30 am China time). The zoom info could be found below. You could subscribe this WG via https://lists.sonicfoundation.dev/g/sonic-wg-routing <https://lists.sonicfoundation.dev/g/sonic-wg-routing > * Subscribe: sonic-wg-routing+subscribe(a)lists.sonicfoundation.dev <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > I also include FRR email alias as well, since we use FRR as routing stack in SONiC and there are some enhancements needed from both FRR and SONiC to fully support routing features. Thanks Praveen, Hasan, Rita, Eddie Please download and import the following iCalendar (.ics) files to your calendar system. Weekly: https://zoom.us/meeting/tJEvdOCpqjsoG9dYQnhKle_6lwCLbPogZgPq/ics?icsToken=9… <https://zoom.us/meeting/tJEvdOCpqjsoG9dYQnhKle_6lwCLbPogZgPq/ics?icsToken=9… > Join Zoom Meeting https://zoom.us/j/95239140213 <https://zoom.us/j/95239140213 > Meeting ID: 952 3914 0213 One tap mobile +13126266799,,95239140213# US (Chicago) +16465588656,,95239140213# US (New York) Dial by your location +1 312 626 6799 US (Chicago) +1 646 558 8656 US (New York) +1 646 931 3860 US +1 301 715 8592 US (Washington DC) +1 305 224 1968 US +1 309 205 3325 US +1 360 209 5623 US +1 386 347 5053 US +1 507 473 4847 US +1 564 217 2000 US +1 669 444 9171 US +1 669 900 6833 US (San Jose) +1 689 278 1000 US +1 719 359 4580 US +1 253 205 0468 US +1 253 215 8782 US (Tacoma) +1 346 248 7799 US (Houston) 877 369 0926 US Toll-free 855 880 1246 US Toll-free +1 204 272 7920 Canada +1 438 809 7799 Canada +1 587 328 1099 Canada +1 647 374 4685 Canada +1 647 558 0588 Canada +1 778 907 2071 Canada +1 780 666 0144 Canada 855 703 8985 Canada Toll-free Meeting ID: 952 3914 0213 Find your local number: https://zoom.us/u/aewVD44sd4 <https://zoom.us/u/aewVD44sd4 >

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Apr '23

26 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1560845: Null pointer dereferences (REVERSE_INULL) /ripd/rip_interface.c: 1114 in rip_interface_sync() ________________________________________________________________________________________________________ *** CID 1560845: Null pointer dereferences (REVERSE_INULL) /ripd/rip_interface.c: 1114 in rip_interface_sync() 1108 void rip_interface_sync(struct interface *ifp) 1109 { 1110 struct rip_interface *ri; 1111 1112 ri = ifp->info; 1113 ri->ifp = ifp; >>> CID 1560845: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ri" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1114 if (ri) 1115 ri->rip = ifp->vrf->info; 1116 } 1117 1118 /* Called when interface structure allocated. */ 1119 static int rip_interface_new_hook(struct interface *ifp) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 21 Apr '23

21 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1560675: Resource leaks (RESOURCE_LEAK) /lib/elf_py.c: 1322 in elffile_load() ________________________________________________________________________________________________________ *** CID 1560675: Resource leaks (RESOURCE_LEAK) /lib/elf_py.c: 1322 in elffile_load() 1316 PyErr_Format(ELFFormatError, "libelf error %d: %s", 1317 err, elf_errmsg(err)); 1318 out: 1319 if (w->elf) 1320 elf_end(w->elf); 1321 free(w->filename); >>> CID 1560675: Resource leaks (RESOURCE_LEAK) >>> Handle variable "fd" going out of scope leaks the handle. 1322 return NULL; 1323 } 1324 1325 static PyObject *elfpy_debug(PyObject *self, PyObject *args) 1326 { 1327 int arg; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

frr 8.4.x and 8.5 trigger assertion in bgpd/bgp_lcommunity.c:236
by Kurt Jaeger 21 Apr '23

21 Apr '23

Hi! This caused bgpd to terminate on several boxes this morning: 2023/04/18 08:43:47 BGP: bgpd/bgp_lcommunity.c:236: set_lcommunity_string(): assertion ((unsigned int)len < str_buf_sz) failed BGP: Received signal 6 at 1681800227 (si_addr 0x0); aborting... OS: FreeBSD 13.1p3. frr was 8.4.x and 8.5. So someone is sending strange things... ? 7.5.1 is not affected... Any ideas on how to avoid the assert ? -- pi(a)opsec.eu +49 171 3101372 Now what ?

3 10

Welcome to join SONiC Routing WG
by Eddie Ruan 20 Apr '23

20 Apr '23

Hi, FRR gurus Hi, Praveen, Hasan, Rita and I have set up a SONiC Routing WG. The proposal for setting up this WG could be found at https://lists.sonicfoundation.dev/g/sonic-wg-routing/files/Routing%20workin… <https://lists.sonicfoundation.dev/g/sonic-wg-routing/files/Routing%20workin… > The goal for this WG is to improve white box support as a router. As we discussed in one of the previous FRR weekly meeting, we hit some challenges when starting bringing SONiC to routing platforms. One area we would like to work with FRR folks would be how we could improve the communication channel among FRR, SONiC and Linux Kernel. We welcome anyone from FRR community to join this working group, so we could work together to improve the above area. * Subscribe: sonic-wg-routing+subscribe(a)lists.sonicfoundation.dev <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > The WG page is at https://lists.sonicfoundation.dev/g/sonic-wg-routing <https://lists.sonicfoundation.dev/g/sonic-wg-routing > We plan to hold a kick off meeting on 5/4 5:30pm PST. By: Eddie Ruan <https://lists.sonicfoundation.dev/g/sonic-wg-routing/profile/@eddieruan > When: Thursday, May 4th, 2023 5:30pm to 6:30pm (UTC-07:00) Pacific Time - Los Angeles Location: San Jose <http://maps.google.com/?q=San%20Jose > Organizer: eddie.ruan(a)alibaba-inc.com <mailto:eddie.ruan@alibaba-inc.com?subject=Re:%20Event:%20SONiC%2520Routing%2520work%2520group%2520kick%2520off%2520meeting > Description: SONiC Routing work group kick off meeting Agenda: 1. Eddie, Praveen, Hasan, Rita's Introduction 2. Round table introduction 3. Tentative weekly meeting time, every Th 5:30-6:30 pm PST, 8:30 - 9:30 am China Time 4. Group scope Thanks Praveen, Hasan, Rita, Eddie

1 0

Feeding raw BGP path data to custom backend
by rsa 20 Apr '23

20 Apr '23

Hi, I am new to FRR. Pardon me if this is not the right forum to ask this question. We are interested in using the BGP component of the FRR package. I have a few questions on how we can customize it for our special use case. What we would like to do is 1. turn off Zebra interface as we are not interested in the route computation or sending those routes to Kernel. 2. send BGP post-policy path data to the backend "Watcher" that knows how to handle special cases based on custom community information. Further, is there support for EVPN (type 5) in FRR implementation? Has anyone attempted to feed raw path data (post policy) to a backend Watcher? Appreciate any input. Thank you in advance. Ravi

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Apr '23

19 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1560315: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 49 in isis_affinity_map_update() ________________________________________________________________________________________________________ *** CID 1560315: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 49 in isis_affinity_map_update() 43 struct isis *isis = isis_lookup_by_vrfid(VRF_DEFAULT); 44 struct listnode *area_node, *fa_node; 45 struct isis_area *area; 46 struct flex_algo *fa; 47 bool changed; 48 >>> CID 1560315: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 49 for (ALL_LIST_ELEMENTS_RO(isis->area_list, area_node, area)) { 50 changed = false; 51 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, fa_node, 52 fa)) { 53 if (admin_group_get(&fa->admin_group_exclude_any, 54 old_pos)) { ** CID 1560314: Incorrect expression (NO_EFFECT) /isisd/isisd.c: 3147 in area_resign_level() ________________________________________________________________________________________________________ *** CID 1560314: Incorrect expression (NO_EFFECT) /isisd/isisd.c: 3147 in area_resign_level() 3141 3142 #ifndef FABRICD 3143 for (int tree = SPFTREE_IPV4; tree < SPFTREE_COUNT; tree++) { 3144 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, node, 3145 fa)) { 3146 data = fa->data; >>> CID 1560314: Incorrect expression (NO_EFFECT) >>> Comparing an array to null is not useful: "data->spftree[level - 1]", since the test will always evaluate as true. 3147 if (data->spftree[level - 1]) { 3148 isis_spftree_del( 3149 data->spftree[tree][level - 1]); 3150 data->spftree[tree][level - 1] = NULL; 3151 } 3152 } ** CID 1560313: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 26 in isis_affinity_map_check_use() ________________________________________________________________________________________________________ *** CID 1560313: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 26 in isis_affinity_map_check_use() 20 struct affinity_map *map; 21 uint16_t pos; 22 23 map = affinity_map_get(affmap_name); 24 pos = map->bit_position; 25 >>> CID 1560313: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 26 for (ALL_LIST_ELEMENTS_RO(isis->area_list, area_node, area)) { 27 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, fa_node, 28 fa)) { 29 if (admin_group_get(&fa->admin_group_exclude_any, 30 pos) || 31 admin_group_get(&fa->admin_group_include_any, ** CID 1560312: Memory - corruptions (OVERRUN) /isisd/isis_flex_algo.c: 292 in isis_flex_algo_constraint_drop() ________________________________________________________________________________________________________ *** CID 1560312: Memory - corruptions (OVERRUN) /isisd/isis_flex_algo.c: 292 in isis_flex_algo_constraint_drop() 286 if (link_admin_group && link_ext_admin_group) { 287 link_ext_admin_group_bitmap0 = 288 admin_group_get_offset(link_ext_admin_group, 0); 289 if (*link_admin_group != link_ext_admin_group_bitmap0) { 290 memcpy(lspid_orig, lsp->hdr.lsp_id, 291 ISIS_SYS_ID_LEN + 2); >>> CID 1560312: Memory - corruptions (OVERRUN) >>> Overrunning array "reach->id" of 7 bytes by passing it to a function which accesses it at byte offset 7 using argument "8UL". 292 memcpy(lspid_neigh, reach->id, ISIS_SYS_ID_LEN + 2); 293 zlog_warn( 294 "ISIS-SPF: LSP from %pLS neighbor %pLS. Admin-group 0x%08x differs from ext admin-group 0x%08x.", 295 lspid_orig, lspid_neigh, *link_admin_group, 296 link_ext_admin_group_bitmap0); 297 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Apr '23

05 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1537086: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_gr.c: 654 in zebra_gr_process_client() ________________________________________________________________________________________________________ *** CID 1537086: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_gr.c: 654 in zebra_gr_process_client() 648 uint8_t instance) 649 { 650 struct zserv *client = zserv_find_client(proto, instance); 651 struct client_gr_info *info = NULL; 652 struct zebra_gr_afi_clean *gac; 653 >>> CID 1537086: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "client", which is known to be "NULL". 654 TAILQ_FOREACH (info, &client->gr_info_queue, gr_info) { 655 if (info->vrf_id == vrf_id) 656 break; 657 } 658 659 if (info == NULL) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0