- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 21 Apr '23

21 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1560675: Resource leaks (RESOURCE_LEAK) /lib/elf_py.c: 1322 in elffile_load() ________________________________________________________________________________________________________ *** CID 1560675: Resource leaks (RESOURCE_LEAK) /lib/elf_py.c: 1322 in elffile_load() 1316 PyErr_Format(ELFFormatError, "libelf error %d: %s", 1317 err, elf_errmsg(err)); 1318 out: 1319 if (w->elf) 1320 elf_end(w->elf); 1321 free(w->filename); >>> CID 1560675: Resource leaks (RESOURCE_LEAK) >>> Handle variable "fd" going out of scope leaks the handle. 1322 return NULL; 1323 } 1324 1325 static PyObject *elfpy_debug(PyObject *self, PyObject *args) 1326 { 1327 int arg; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

frr 8.4.x and 8.5 trigger assertion in bgpd/bgp_lcommunity.c:236
by Kurt Jaeger 20 Apr '23

20 Apr '23

Hi! This caused bgpd to terminate on several boxes this morning: 2023/04/18 08:43:47 BGP: bgpd/bgp_lcommunity.c:236: set_lcommunity_string(): assertion ((unsigned int)len < str_buf_sz) failed BGP: Received signal 6 at 1681800227 (si_addr 0x0); aborting... OS: FreeBSD 13.1p3. frr was 8.4.x and 8.5. So someone is sending strange things... ? 7.5.1 is not affected... Any ideas on how to avoid the assert ? -- pi(a)opsec.eu +49 171 3101372 Now what ?

3 10

Welcome to join SONiC Routing WG
by Eddie Ruan 20 Apr '23

20 Apr '23

Hi, FRR gurus Hi, Praveen, Hasan, Rita and I have set up a SONiC Routing WG. The proposal for setting up this WG could be found at https://lists.sonicfoundation.dev/g/sonic-wg-routing/files/Routing%20workin… <https://lists.sonicfoundation.dev/g/sonic-wg-routing/files/Routing%20workin… > The goal for this WG is to improve white box support as a router. As we discussed in one of the previous FRR weekly meeting, we hit some challenges when starting bringing SONiC to routing platforms. One area we would like to work with FRR folks would be how we could improve the communication channel among FRR, SONiC and Linux Kernel. We welcome anyone from FRR community to join this working group, so we could work together to improve the above area. * Subscribe: sonic-wg-routing+subscribe(a)lists.sonicfoundation.dev <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > <mailto:sonic-wg-routing+subscribe@lists.sonicfoundation.dev > The WG page is at https://lists.sonicfoundation.dev/g/sonic-wg-routing <https://lists.sonicfoundation.dev/g/sonic-wg-routing > We plan to hold a kick off meeting on 5/4 5:30pm PST. By: Eddie Ruan <https://lists.sonicfoundation.dev/g/sonic-wg-routing/profile/@eddieruan > When: Thursday, May 4th, 2023 5:30pm to 6:30pm (UTC-07:00) Pacific Time - Los Angeles Location: San Jose <http://maps.google.com/?q=San%20Jose > Organizer: eddie.ruan(a)alibaba-inc.com <mailto:eddie.ruan@alibaba-inc.com?subject=Re:%20Event:%20SONiC%2520Routing%2520work%2520group%2520kick%2520off%2520meeting > Description: SONiC Routing work group kick off meeting Agenda: 1. Eddie, Praveen, Hasan, Rita's Introduction 2. Round table introduction 3. Tentative weekly meeting time, every Th 5:30-6:30 pm PST, 8:30 - 9:30 am China Time 4. Group scope Thanks Praveen, Hasan, Rita, Eddie

1 0

Feeding raw BGP path data to custom backend
by rsa 19 Apr '23

19 Apr '23

Hi, I am new to FRR. Pardon me if this is not the right forum to ask this question. We are interested in using the BGP component of the FRR package. I have a few questions on how we can customize it for our special use case. What we would like to do is 1. turn off Zebra interface as we are not interested in the route computation or sending those routes to Kernel. 2. send BGP post-policy path data to the backend "Watcher" that knows how to handle special cases based on custom community information. Further, is there support for EVPN (type 5) in FRR implementation? Has anyone attempted to feed raw path data (post policy) to a backend Watcher? Appreciate any input. Thank you in advance. Ravi

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 Apr '23

18 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1560315: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 49 in isis_affinity_map_update() ________________________________________________________________________________________________________ *** CID 1560315: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 49 in isis_affinity_map_update() 43 struct isis *isis = isis_lookup_by_vrfid(VRF_DEFAULT); 44 struct listnode *area_node, *fa_node; 45 struct isis_area *area; 46 struct flex_algo *fa; 47 bool changed; 48 >>> CID 1560315: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 49 for (ALL_LIST_ELEMENTS_RO(isis->area_list, area_node, area)) { 50 changed = false; 51 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, fa_node, 52 fa)) { 53 if (admin_group_get(&fa->admin_group_exclude_any, 54 old_pos)) { ** CID 1560314: Incorrect expression (NO_EFFECT) /isisd/isisd.c: 3147 in area_resign_level() ________________________________________________________________________________________________________ *** CID 1560314: Incorrect expression (NO_EFFECT) /isisd/isisd.c: 3147 in area_resign_level() 3141 3142 #ifndef FABRICD 3143 for (int tree = SPFTREE_IPV4; tree < SPFTREE_COUNT; tree++) { 3144 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, node, 3145 fa)) { 3146 data = fa->data; >>> CID 1560314: Incorrect expression (NO_EFFECT) >>> Comparing an array to null is not useful: "data->spftree[level - 1]", since the test will always evaluate as true. 3147 if (data->spftree[level - 1]) { 3148 isis_spftree_del( 3149 data->spftree[tree][level - 1]); 3150 data->spftree[tree][level - 1] = NULL; 3151 } 3152 } ** CID 1560313: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 26 in isis_affinity_map_check_use() ________________________________________________________________________________________________________ *** CID 1560313: Null pointer dereferences (NULL_RETURNS) /isisd/isis_affinitymap.c: 26 in isis_affinity_map_check_use() 20 struct affinity_map *map; 21 uint16_t pos; 22 23 map = affinity_map_get(affmap_name); 24 pos = map->bit_position; 25 >>> CID 1560313: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "isis", which is known to be "NULL". 26 for (ALL_LIST_ELEMENTS_RO(isis->area_list, area_node, area)) { 27 for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, fa_node, 28 fa)) { 29 if (admin_group_get(&fa->admin_group_exclude_any, 30 pos) || 31 admin_group_get(&fa->admin_group_include_any, ** CID 1560312: Memory - corruptions (OVERRUN) /isisd/isis_flex_algo.c: 292 in isis_flex_algo_constraint_drop() ________________________________________________________________________________________________________ *** CID 1560312: Memory - corruptions (OVERRUN) /isisd/isis_flex_algo.c: 292 in isis_flex_algo_constraint_drop() 286 if (link_admin_group && link_ext_admin_group) { 287 link_ext_admin_group_bitmap0 = 288 admin_group_get_offset(link_ext_admin_group, 0); 289 if (*link_admin_group != link_ext_admin_group_bitmap0) { 290 memcpy(lspid_orig, lsp->hdr.lsp_id, 291 ISIS_SYS_ID_LEN + 2); >>> CID 1560312: Memory - corruptions (OVERRUN) >>> Overrunning array "reach->id" of 7 bytes by passing it to a function which accesses it at byte offset 7 using argument "8UL". 292 memcpy(lspid_neigh, reach->id, ISIS_SYS_ID_LEN + 2); 293 zlog_warn( 294 "ISIS-SPF: LSP from %pLS neighbor %pLS. Admin-group 0x%08x differs from ext admin-group 0x%08x.", 295 lspid_orig, lspid_neigh, *link_admin_group, 296 link_ext_admin_group_bitmap0); 297 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Apr '23

05 Apr '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1537086: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_gr.c: 654 in zebra_gr_process_client() ________________________________________________________________________________________________________ *** CID 1537086: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_gr.c: 654 in zebra_gr_process_client() 648 uint8_t instance) 649 { 650 struct zserv *client = zserv_find_client(proto, instance); 651 struct client_gr_info *info = NULL; 652 struct zebra_gr_afi_clean *gac; 653 >>> CID 1537086: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "client", which is known to be "NULL". 654 TAILQ_FOREACH (info, &client->gr_info_queue, gr_info) { 655 if (info->vrf_id == vrf_id) 656 break; 657 } 658 659 if (info == NULL) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

FRRouting to leverage AI/ML networking synergies
by David 'equinox' Lamparter 01 Apr '23

01 Apr '23

Hi all, as you are likely well aware, recent developments in Artificial Intelligence and Machine Learning have been consistently performing one quantum leap after another. To leverage the new possibilities and avenues enabled by these developments, and not get left behind, we must join up and integrate these new technologies as soon as possible. I would therefore like to present our plans for the immediate future: - all SPF calculation and BGP best-path decision logic is to be replaced by a GNN (Graph Neural Network). In preparation of this, significant effort has been made to train such a network to produce results exceeding those provided by the previous hard-coded logic. - all configuration interfacing is to be performed by Microsoft's Sydney LLM (Large Language Model) chatbot. Not only is this the obvious choice of vendor considering our SONiC integration, but we also believe Sydney to be superior in its capability to handle typical network engineers' outbursts of swearing and curses. In fact, we are confident that future networks may be configured by simply swearing at the hardware until it works. - monitoring and other OAM functions will be handled by clippy, as provided in the original version of Office 97. The rationale for this is to ease the production of the appropriate curses necessary to affect the configuration changes needed to fix the outage at hand. We understand some of you may be concerned about the reliability and availability of these new AIs. As an open source project, we will obviously not try to confine you to the use of our provided AIs. In fact, we will try our best to enable you to train up your own AI according to the needs of your particular network! (Cloud compute credits not included.) I am happy to invite you all to join our path to this bright future, -equi P.S.: Please note that, despite the obvious connection, YANG schemas and configuration data exceed the limits of swearing we were able to train Sydney for. I am unsure we will be able to achieve this particular feat, but it's not quite time to give up just yet.

3 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Mar '23

24 Mar '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1536876: Null pointer dereferences (NULL_RETURNS) /pimd/pim_zebra.c: 80 in pim_zebra_interface_vrf_update() ________________________________________________________________________________________________________ *** CID 1536876: Null pointer dereferences (NULL_RETURNS) /pimd/pim_zebra.c: 80 in pim_zebra_interface_vrf_update() 74 pim_ifp = ifp->info; 75 if (!pim_ifp) 76 return 0; 77 78 pim_ifp->pim->mcast_if_count--; 79 pim_ifp->pim = pim; >>> CID 1536876: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "pim_ifp->pim", which is known to be "NULL". 80 pim_ifp->pim->mcast_if_count++; 81 82 return 0; 83 } 84 85 #ifdef PIM_DEBUG_IFADDR_DUMP ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Re: [dev] SONIC FRR version @ https://github.com/sonic-net/sonic-frr (v7.0 & 8.2.2)
by Jafar Al-Gharaibeh 24 Mar '23

24 Mar '23

You should bring this up with the SONIC folks, we (FRR maintainers) have no control over their code/tags. --Jafar On 3/10/23 00:09, raja.2001--- via dev wrote: > _______________________________________________ > dev mailing list > dev(a)lists.frrouting.org > https://lists.frrouting.org/listinfo/dev

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Mar '23

23 Mar '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 6 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1536832: Memory - corruptions (OVERLAPPING_COPY) /mgmtd/mgmt_history.c: 85 in mgmt_history_create_cmt_rec() ________________________________________________________________________________________________________ *** CID 1536832: Memory - corruptions (OVERLAPPING_COPY) /mgmtd/mgmt_history.c: 85 in mgmt_history_create_cmt_rec() 79 80 new = XCALLOC(MTYPE_MGMTD_CMT_INFO, sizeof(struct mgmt_cmt_info_t)); 81 gettimeofday(&cmt_recd_tv, NULL); 82 mgmt_realtime_to_string(&cmt_recd_tv, new->time_str, 83 sizeof(new->time_str)); 84 mgmt_history_hash(new->time_str, new->cmtid_str); >>> CID 1536832: Memory - corruptions (OVERLAPPING_COPY) >>> In the call to function "snprintf", the object pointed to by argument "new->cmtid_str" may overlap with the object pointed to by argument "new->cmt_json_file". 85 snprintf(new->cmt_json_file, sizeof(new->cmt_json_file), 86 MGMTD_COMMIT_FILE_PATH, new->cmtid_str); 87 88 if (mgmt_cmt_infos_count(&mm->cmts) == MGMTD_MAX_COMMIT_LIST) { 89 FOREACH_CMT_REC (mm, cmt_info) 90 last_cmt_info = cmt_info; ** CID 1536831: Error handling issues (NEGATIVE_RETURNS) /mgmtd/mgmt_be_server.c: 123 in mgmt_be_server_start() ________________________________________________________________________________________________________ *** CID 1536831: Error handling issues (NEGATIVE_RETURNS) /mgmtd/mgmt_be_server.c: 123 in mgmt_be_server_start() 117 118 MGMTD_BE_SRVR_DBG("Started MGMTD Backend Server!"); 119 return; 120 121 mgmt_be_server_start_failed: 122 if (sock) >>> CID 1536831: Error handling issues (NEGATIVE_RETURNS) >>> "sock" is passed to a parameter that cannot be negative. 123 close(sock); 124 125 mgmt_be_listen_fd = -1; 126 exit(-1); 127 } 128 ** CID 1536830: Resource leaks (RESOURCE_LEAK) /mgmtd/mgmt_history.c: 146 in mgmt_history_read_cmt_record_index() ________________________________________________________________________________________________________ *** CID 1536830: Resource leaks (RESOURCE_LEAK) /mgmtd/mgmt_history.c: 146 in mgmt_history_read_cmt_record_index() 140 sizeof(struct mgmt_cmt_info_t)); 141 memcpy(new, &cmt_info, sizeof(struct mgmt_cmt_info_t)); 142 mgmt_cmt_infos_add_tail(&mm->cmts, new); 143 } else { 144 zlog_err("More records found in index file %s", 145 MGMTD_COMMIT_INDEX_FILE_NAME); >>> CID 1536830: Resource leaks (RESOURCE_LEAK) >>> Variable "fp" going out of scope leaks the storage it points to. 146 return false; 147 } 148 149 cnt++; 150 } 151 ** CID 1536829: Error handling issues (NEGATIVE_RETURNS) /mgmtd/mgmt_fe_server.c: 123 in mgmt_fe_server_start() ________________________________________________________________________________________________________ *** CID 1536829: Error handling issues (NEGATIVE_RETURNS) /mgmtd/mgmt_fe_server.c: 123 in mgmt_fe_server_start() 117 118 MGMTD_FE_SRVR_DBG("Started MGMTD Frontend Server!"); 119 return; 120 121 mgmt_fe_server_start_failed: 122 if (sock) >>> CID 1536829: Error handling issues (NEGATIVE_RETURNS) >>> "sock" is passed to a parameter that cannot be negative. 123 close(sock); 124 125 mgmt_fe_listen_fd = -1; 126 exit(-1); 127 } 128 ** CID 1536828: Possible Control flow issues (DEADCODE) /mgmtd/mgmt_txn.c: 1859 in mgmt_txn_get_config() ________________________________________________________________________________________________________ *** CID 1536828: Possible Control flow issues (DEADCODE) /mgmtd/mgmt_txn.c: 1859 in mgmt_txn_get_config() 1853 mgmt_txn_get_config_failed: 1854 1855 if (pending_list) { 1856 /* 1857 * Move the transaction to corresponding pending list. 1858 */ >>> CID 1536828: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "if (req_list) mgmt_txn_re...". 1859 if (req_list) 1860 mgmt_txn_reqs_del(req_list, txn_req); 1861 txn_req->pending_be_proc = true; 1862 mgmt_txn_reqs_add_tail(pending_list, txn_req); 1863 MGMTD_TXN_DBG( 1864 "Moved Req: %p for Txn: %p from Req-List to Pending-List", ** CID 1536827: Null pointer dereferences (NULL_RETURNS) /mgmtd/mgmt_ds.c: 526 in mgmt_ds_delete_data_nodes() ________________________________________________________________________________________________________ *** CID 1536827: Null pointer dereferences (NULL_RETURNS) /mgmtd/mgmt_ds.c: 526 in mgmt_ds_delete_data_nodes() 520 /* 521 * Return a special error code so the caller can choose 522 * whether to ignore it or not. 523 */ 524 return NB_ERR_NOT_FOUND; 525 /* destroy dependant */ >>> CID 1536827: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing "nb_node", which is known to be "NULL". 526 if (nb_node->dep_cbs.get_dependant_xpath) { 527 nb_node->dep_cbs.get_dependant_xpath(dnode, dep_xpath); 528 529 dep_dnode = yang_dnode_get( 530 ds_ctx->config_ds ? ds_ctx->root.cfg_root->dnode 531 : ds_ctx->root.dnode_root, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0