- dev - lists.frrouting.org

Implementation for FRR C based APIs
by Bhanu Priya Bhardwaj 27 Feb '23

27 Feb '23

Hi, The intent of this mail is to use FRR APIs programmatically. We have C as the existing code base. Please suggest how we can integrate FRR APIs into our code. Regards Bhanupriya Bhardwaj DISCLAIMER: This electronic message and all of its contents, contains information which is privileged, confidential or otherwise protected from disclosure. The information contained in this electronic mail transmission is intended for use only by the individual or entity to which it is addressed. If you are not the intended recipient or may have received this electronic mail transmission in error, please notify the sender immediately and delete / destroy all copies of this electronic mail transmission without disclosing, copying, distributing, forwarding, printing or retaining any part of it. Hughes Systique accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Feb '23

22 Feb '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1534617: Uninitialized variables (UNINIT) /bgpd/bgp_rpki.c: 1417 in show_rpki_prefix_magic() ________________________________________________________________________________________________________ *** CID 1534617: Uninitialized variables (UNINIT) /bgpd/bgp_rpki.c: 1417 in show_rpki_prefix_magic() 1411 } 1412 1413 struct pfx_record *matches = NULL; 1414 unsigned int match_count = 0; 1415 enum pfxv_state result; 1416 >>> CID 1534617: Uninitialized variables (UNINIT) >>> Using uninitialized value "as" when calling "pfx_table_validate_r". 1417 if (pfx_table_validate_r(rtr_config->pfx_table, &matches, &match_count, 1418 as, &addr, prefix->prefixlen, 1419 &result) != PFX_SUCCESS) { 1420 if (!json) 1421 vty_out(vty, "Prefix lookup failed\n"); 1422 return CMD_WARNING; ** CID 1534616: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_route.c: 6985 in bgp_static_set_safi() ________________________________________________________________________________________________________ *** CID 1534616: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_route.c: 6985 in bgp_static_set_safi() 6979 bgp_static->valid = 0; 6980 bgp_static->igpmetric = 0; 6981 bgp_static->igpnexthop.s_addr = INADDR_ANY; 6982 bgp_static->label = label; 6983 bgp_static->prd = prd; 6984 >>> CID 1534616: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "rd_str" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 6985 if (rd_str) 6986 bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str); 6987 if (rmap_str) { 6988 XFREE(MTYPE_ROUTE_MAP_NAME, bgp_static->rmap.name); 6989 route_map_counter_decrement(bgp_static->rmap.map); 6990 bgp_static->rmap.name = ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 Feb '23

18 Feb '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1534606: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bgpd/bgpd.c: 2766 in peer_group2peer_config_copy() ________________________________________________________________________________________________________ *** CID 1534606: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /bgpd/bgpd.c: 2766 in peer_group2peer_config_copy() 2760 /* capability extended-nexthop apply */ 2761 if (!CHECK_FLAG(peer->flags_override, PEER_FLAG_CAPABILITY_ENHE)) 2762 if (CHECK_FLAG(conf->flags, PEER_FLAG_CAPABILITY_ENHE)) 2763 SET_FLAG(peer->flags, PEER_FLAG_CAPABILITY_ENHE); 2764 2765 /* capability software-version apply */ >>> CID 1534606: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "peer->flags_override & (68719476736ULL /* 1ULL << 36 */)" is always 0 regardless of the values of its operands. This occurs as the logical operand of "!". 2766 if (!CHECK_FLAG(peer->flags_override, 2767 PEER_FLAG_CAPABILITY_SOFT_VERSION)) 2768 if (CHECK_FLAG(conf->flags, PEER_FLAG_CAPABILITY_SOFT_VERSION)) 2769 SET_FLAG(peer->flags, 2770 PEER_FLAG_CAPABILITY_SOFT_VERSION); 2771 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 15 Feb '23

15 Feb '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1534507: (NULL_RETURNS) /zebra/zebra_l2_bridge_if.c: 214 in zebra_l2_bridge_if_vlan_update() /zebra/zebra_l2_bridge_if.c: 216 in zebra_l2_bridge_if_vlan_update() ________________________________________________________________________________________________________ *** CID 1534507: (NULL_RETURNS) /zebra/zebra_l2_bridge_if.c: 214 in zebra_l2_bridge_if_vlan_update() 208 struct zebra_l2_bridge_vlan *bvlan; 209 210 zif = (struct zebra_if *)ifp->info; 211 bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid); 212 213 if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE) >>> CID 1534507: (NULL_RETURNS) >>> Dereferencing "bvlan", which is known to be "NULL". 214 bvlan->access_bd = bvl->access_bd; 215 216 if (!bvlan->access_bd) 217 return zebra_l2_bridge_if_vlan_del(ifp, bvl->vid); 218 219 return 0; /zebra/zebra_l2_bridge_if.c: 216 in zebra_l2_bridge_if_vlan_update() 210 zif = (struct zebra_if *)ifp->info; 211 bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid); 212 213 if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE) 214 bvlan->access_bd = bvl->access_bd; 215 >>> CID 1534507: (NULL_RETURNS) >>> Dereferencing "bvlan", which is known to be "NULL". 216 if (!bvlan->access_bd) 217 return zebra_l2_bridge_if_vlan_del(ifp, bvl->vid); 218 219 return 0; 220 } 221 ** CID 1534506: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /zebra/rt_netlink.c: 1370 in _netlink_nexthop_encode_dvni_label() ________________________________________________________________________________________________________ *** CID 1534506: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /zebra/rt_netlink.c: 1370 in _netlink_nexthop_encode_dvni_label() 1364 mpls_lse_t *out_lse, 1365 size_t buflen, char *label_buf) 1366 { 1367 struct in_addr ipv4; 1368 1369 if (!nl_attr_put64(nlmsg, buflen, LWTUNNEL_IP_ID, >>> CID 1534506: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "(_uint64_t)out_lse[0] >> 32" is 0 regardless of the values of its operands. This occurs as an argument to a function call. 1370 htonll((uint64_t)out_lse[0]))) 1371 return false; 1372 1373 if (nexthop->type == NEXTHOP_TYPE_IPV4_IFINDEX) { 1374 if (!nl_attr_put(nlmsg, buflen, LWTUNNEL_IP_DST, 1375 &nexthop->gate.ipv4, 4)) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 08 Feb '23

08 Feb '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1534374: Control flow issues (MISSING_BREAK) /bgpd/bgp_mplsvpn_snmp.c: 1613 in mplsL3vpnRteTable() ________________________________________________________________________________________________________ *** CID 1534374: Control flow issues (MISSING_BREAK) /bgpd/bgp_mplsvpn_snmp.c: 1613 in mplsL3vpnRteTable() 1607 1608 case MPLSL3VPNVRFRTEINETCIDRIFINDEX: 1609 if (pi->nexthop && pi->nexthop->nexthop) 1610 return SNMP_INTEGER(pi->nexthop->nexthop->ifindex); 1611 else 1612 return SNMP_INTEGER(0); >>> CID 1534374: Control flow issues (MISSING_BREAK) >>> The case for value "8" is not terminated by a "break" statement. 1613 case MPLSL3VPNVRFRTEINETCIDRTYPE: 1614 if (pi->nexthop && pi->nexthop->nexthop) { 1615 switch (pi->nexthop->nexthop->type) { 1616 case NEXTHOP_TYPE_IFINDEX: 1617 return SNMP_INTEGER( 1618 MPLSL3VPNVRFRTECIDRTYPELOCAL); ** CID 1534373: Control flow issues (DEADCODE) /pimd/pim_zpthread.c: 57 in pim_mlag_zebra_fill_header() ________________________________________________________________________________________________________ *** CID 1534373: Control flow issues (DEADCODE) /pimd/pim_zpthread.c: 57 in pim_mlag_zebra_fill_header() 51 fill_msg_type = MLAG_MROUTE_ADD_BULK; 52 break; 53 case MLAG_MROUTE_DEL: 54 data_len = sizeof(struct mlag_mroute_del); 55 fill_msg_type = MLAG_MROUTE_DEL_BULK; 56 break; >>> CID 1534373: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "case MLAG_MSG_NONE:". 57 case MLAG_MSG_NONE: 58 case MLAG_STATUS_UPDATE: 59 case MLAG_DUMP: 60 case MLAG_MROUTE_ADD_BULK: 61 case MLAG_MROUTE_DEL_BULK: 62 case MLAG_PIM_CFG_DUMP: ** CID 1534372: Control flow issues (DEADCODE) /zebra/zebra_nhg.c: 2296 in nexthop_active() ________________________________________________________________________________________________________ *** CID 1534372: Control flow issues (DEADCODE) /zebra/zebra_nhg.c: 2296 in nexthop_active() 2290 break; 2291 case AFI_IP6: 2292 p.family = AF_INET6; 2293 p.prefixlen = IPV6_MAX_BITLEN; 2294 p.u.prefix6 = nexthop->gate.ipv6; 2295 break; >>> CID 1534372: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "case AFI_UNSPEC:". 2296 case AFI_UNSPEC: 2297 case AFI_L2VPN: 2298 case AFI_MAX: 2299 assert(afi != AFI_IP && afi != AFI_IP6); 2300 break; 2301 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Canceled: Weekly FRR YANG Meeting
by Pushpasis Sarkar 30 Jan '23

30 Jan '23

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 25 Jan '23

25 Jan '23

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 4 of 4 defect(s) ** CID 1532182: (ATOMICITY) /zebra/zebra_dplane.c: 5555 in dplane_show_provs_helper() /zebra/zebra_dplane.c: 5555 in dplane_show_provs_helper() ________________________________________________________________________________________________________ *** CID 1532182: (ATOMICITY) /zebra/zebra_dplane.c: 5555 in dplane_show_provs_helper() 5549 5550 vty_out(vty, "%s (%u): in: %"PRIu64", q: %"PRIu64", q_max: %"PRIu64", out: %"PRIu64", q: %"PRIu64", q_max: %"PRIu64"\n", 5551 prov->dp_name, prov->dp_id, in, in_q, in_max, 5552 out, out_q, out_max); 5553 5554 DPLANE_LOCK(); >>> CID 1532182: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 5555 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 5556 DPLANE_UNLOCK(); 5557 } 5558 5559 return CMD_SUCCESS; 5560 } /zebra/zebra_dplane.c: 5555 in dplane_show_provs_helper() 5549 5550 vty_out(vty, "%s (%u): in: %"PRIu64", q: %"PRIu64", q_max: %"PRIu64", out: %"PRIu64", q: %"PRIu64", q_max: %"PRIu64"\n", 5551 prov->dp_name, prov->dp_id, in, in_q, in_max, 5552 out, out_q, out_max); 5553 5554 DPLANE_LOCK(); >>> CID 1532182: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 5555 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 5556 DPLANE_UNLOCK(); 5557 } 5558 5559 return CMD_SUCCESS; 5560 } ** CID 1532181: (ATOMICITY) /zebra/zebra_dplane.c: 6596 in dplane_work_pending() /zebra/zebra_dplane.c: 6596 in dplane_work_pending() ________________________________________________________________________________________________________ *** CID 1532181: (ATOMICITY) /zebra/zebra_dplane.c: 6596 in dplane_work_pending() 6590 dplane_provider_unlock(prov); 6591 6592 if (ctx != NULL) 6593 break; 6594 6595 DPLANE_LOCK(); >>> CID 1532181: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6596 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6597 DPLANE_UNLOCK(); 6598 } 6599 6600 if (ctx != NULL) 6601 ret = true; /zebra/zebra_dplane.c: 6596 in dplane_work_pending() 6590 dplane_provider_unlock(prov); 6591 6592 if (ctx != NULL) 6593 break; 6594 6595 DPLANE_LOCK(); >>> CID 1532181: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6596 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6597 DPLANE_UNLOCK(); 6598 } 6599 6600 if (ctx != NULL) 6601 ret = true; ** CID 1532180: (ATOMICITY) /zebra/zebra_dplane.c: 6972 in zebra_dplane_start() /zebra/zebra_dplane.c: 6972 in zebra_dplane_start() ________________________________________________________________________________________________________ *** CID 1532180: (ATOMICITY) /zebra/zebra_dplane.c: 6972 in zebra_dplane_start() 6966 6967 if (prov->dp_start) 6968 (prov->dp_start)(prov); 6969 6970 /* Locate next provider */ 6971 DPLANE_LOCK(); >>> CID 1532180: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6972 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6973 DPLANE_UNLOCK(); 6974 } 6975 6976 frr_pthread_run(zdplane_info.dg_pthread, NULL); 6977 } /zebra/zebra_dplane.c: 6972 in zebra_dplane_start() 6966 6967 if (prov->dp_start) 6968 (prov->dp_start)(prov); 6969 6970 /* Locate next provider */ 6971 DPLANE_LOCK(); >>> CID 1532180: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6972 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6973 DPLANE_UNLOCK(); 6974 } 6975 6976 frr_pthread_run(zdplane_info.dg_pthread, NULL); 6977 } ** CID 1532179: (ATOMICITY) /zebra/zebra_dplane.c: 6826 in dplane_thread_loop() /zebra/zebra_dplane.c: 6826 in dplane_thread_loop() ________________________________________________________________________________________________________ *** CID 1532179: (ATOMICITY) /zebra/zebra_dplane.c: 6826 in dplane_thread_loop() 6820 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 6821 zlog_debug("dplane dequeues %d completed work from provider %s", 6822 counter, dplane_provider_get_name(prov)); 6823 6824 /* Locate next provider */ 6825 DPLANE_LOCK(); >>> CID 1532179: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6826 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6827 DPLANE_UNLOCK(); 6828 } 6829 6830 /* 6831 * We hit the work limit while processing at least one provider's /zebra/zebra_dplane.c: 6826 in dplane_thread_loop() 6820 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 6821 zlog_debug("dplane dequeues %d completed work from provider %s", 6822 counter, dplane_provider_get_name(prov)); 6823 6824 /* Locate next provider */ 6825 DPLANE_LOCK(); >>> CID 1532179: (ATOMICITY) >>> Using an unreliable value of "prov" inside the second locked section. If the data that "prov" depends on was changed by another thread, this use might be incorrect. 6826 prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov); 6827 DPLANE_UNLOCK(); 6828 } 6829 6830 /* 6831 * We hit the work limit while processing at least one provider's ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

FRR 8.4.2 Bug Fix Release
by Jafar Al-Gharaibeh 14 Jan '23

14 Jan '23

Dear FRR Community, We are pleased to announce another bug fix release: FRR 8.4.2. Important Note: we have migrated away from Dockerhub to quay.io to host FRR docker images. Moving forward, all docker images will be found at: https://quay.io/repository/frrouting/frr Thank you all for your feedback. Packages are available at: Debian Packages - https://deb.frrouting.org RPM Packages - https://rpm.frrouting.org Snaps - https://snapcraft.io/frr Docker - https://quay.io/repository/frrouting/frr/manifest/sha256:54f9a7b9e5436430de… For release notes and a list of notable bug fixes, please visit: https://frrouting.org/release/8.4.2/ https://github.com/FRRouting/frr/releases/tag/frr-8.4.2 Cheers, The FRR Development Team!

1 0

frr using netconf datastores?
by Thomas.Swendseid＠gd-ms.com 06 Jan '23

06 Jan '23

Dear FRR Dev team, I had a question on whether the FRR in its current implementation works with Netconf and Yang? I do believe it does but I haven't been able to fully piece this together from the available documentation and other sources. I have downloaded the FRR (v 8.4.1), compiled it, and started it such that the ospfd is up and running. I've started netopeer2-server and netopeer2-cli and I can connect and see the datastores (running, candidate, startup) available. But my question is whether ospfd is consuming the 'startup' or 'running' datastore? The FRR was compiled with sysrepo enabled as well as specifying "-M sysrepo" on the ospfd command line. I'm not seeing any output from the daemon that would make me think it's using the datastore. Do I have to implement any callbacks or do any development work to have the ospfd use the datastore? Thanks for your help. Tom Swendseid [cid:image001.jpg@01D90EFC.D9804570] (480) 441.8173 thomas.swendseid(a)gd-ms.com<mailto:thomas.swendseid@gd-ms.com> This message and/or attachments may include information subject to GD Corporate Policies 07-103 and 07-105 and is intended to be accessed only by authorized recipients. Use, storage and transmission are governed by General Dynamics and its policies. Contractual restrictions apply to third parties. Recipients should refer to the policies or contract to determine proper handling. Unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender and destroy all copies of the original message.

1 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Dec '22

20 Dec '22

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1530035: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1530035: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_updgrp_packet.c: 756 in subgroup_update_packet() 750 * position. 751 */ 752 mpattr_pos = stream_get_endp(s); 753 754 /* 5: Encode all the attributes, except MP_REACH_NLRI 755 * attr. */ >>> CID 1530035: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "path" to "bgp_packet_attribute", which dereferences it. 756 total_attr_len = bgp_packet_attribute( 757 NULL, peer, s, adv->baa->attr, &vecarr, NULL, 758 afi, safi, from, NULL, NULL, 0, 0, 0, path); 759 760 space_remaining = 761 STREAM_CONCAT_REMAIN(s, snlri, STREAM_SIZE(s)) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0