- dev - lists.frrouting.org

FRR moving to Microsoft Team Foundation Server
by Quentin Young 01 Apr '19

01 Apr '19

Hi folks, With Microsoft’s recent acquisition of GitHub, concerns have been raised over the trend towards increased centralization of open source development infrastructure. As an open source project developed by many diverse contributors, we see a need to move our codebase and version control hosting to a more decentralized platform. The maintainer team has looked at multiple options, such as BitBucket, Gogs, Gitlab, and a Slack channel for sharing timestamped zip archives. After long deliberations and careful evaluations, we have decided to go with Team Foundation Server to replace GitHub, and will additionally be moving to TFS from Git. Additionally all of our remotes will be hosted on Windows Server boxes via Azure starting 04/02/19, after which time developers will need to have a functional Windows box to continue to contribute to FRR. Patches must be submitted to TFS in .docx format. Please note that the usual style rules and code signing requirements will still apply. While we recognize there may be some short term growing pains, we feel confident this will be a big step forward for open networking. --- Sent from my Surface Pro

3 2

FRR Users and Coders get together, Wednesday at 14:00...
by Alistair Woodman 27 Mar '19

27 Mar '19

Location still TBD We are planning a Meetup of FRR users and coders at 14:00 on Wednesday. Anyone interested in meeting other members of the FRR community please feel free to come along... I'll forward the location when we get confirmation. /a

3 2

Weekly Dev meeting @ IETF
by Lou Berger 25 Mar '19

25 Mar '19

We have the Budapest room assigned for use for Tuesday's meeting. Please come by if you're in Prague. See you at 4pm local time. Lou

1 0

To support Tunnel Encapsulation Attribute in BGP
by Davi Scofield 25 Mar '19

25 Mar '19

Hello: BGP has a SFAI named Tunnel Encapsulation, it is important in overlay scenario.More detail can be found in the RFC 5512 and RFC 5566. Is there any plan to develop this AFI/SAFI in BGP? Thanks！ Davi

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Mar '19

20 Mar '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1479148: Incorrect expression (COPY_PASTE_ERROR) /zebra/zebra_rib.c: 1935 in rib_process_result() ________________________________________________________________________________________________________ *** CID 1479148: Incorrect expression (COPY_PASTE_ERROR) /zebra/zebra_rib.c: 1935 in rib_process_result() 1929 if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) { 1930 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 1931 zlog_debug("%u:%s Stale dplane result for old_re %p", 1932 dplane_ctx_get_vrf(ctx), 1933 dest_str, old_re); 1934 } else >>> CID 1479148: Incorrect expression (COPY_PASTE_ERROR) >>> "re" in "re->status" looks like a copy-paste error. 1935 UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED); 1936 } 1937 1938 switch (op) { 1939 case DPLANE_OP_ROUTE_INSTALL: 1940 case DPLANE_OP_ROUTE_UPDATE: ** CID 1479146: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1935 in rib_process_result() ________________________________________________________________________________________________________ *** CID 1479146: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1935 in rib_process_result() 1929 if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) { 1930 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 1931 zlog_debug("%u:%s Stale dplane result for old_re %p", 1932 dplane_ctx_get_vrf(ctx), 1933 dest_str, old_re); 1934 } else >>> CID 1479146: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "re". 1935 UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED); 1936 } 1937 1938 switch (op) { 1939 case DPLANE_OP_ROUTE_INSTALL: 1940 case DPLANE_OP_ROUTE_UPDATE: ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Mar '19

20 Mar '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1479155: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1479155: Uninitialized variables (UNINIT) /pimd/pim_cmd.c: 6441 in pim_test_sg_keepalive_magic() 6435 6436 if (!pim) { 6437 vty_out(vty, "%% Unable to find pim instance\n"); 6438 return CMD_WARNING; 6439 } 6440 >>> CID 1479155: Uninitialized variables (UNINIT) >>> Using uninitialized value "sg". Field "sg.family" is uninitialized when calling "pim_upstream_find". 6441 up = pim_upstream_find(pim, &sg); 6442 if (!up) { 6443 vty_out(vty, "%% Unable to find %s specified\n", 6444 pim_str_sg_dump(&sg)); 6445 return CMD_WARNING; 6446 } ** CID 1479154: (DC.WEAK_CRYPTO) /bfdd/bfd.c: 228 in ptm_bfd_gen_ID() /bfdd/bfd.c: 229 in ptm_bfd_gen_ID() ________________________________________________________________________________________________________ *** CID 1479154: (DC.WEAK_CRYPTO) /bfdd/bfd.c: 228 in ptm_bfd_gen_ID() 222 223 /* 224 * RFC 5880, Section 6.8.1. recommends that we should generate 225 * random session identification numbers. 226 */ 227 do { >>> CID 1479154: (DC.WEAK_CRYPTO) >>> "random" should not be used for security related applications, as linear congruential algorithms are too easy to break. 228 session_id = ((random() << 16) & 0xFFFF0000) 229 | (random() & 0x0000FFFF); 230 } while (session_id == 0 || bfd_id_lookup(session_id) != NULL); 231 232 return session_id; 233 } /bfdd/bfd.c: 229 in ptm_bfd_gen_ID() 223 /* 224 * RFC 5880, Section 6.8.1. recommends that we should generate 225 * random session identification numbers. 226 */ 227 do { 228 session_id = ((random() << 16) & 0xFFFF0000) >>> CID 1479154: (DC.WEAK_CRYPTO) >>> "random" should not be used for security related applications, as linear congruential algorithms are too easy to break. 229 | (random() & 0x0000FFFF); 230 } while (session_id == 0 || bfd_id_lookup(session_id) != NULL); 231 232 return session_id; 233 } 234 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Mar '19

20 Mar '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 13 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 13 of 13 defect(s) ** CID 1479151: Null pointer dereferences (NULL_RETURNS) /pbrd/pbr_zebra.c: 111 in interface_address_add() ________________________________________________________________________________________________________ *** CID 1479151: Null pointer dereferences (NULL_RETURNS) /pbrd/pbr_zebra.c: 111 in interface_address_add() 105 { 106 struct connected *c; 107 char buf[PREFIX_STRLEN]; 108 109 c = zebra_interface_address_read(command, zclient->ibuf, vrf_id); 110 >>> CID 1479151: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "c". 111 DEBUGD(&pbr_dbg_zebra, 112 "%s: %s added %s", __PRETTY_FUNCTION__, c->ifp->name, 113 prefix2str(c->address, buf, sizeof(buf))); 114 115 return 0; 116 } ** CID 1479150: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479150: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_routemap.c: 2013 in route_set_lcommunity_delete_compile() 2007 str = XCALLOC(MTYPE_ROUTE_MAP_COMPILED, len + 1); 2008 memcpy(str, arg, len); 2009 } else 2010 str = NULL; 2011 2012 rcom->name = str; >>> CID 1479150: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rcom->name" to "bgp_clist_hash_key", which dereferences it. 2013 rcom->name_hash = bgp_clist_hash_key(rcom->name); 2014 return rcom; 2015 } 2016 2017 /* Free function for set lcommunity. */ 2018 static void route_set_lcommunity_delete_free(void *rule) ** CID 1479149: Control flow issues (DEADCODE) /zebra/zebra_rib.c: 486 in nexthop_active() ________________________________________________________________________________________________________ *** CID 1479149: Control flow issues (DEADCODE) /zebra/zebra_rib.c: 486 in nexthop_active() 480 __PRETTY_FUNCTION__, ifp->name); 481 return 0; 482 } 483 } 484 if (!if_is_operative(ifp)) { 485 if (IS_ZEBRA_DEBUG_RIB_DETAILED) >>> CID 1479149: Control flow issues (DEADCODE) >>> Execution cannot reach the expression ""Unknown"" inside this statement: "zlog_debug("\t%s: Interface...". 486 zlog_debug( 487 "\t%s: Interface %s is not unnumbered", 488 __PRETTY_FUNCTION__, 489 ifp ? ifp->name : "Unknown"); 490 return 0; 491 } ** CID 1479148: Incorrect expression (COPY_PASTE_ERROR) /zebra/zebra_rib.c: 1940 in rib_process_result() ________________________________________________________________________________________________________ *** CID 1479148: Incorrect expression (COPY_PASTE_ERROR) /zebra/zebra_rib.c: 1940 in rib_process_result() 1934 if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) { 1935 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 1936 zlog_debug("%u:%s Stale dplane result for old_re %p", 1937 dplane_ctx_get_vrf(ctx), 1938 dest_str, old_re); 1939 } else >>> CID 1479148: Incorrect expression (COPY_PASTE_ERROR) >>> "re" in "re->status" looks like a copy-paste error. 1940 UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED); 1941 } 1942 1943 switch (op) { 1944 case DPLANE_OP_ROUTE_INSTALL: 1945 case DPLANE_OP_ROUTE_UPDATE: ** CID 1479147: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479147: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vxlan.c: 9215 in zebra_vxlan_dad_mac_auto_recovery_exp() 9209 zebra_neigh_t *nbr = NULL; 9210 char buf[ETHER_ADDR_STRLEN]; 9211 9212 mac = THREAD_ARG(t); 9213 9214 /* since this is asynchronous we need sanity checks*/ >>> CID 1479147: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "zvni" to "zvni_mac_lookup", which dereferences it. 9215 mac = zvni_mac_lookup(zvni, &mac->macaddr); 9216 if (!mac) 9217 return 0; 9218 9219 zvni = zvni_lookup(mac->zvni->vni); 9220 if (!zvni) ** CID 1479146: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1940 in rib_process_result() ________________________________________________________________________________________________________ *** CID 1479146: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1940 in rib_process_result() 1934 if (old_re->dplane_sequence != dplane_ctx_get_old_seq(ctx)) { 1935 if (IS_ZEBRA_DEBUG_DPLANE_DETAIL) 1936 zlog_debug("%u:%s Stale dplane result for old_re %p", 1937 dplane_ctx_get_vrf(ctx), 1938 dest_str, old_re); 1939 } else >>> CID 1479146: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "re". 1940 UNSET_FLAG(re->status, ROUTE_ENTRY_QUEUED); 1941 } 1942 1943 switch (op) { 1944 case DPLANE_OP_ROUTE_INSTALL: 1945 case DPLANE_OP_ROUTE_UPDATE: ** CID 1479145: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1479145: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vxlan.c: 5527 in process_remote_macip_del() 5521 if (IS_ZEBRA_DEBUG_VXLAN) 5522 zlog_debug("%s: IP %s (flags 0x%x intf %s) is remote and duplicate, read kernel for local entry", 5523 __PRETTY_FUNCTION__, 5524 ipaddr2str(ipaddr, buf1, 5525 sizeof(buf1)), n->flags, 5526 vlan_if->name); >>> CID 1479145: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be null "vlan_if" when calling "neigh_read_specific_ip". 5527 neigh_read_specific_ip(ipaddr, vlan_if); 5528 } 5529 5530 /* When the MAC changes for an IP, it is possible the 5531 * client may update the new MAC before trying to delete the 5532 * "old" neighbor (as these are two different MACIP routes). ** CID 1479144: Control flow issues (DEADCODE) /bgpd/bgp_mplsvpn.c: 322 in vpn_leak_zebra_vrf_label_withdraw() ________________________________________________________________________________________________________ *** CID 1479144: Control flow issues (DEADCODE) /bgpd/bgp_mplsvpn.c: 322 in vpn_leak_zebra_vrf_label_withdraw() 316 if (debug) { 317 zlog_debug("%s: deleting label for vrf %s (id=%d)", __func__, 318 bgp->name_pretty, bgp->vrf_id); 319 } 320 321 if (label == BGP_PREVENT_VRF_2_VRF_LEAK) >>> CID 1479144: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "label = 4294967295U;". 322 label = MPLS_LABEL_NONE; 323 324 zclient_send_vrf_label(zclient, bgp->vrf_id, afi, label, ZEBRA_LSP_BGP); 325 bgp->vpn_policy[afi].tovpn_zebra_vrf_label_last_sent = label; 326 } 327 ** CID 1479143: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479143: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_routemap.c: 2108 in route_set_community_delete_compile() 2102 str = XCALLOC(MTYPE_ROUTE_MAP_COMPILED, len + 1); 2103 memcpy(str, arg, len); 2104 } else 2105 str = NULL; 2106 2107 rcom->name = str; >>> CID 1479143: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rcom->name" to "bgp_clist_hash_key", which dereferences it. 2108 rcom->name_hash = bgp_clist_hash_key(rcom->name); 2109 return rcom; 2110 } 2111 2112 /* Free function for set community. */ 2113 static void route_set_community_delete_free(void *rule) ** CID 1479142: Memory - illegal accesses (OVERRUN) /zebra/zebra_rib.c: 2241 in rib_meta_queue_add() ________________________________________________________________________________________________________ *** CID 1479142: Memory - illegal accesses (OVERRUN) /zebra/zebra_rib.c: 2241 in rib_meta_queue_add() 2235 "rn %p is already queued in sub-queue %u", 2236 (void *)rn, qindex); 2237 return; 2238 } 2239 2240 SET_FLAG(rib_dest_from_rnode(rn)->flags, RIB_ROUTE_QUEUED(qindex)); >>> CID 1479142: Memory - illegal accesses (OVERRUN) >>> Overrunning array "mq->subq" of 5 8-byte elements at element index 5 (byte offset 40) using index "qindex" (which evaluates to 5). 2241 listnode_add(mq->subq[qindex], rn); 2242 route_lock_node(rn); 2243 mq->size++; 2244 2245 if (IS_ZEBRA_DEBUG_RIB_DETAILED) 2246 rnode_debug(rn, re->vrf_id, "queued rn %p into sub-queue %u", ** CID 1479141: Control flow issues (DEADCODE) /bgpd/bgp_evpn_vty.c: 3224 in bgp_evpn_advertise_svi_ip_vni_magic() ________________________________________________________________________________________________________ *** CID 1479141: Control flow issues (DEADCODE) /bgpd/bgp_evpn_vty.c: 3224 in bgp_evpn_advertise_svi_ip_vni_magic() 3218 VTY_DECLVAR_CONTEXT_SUB(bgpevpn, vpn); 3219 3220 if (!bgp) 3221 return CMD_WARNING; 3222 3223 if (!vpn) >>> CID 1479141: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 1;". 3224 return CMD_WARNING; 3225 3226 if (no) 3227 evpn_set_advertise_svi_macip(bgp, vpn, 0); 3228 else 3229 evpn_set_advertise_svi_macip(bgp, vpn, 1); ** CID 1479140: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1479140: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vxlan.c: 9165 in zebra_vxlan_dad_ip_auto_recovery_exp() 9159 char buf1[INET6_ADDRSTRLEN]; 9160 char buf2[ETHER_ADDR_STRLEN]; 9161 9162 nbr = THREAD_ARG(t); 9163 9164 /* since this is asynchronous we need sanity checks*/ >>> CID 1479140: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "zvni" to "zvni_neigh_lookup", which dereferences it. 9165 nbr = zvni_neigh_lookup(zvni, &nbr->ip); 9166 if (!nbr) 9167 return 0; 9168 9169 zvni = zvni_lookup(nbr->zvni->vni); 9170 if (!zvni) ** CID 1479139: Control flow issues (UNREACHABLE) /ospfd/ospf_packet.c: 2110 in ospf_ls_upd() ________________________________________________________________________________________________________ *** CID 1479139: Control flow issues (UNREACHABLE) /ospfd/ospf_packet.c: 2110 in ospf_ls_upd() 2104 && !IS_LSA_MAXAGE(lsa))) { 2105 zlog_debug( 2106 "Link State Update[%s]: has Max Seq but not MaxAge. Dropping it", 2107 dump_lsa_key(lsa)); 2108 2109 DISCARD_LSA(lsa, 4); >>> CID 1479139: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "continue;". 2110 continue; 2111 } 2112 2113 /* Actual flooding procedure. */ 2114 if (ospf_flood(oi->ospf, nbr, current, lsa) 2115 < 0) /* Trap NSSA later. */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Slack Request?
by Holland, Jake 15 Mar '19

15 Mar '19

Hi FRR Dev list, Can I get a slack invite please? Thanks. I have some questions about the best current practices for building and running--I'm having some trouble on ubuntu server. Plus I have a patch I'll want to submit, and wanted to ask a few questions. Regards, Jake

1 0

7.0 release
by David Lamparter 13 Mar '19

13 Mar '19

Hi all, I'm very happy to announce we have released version 7.0 of FRRouting! [https://github.com/FRRouting/frr/releases] There are some major changes in this release, specifically libyang [https://github.com/CESNET/libyang] is now a hard requirement to build and run FRRouting. Here's the full list of major changes from 6.0.x to 7.0: - YANG data modeling & NETCONF support has arrived for the following daemons: - ripd - ripngd - isisd Note that this uses FRR-specific models and may still be subject to some changes. Feedback is strongly appreciated! - Error Codes / Categories are now added to log messages. They are printed as [EC 99999999999] on log messages and identify classes of errors. The library, bgpd, ospfd and zebra have been properly extended to categorize errors while the other daemons have somewhat more rudimentary cateogries. - "configure terminal" in the CLI is no longer an exclusive state on any daemon, i.e. multiple users can edit the configuration at the same time in all daemons. This was previously already the case for zebra and isisd. - BGP enhancements: - EVPN Duplicate Address Detection - EVPN route servers - EVPN extended mobility - Global IPv6 addresses can be used for RFC5549 (v4-over-v6) nexthops - Flowspec protocol support has been significantly extended. (Note that OS integration is still very incomplete.) - Add-Path IDs are now reused on transmission when possible - Aggregates now properly aggregate extended and large community attributes - IS-IS: - BFD support has been added - triggered hellos have been implemented - new daemon: OpenFabric (a datacenter variant of IS-IS - cf. https://datatracker.ietf.org/doc/draft-white-openfabric/) - Zebra's kernel/dataplane interface is undergoing a rewrite and parts have been moved into a separate thread with a more extensible architecture. Work on this project is ongoing. - staticd now supports onlink nexthops for static routes - sharpd now supports nexthop groups for route installs - many bugs were fixed, also including quite a few overdue documentation improvements. This also includes CVE-2017-3224 which is a low-severity low-impact OSPF vulnerability (as evident by the 2017 date.) Important packaging and build related changes: - libyang is now required to build and run FRRouting. Version 0.16.74 or newer (e.g. 0.16-r3 which is 0.16.105) is strongly recommended. Older versions will create additional hazards at both build and runtime because an extension module needs to be installed. Support for libyang versions before 0.16.74 will be removed in the next non-stable FRRouting version. - when using libyang before 0.16.74, make sure to specify the "--with-libyang-pluginsdir=/usr/lib/frr/libyang_plugins" option (change path to fit system) - Debian packaging has been completely overhauled (matches the changes in 6.0.2.) If you are creating derivative Debian packages, updates will be necessary. - RPKI and SNMP are now separate packages that can be installed additionally. There are no longer distinct "RPKI" and "no RPKI" versions of FRRouting on Debian. - Debian packages are now provided in a repository at: https://deb.frrouting.org/ - Snapcraft packaging has been updated to match. - There is a new "--enable-static-bin" option to link libfrr statically into FRR binaries. This is the only supported way of doing any static linking of FRR. ("--disable-shared" is NOT supported.) - all daemons now properly complete their startup before allowing their parent to exit when the -d daemonization option is used. This should remove the need for any "sleep" calls or start retrying in init scripts. - some minor non-reproducibility issues were fixed. FRRouting should now always build reproducibly. - the topotests system that was previously maintained separately is now shipped as part of the FRR source under tests/topotests. As you can see this is quite a changelog and I'd like to thank everyone who contributed to this release. It has been a very productive 6 months! Cheers, -David

1 0

Add me in slack
by Amod Mishra 07 Mar '19

07 Mar '19

Could you please add me in slack? Regards Amod.

1 0