- dev - lists.frrouting.org

FPM, vrf's and table-id
by Donald Sharp 20 May '19

20 May '19

All - Current behavior of the FPM code is to encode the vrf_id as a uint8_t piece of data and send to the remote listener. This current approach is broken for a variety of reasons, not the least of which is that the vrf_id of a vrf is either the ifindex of the vrf-lite device created or the namespace id. Both of which quite easily go beyond the limit of what can be smushed into a uint8_t size. Thus we have a situation where FPM listeners would get incorrect data about tables. After some discussion we have decided that since this is broken in a bunch of different ways that there is no real good course of action here other than to just update the code to behave like the netlink behavior we see in linux. Namely we will write the table_id we are writing the route to as an uint32_t attribute RTA_TABLE. If you have further questions about this please look at 6dfcd75461ff35ebf89e86f64fe6e982ed09b3e3 thanks! donald

1 0

FRR 7.1 & 8.0 release timelines
by Narendra Bandarupalli 20 May '19

20 May '19

Hello, Can someone please share planned release dates for FRR 7.1 and 8.0 releases. I see FRR 7.1 milestone is created – all submits into master branch as on today are targeted for 7.1 release? Thanks Narendra

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 May '19

17 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1480235: Incorrect expression (NO_EFFECT) /vrrpd/vrrp.c: 1387 in vrrp_change_state_initialize() ________________________________________________________________________________________________________ *** CID 1480235: Incorrect expression (NO_EFFECT) /vrrpd/vrrp.c: 1387 in vrrp_change_state_initialize() 1381 * 1382 * r 1383 * VRRP Router to operate on 1384 */ 1385 static void vrrp_change_state_initialize(struct vrrp_router *r) 1386 { >>> CID 1480235: Incorrect expression (NO_EFFECT) >>> Assigning "r->vr->advertisement_interval" to itself has no effect. 1387 r->vr->advertisement_interval = r->vr->advertisement_interval; 1388 r->master_adver_interval = 0; 1389 vrrp_recalculate_timers(r); 1390 1391 r->advert_pending = false; 1392 r->garp_pending = false; ** CID 1480234: Integer handling issues (NEGATIVE_RETURNS) ________________________________________________________________________________________________________ *** CID 1480234: Integer handling issues (NEGATIVE_RETURNS) /vrrpd/vrrp_arp.c: 145 in vrrp_garp_send() 139 VRRP_LOGPFX VRRP_LOGPFX_VRID VRRP_LOGPFX_FAM 140 "Sending gratuitous ARP on %s for %s", 141 r->vr->vrid, family2str(r->family), ifp->name, astr); 142 if (DEBUG_MODE_CHECK(&vrrp_dbg_arp, DEBUG_MODE_ALL)) 143 zlog_hexdump(garpbuf, garpbuf_len); 144 >>> CID 1480234: Integer handling issues (NEGATIVE_RETURNS) >>> "garpbuf_len" is passed to a parameter that cannot be negative. 145 sent_len = vrrp_send_garp(ifp, garpbuf, garpbuf_len); 146 147 if (sent_len < 0) 148 zlog_warn(VRRP_LOGPFX VRRP_LOGPFX_VRID VRRP_LOGPFX_FAM 149 "Error sending gratuitous ARP on %s for %s", 150 r->vr->vrid, family2str(r->family), ifp->name, astr); ** CID 1480233: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1480233: Memory - corruptions (OVERRUN) /vrrpd/vrrp_ndisc.c: 142 in vrrp_ndisc_una_build() 136 struct ipv6_ph ph = {}; 137 138 ph.src = ip6h->ip6_src; 139 ph.dst = ip6h->ip6_dst; 140 ph.ulpl = htonl(len); 141 ph.next_hdr = IPPROTO_ICMPV6; >>> CID 1480233: Memory - corruptions (OVERRUN) >>> Overrunning struct type icmp6_hdr of 8 bytes by passing it to a function which accesses it at byte offset 31 using argument "len" (which evaluates to 32). 142 icmp6h->icmp6_cksum = in_cksum_with_ph6(&ph, (void *)icmp6h, len); 143 144 return 0; 145 } 146 147 int vrrp_ndisc_una_send(struct vrrp_router *r, struct ipaddr *ip) ** CID 1480232: Uninitialized variables (UNINIT) /vrrpd/vrrp.c: 984 in vrrp_read() ________________________________________________________________________________________________________ *** CID 1480232: Uninitialized variables (UNINIT) /vrrpd/vrrp.c: 984 in vrrp_read() 978 m.msg_namelen = sizeof(sa); 979 m.msg_iov = &iov; 980 m.msg_iovlen = 1; 981 m.msg_control = control; 982 m.msg_controllen = sizeof(control); 983 >>> CID 1480232: Uninitialized variables (UNINIT) >>> Using uninitialized value "m". Field "m.msg_flags" is uninitialized when calling "recvmsg". 984 nbytes = recvmsg(r->sock_rx, &m, MSG_DONTWAIT); 985 986 if ((nbytes < 0 && ERRNO_IO_RETRY(errno))) { 987 resched = true; 988 goto done; 989 } else if (nbytes <= 0) { ** CID 1480231: Error handling issues (CHECKED_RETURN) /vrrpd/vrrp.c: 766 in vrrp_send_advertisement() ________________________________________________________________________________________________________ *** CID 1480231: Error handling issues (CHECKED_RETURN) /vrrpd/vrrp.c: 766 in vrrp_send_advertisement() 760 761 if (DEBUG_MODE_CHECK(&vrrp_dbg_pkt, DEBUG_MODE_ALL)) 762 zlog_hexdump(pkt, (size_t)pktsz); 763 764 const char *group = r->family == AF_INET ? VRRP_MCASTV4_GROUP_STR 765 : VRRP_MCASTV6_GROUP_STR; >>> CID 1480231: Error handling issues (CHECKED_RETURN) >>> Calling "str2sockunion" without checking return value (as is done elsewhere 26 out of 27 times). 766 str2sockunion(group, &dest); 767 768 ssize_t sent = sendto(r->sock_tx, pkt, (size_t)pktsz, 0, &dest.sa, 769 sockunion_sizeof(&dest)); 770 771 XFREE(MTYPE_VRRP_PKT, pkt); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 16 May '19

16 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 12 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1480221: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1480221: Null pointer dereferences (NULL_RETURNS) /zebra/redistribute.c: 773 in zebra_import_table_rm_update() 767 768 rmap_name = zebra_get_import_table_route_map(afi, i); 769 if ((!rmap_name) || (strcmp(rmap_name, rmap) != 0)) 770 continue; 771 table = zebra_vrf_table_with_table_id(afi, SAFI_UNICAST, 772 i, VRF_DEFAULT); >>> CID 1480221: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be null "table" when calling "route_top". 773 for (rn = route_top(table); rn; rn = route_next(rn)) { 774 /* For each entry in the non-default 775 * routing table, 776 * add the entry in the main table 777 */ 778 if (!rn->info) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Feature List : #2639
by Harpreet Kaur 16 May '19

16 May '19

Hi, We are looking for the segment routing support in IS-IS implementation of FRrouting. We see that there is an issue #2639 which mentions this enhancement. Is there anyone who's working on this issue? Also, is it SRv6 or SR-MPLS (since OSPF in FRRouting has SR-MPLS only)? Thanks Harpreet DISCLAIMER: This electronic message and all of its contents, contains information which is privileged, confidential or otherwise protected from disclosure. The information contained in this electronic mail transmission is intended for use only by the individual or entity to which it is addressed. If you are not the intended recipient or may have received this electronic mail transmission in error, please notify the sender immediately and delete / destroy all copies of this electronic mail transmission without disclosing, copying, distributing, forwarding, printing or retaining any part of it. Hughes Systique accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus.

2 3

ask for Ubuntu 19.04 (disco) support.
by SinYu 15 May '19

15 May '19

Hello, I am using ubuntu 19.04, i want to ask for get this support, how i do it? Ign:7 https://deb.frrouting.org/frr disco InRelease Err:8 https://deb.frrouting.org/frr disco Release 404 Not Found [IP: 185.142.180.129 443] Reading package lists... Done E: The repository 'https://deb.frrouting.org/frr disco Release' does not have a Release file. N: Updating from such a repository can't be done securely, and is therefore disabled by default. N: See apt-secure(8) manpage for repository creation and user configuration details.

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 May '19

14 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1480220: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1480220: Null pointer dereferences (FORWARD_NULL) /bfdd/bfd_packet.c: 529 in bfd_recv_cb() 523 uint8_t msgbuf[1516]; 524 struct bfd_vrf_global *bvrf = THREAD_ARG(t); 525 526 if (bvrf) 527 vrfid = bvrf->vrf->vrf_id; 528 /* Schedule next read. */ >>> CID 1480220: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "bvrf" to "bfd_sd_reschedule", which dereferences it. 529 bfd_sd_reschedule(bvrf, sd); 530 531 /* Handle echo packets. */ 532 if (sd == bvrf->bg_echo || sd == bvrf->bg_echov6) { 533 ptm_bfd_process_echo_pkt(bvrf, sd); 534 return 0; ** CID 1480219: (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1480219: (NULL_RETURNS) /bfdd/bfd.c: 182 in bfd_session_enable() 176 /* 177 * Get socket for transmitting control packets. Note that if we 178 * could use the destination port (3784) for the source 179 * port we wouldn't need a socket per session. 180 */ 181 if (BFD_CHECK_FLAG(bs->flags, BFD_SESS_FLAG_IPV6) == 0) { >>> CID 1480219: (NULL_RETURNS) >>> Dereferencing a pointer that might be null "bs->vrf" when calling "bp_peer_socket". 182 psock = bp_peer_socket(bs); 183 if (psock == -1) 184 return 0; 185 } else { 186 psock = bp_peer_socketv6(bs); 187 if (psock == -1) /bfdd/bfd.c: 186 in bfd_session_enable() 180 */ 181 if (BFD_CHECK_FLAG(bs->flags, BFD_SESS_FLAG_IPV6) == 0) { 182 psock = bp_peer_socket(bs); 183 if (psock == -1) 184 return 0; 185 } else { >>> CID 1480219: (NULL_RETURNS) >>> Dereferencing a pointer that might be null "bs->vrf" when calling "bp_peer_socketv6". 186 psock = bp_peer_socketv6(bs); 187 if (psock == -1) 188 return 0; 189 } 190 191 /* ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 May '19

14 May '19

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 9 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1480218: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1577 in lsp_update_internal() ________________________________________________________________________________________________________ *** CID 1480218: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1577 in lsp_update_internal() 1571 1572 if (ret == AOK) 1573 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1574 else { 1575 atomic_fetch_add_explicit(&zdplane_info.dg_lsp_errors, 1, 1576 memory_order_relaxed); >>> CID 1480218: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1577 if (ctx) 1578 dplane_ctx_free(&ctx); 1579 } 1580 1581 return result; 1582 } ** CID 1480217: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1740 in intf_addr_update_internal() ________________________________________________________________________________________________________ *** CID 1480217: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1740 in intf_addr_update_internal() 1734 if (ret == AOK) 1735 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1736 else { 1737 /* Error counter */ 1738 atomic_fetch_add_explicit(&zdplane_info.dg_intf_addr_errors, 1739 1, memory_order_relaxed); >>> CID 1480217: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1740 if (ctx) 1741 dplane_ctx_free(&ctx); 1742 } 1743 1744 return result; 1745 } ** CID 1480216: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1612 in pw_update_internal() ________________________________________________________________________________________________________ *** CID 1480216: Null pointer dereferences (REVERSE_INULL) /zebra/zebra_dplane.c: 1612 in pw_update_internal() 1606 1607 if (ret == AOK) 1608 result = ZEBRA_DPLANE_REQUEST_QUEUED; 1609 else { 1610 atomic_fetch_add_explicit(&zdplane_info.dg_pw_errors, 1, 1611 memory_order_relaxed); >>> CID 1480216: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1612 if (ctx) 1613 dplane_ctx_free(&ctx); 1614 } 1615 1616 return result; 1617 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Re: [dev] I Write Again For This Project
by ＠Ms.E. Al-Hashimi, 06 May '19

06 May '19

1 0

If you have submitted a PR in the last 12-18 hours
by Donald Sharp 02 May '19

02 May '19

All - If you have submitted a PR in the last 12-18 hours we had a PR get pushed in that will cause all of them to fail due to valgrind issues. The push in of the broken PR was a mistake and we apologize for this disruption in your normal scheduled work. If you have pushed a PR in in the last 12-18 hours, please take a moment and rebase off of latest master to pickup the backout of the commits with the valgrind issue and force push an update. Thanks! donald

1 0