- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Oct '18

23 Oct '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1475200: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1475200: Null pointer dereferences (FORWARD_NULL) /sharpd/sharp_vty_clippy.c: 235 in vrf_label() 229 } 230 #if 1 /* anything that can fail? */ 231 if (_failcnt) 232 return CMD_WARNING; 233 #endif 234 #endif >>> CID 1475200: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "name" to "vrf_label_magic", which dereferences it. 235 return vrf_label_magic(self, vty, argc, argv, ipv4, ipv6, name, label, label_str); 236 } 237 238 /* remove_routes => "sharp remove routes A.B.C.D$start (1-1000000)$routes [instance (0-255)$instance]" */ 239 DEFUN_CMD_FUNC_DECL(remove_routes) 240 #define funcdecl_remove_routes static int remove_routes_magic(\ ** CID 1475199: Error handling issues (CHECKED_RETURN) /pbrd/pbr_zebra.c: 364 in pbr_zebra_nexthop_update() ________________________________________________________________________________________________________ *** CID 1475199: Error handling issues (CHECKED_RETURN) /pbrd/pbr_zebra.c: 364 in pbr_zebra_nexthop_update() 358 zebra_size_t length, vrf_id_t vrf_id) 359 { 360 struct zapi_route nhr; 361 char buf[PREFIX2STR_BUFFER]; 362 uint32_t i; 363 >>> CID 1475199: Error handling issues (CHECKED_RETURN) >>> Calling "zapi_nexthop_update_decode" without checking return value (as is done elsewhere 4 out of 5 times). 364 zapi_nexthop_update_decode(zclient->ibuf, &nhr); 365 366 if (DEBUG_MODE_CHECK(&pbr_dbg_zebra, DEBUG_MODE_ALL)) { 367 368 DEBUGD(&pbr_dbg_zebra, "%s: Received Nexthop update: %s", 369 __PRETTY_FUNCTION__, ** CID 1475198: Error handling issues (CHECKED_RETURN) /sharpd/sharp_zebra.c: 226 in sharp_zebra_nexthop_watch() ________________________________________________________________________________________________________ *** CID 1475198: Error handling issues (CHECKED_RETURN) /sharpd/sharp_zebra.c: 226 in sharp_zebra_nexthop_watch() 220 { 221 int command = ZEBRA_NEXTHOP_REGISTER; 222 223 if (!watch) 224 command = ZEBRA_NEXTHOP_UNREGISTER; 225 >>> CID 1475198: Error handling issues (CHECKED_RETURN) >>> Calling "zclient_send_rnh" without checking return value (as is done elsewhere 4 out of 5 times). 226 zclient_send_rnh(zclient, command, p, true, VRF_DEFAULT); 227 } 228 229 static int sharp_nexthop_update(int command, struct zclient *zclient, 230 zebra_size_t length, vrf_id_t vrf_id) 231 { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

TSC Election Results...
by Alistair Woodman 23 Oct '18

23 Oct '18

All, The following individuals were nominated by the community to stand for the 6 slots on the TSC David Lamparter Donald Sharp Martin Winter Philippe Guibert Quentin Young Russ White Because the nominees also numbered 6, their election was 'unopposed' and as such, I announce them to be the dually elected TSC Congratulations. /a

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Oct '18

19 Oct '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1474548: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474548: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_route.c: 5795 in bgp_aggregate_route() 5789 lcommunity = lcommunity_dup( 5790 pinew->attr->lcommunity); 5791 } 5792 } 5793 } 5794 >>> CID 1474548: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "lcommunity" to "bgp_aggregate_install", which dereferences it. 5795 bgp_aggregate_install(bgp, afi, safi, p, origin, aspath, community, 5796 ecommunity, lcommunity, atomic_aggregate, 5797 aggregate); 5798 5799 if (aggregate->count == 0) { 5800 if (aspath) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

RFC 8212
by Christoffer Hansen (Lists) 18 Oct '18

18 Oct '18

dev.lists.frrouting.org, Am I correct to assume FRRouting does not yet support RFC 8212[0][1]? """ Internet Engineering Task Force (IETF) J. Mauch Request for Comments: 8212 Akamai Updates: 4271 J. Snijders Category: Standards Track NTT ISSN: 2070-1721 G. Hankins Nokia July 2017 Default External BGP (EBGP) Route Propagation Behavior without Policies """ -Christoffer [0]: https://tools.ietf.org/html/rfc8212 [1]: https://ripe77.ripe.net/presentations/59-RIPE77_Snijders_Routing_Policy_Arc…, slide 31/32

2 1

FRRouting Docker Hub Account
by Christian Franke 18 Oct '18

18 Oct '18

Hello, apparently, in April 2017 somebody has created an FRRouting account on Dockerhub. This account appears unused, at least there are no public images. Is there anybody here with control over this account? I would like to discuss publishing images there. Also, I think it would be useful to manage that namespace not with a single account but with an organization, similar to the way it is structured at github. All Best, Chris

2 1

Last call for nominations to the TSC....
by Alistair Woodman 17 Oct '18

17 Oct '18

All, In 24 hours I will be closing the nomination list for the TSC election. Any further nominees ? /a

1 0

FRR and VPP, using bgpd
by John Biscevic 17 Oct '18

17 Oct '18

Hello, I had previously gone through the process of using FRR and VPP to pass host-destined TCP traffic northbound so that FRR can handle any BGP traffic. However, it seems there have been changes to how the vppsb plugin works with VPP, as there's no longer syntax to specifically define that TCP traffic can be sent upwards. I'm going through a process of potentially modifying the plugin so that it forwards not only ICMP and OSPF, but TCP, too, which is a hassle in itself. Do we have any currently existing ideas or solutions to pass TCP traffic to FRR so that we can do BGP? Kind regards, John Biscevic

1 0

Thought: Git branching model
by Christoffer Hansen 12 Oct '18

12 Oct '18

Hi dev@, Have FRRouting project responsible developers and managers alike though about the use of this[0][1][2] Git branching model before? -Christoffer "Netravnen" [0]: https://nvie.com/posts/a-successful-git-branching-model/ [1]: https://github.com/nvie/gitflow [2]: https://nvie.com/files/Git-branching-model.pdf

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Oct '18

12 Oct '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 12 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 12 of 12 defect(s) ** CID 1474183: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474183: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 190 in ipv6_protocol() 184 } 185 #if 0 /* anything that can fail? */ 186 if (_failcnt) 187 return CMD_WARNING; 188 #endif 189 #endif >>> CID 1474183: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap" to "ipv6_protocol_magic", which dereferences it. 190 return ipv6_protocol_magic(self, vty, argc, argv, proto, rmap); 191 } 192 193 /* no_ipv6_protocol => "no ipv6 protocol RR_IP6_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 194 DEFUN_CMD_FUNC_DECL(no_ipv6_protocol) 195 #define funcdecl_no_ipv6_protocol static int no_ipv6_protocol_magic(\ ** CID 1474182: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474182: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 478 in ipv6_protocol_nht_rmap() 472 } 473 #if 0 /* anything that can fail? */ 474 if (_failcnt) 475 return CMD_WARNING; 476 #endif 477 #endif >>> CID 1474182: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap" to "ipv6_protocol_nht_rmap_magic", which dereferences it. 478 return ipv6_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 479 } 480 481 /* no_ipv6_protocol_nht_rmap => "no ipv6 nht RR_IP6_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 482 DEFUN_CMD_FUNC_DECL(no_ipv6_protocol_nht_rmap) 483 #define funcdecl_no_ipv6_protocol_nht_rmap static int no_ipv6_protocol_nht_rmap_magic(\ ** CID 1474181: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474181: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 334 in ip_protocol_nht_rmap() 328 } 329 #if 0 /* anything that can fail? */ 330 if (_failcnt) 331 return CMD_WARNING; 332 #endif 333 #endif >>> CID 1474181: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "ip_protocol_nht_rmap_magic", which dereferences it. 334 return ip_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 335 } 336 337 /* no_ip_protocol_nht_rmap => "no ip nht RR_IP_PROTOCOL_MAP_STR_ZEBR $proto route-map [ROUTE-MAP$rmap]" */ 338 DEFUN_CMD_FUNC_DECL(no_ip_protocol_nht_rmap) 339 #define funcdecl_no_ip_protocol_nht_rmap static int no_ip_protocol_nht_rmap_magic(\ ** CID 1474180: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474180: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 46 in ip_protocol() 40 } 41 #if 0 /* anything that can fail? */ 42 if (_failcnt) 43 return CMD_WARNING; 44 #endif 45 #endif >>> CID 1474180: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap" to "ip_protocol_magic", which dereferences it. 46 return ip_protocol_magic(self, vty, argc, argv, proto, rmap); 47 } 48 49 /* no_ip_protocol => "no ip protocol RR_IP_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 50 DEFUN_CMD_FUNC_DECL(no_ip_protocol) 51 #define funcdecl_no_ip_protocol static int no_ip_protocol_magic(\ ** CID 1474179: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474179: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 94 in no_ip_protocol() 88 } 89 #if 0 /* anything that can fail? */ 90 if (_failcnt) 91 return CMD_WARNING; 92 #endif 93 #endif >>> CID 1474179: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "no_ip_protocol_magic", which dereferences it. 94 return no_ip_protocol_magic(self, vty, argc, argv, proto, rmap); 95 } 96 97 /* show_ip_protocol => "show ip protocol [vrf <NAME$vrf_name|all$vrf_all>]" */ 98 DEFUN_CMD_FUNC_DECL(show_ip_protocol) 99 #define funcdecl_show_ip_protocol static int show_ip_protocol_magic(\ ** CID 1474178: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474178: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 334 in ip_protocol_nht_rmap() 328 } 329 #if 0 /* anything that can fail? */ 330 if (_failcnt) 331 return CMD_WARNING; 332 #endif 333 #endif >>> CID 1474178: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap" to "ip_protocol_nht_rmap_magic", which dereferences it. 334 return ip_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 335 } 336 337 /* no_ip_protocol_nht_rmap => "no ip nht RR_IP_PROTOCOL_MAP_STR_ZEBR $proto route-map [ROUTE-MAP$rmap]" */ 338 DEFUN_CMD_FUNC_DECL(no_ip_protocol_nht_rmap) 339 #define funcdecl_no_ip_protocol_nht_rmap static int no_ip_protocol_nht_rmap_magic(\ ** CID 1474177: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474177: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 46 in ip_protocol() 40 } 41 #if 0 /* anything that can fail? */ 42 if (_failcnt) 43 return CMD_WARNING; 44 #endif 45 #endif >>> CID 1474177: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "ip_protocol_magic", which dereferences it. 46 return ip_protocol_magic(self, vty, argc, argv, proto, rmap); 47 } 48 49 /* no_ip_protocol => "no ip protocol RR_IP_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 50 DEFUN_CMD_FUNC_DECL(no_ip_protocol) 51 #define funcdecl_no_ip_protocol static int no_ip_protocol_magic(\ ** CID 1474176: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474176: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 526 in no_ipv6_protocol_nht_rmap() 520 } 521 #if 0 /* anything that can fail? */ 522 if (_failcnt) 523 return CMD_WARNING; 524 #endif 525 #endif >>> CID 1474176: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "no_ipv6_protocol_nht_rmap_magic", which dereferences it. 526 return no_ipv6_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 527 } 528 529 /* show_ipv6_protocol_nht => "show ipv6 nht route-map [vrf <NAME$vrf_name|all$vrf_all>]" */ 530 DEFUN_CMD_FUNC_DECL(show_ipv6_protocol_nht) 531 #define funcdecl_show_ipv6_protocol_nht static int show_ipv6_protocol_nht_magic(\ ** CID 1474175: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474175: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 478 in ipv6_protocol_nht_rmap() 472 } 473 #if 0 /* anything that can fail? */ 474 if (_failcnt) 475 return CMD_WARNING; 476 #endif 477 #endif >>> CID 1474175: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "ipv6_protocol_nht_rmap_magic", which dereferences it. 478 return ipv6_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 479 } 480 481 /* no_ipv6_protocol_nht_rmap => "no ipv6 nht RR_IP6_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 482 DEFUN_CMD_FUNC_DECL(no_ipv6_protocol_nht_rmap) 483 #define funcdecl_no_ipv6_protocol_nht_rmap static int no_ipv6_protocol_nht_rmap_magic(\ ** CID 1474174: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474174: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 238 in no_ipv6_protocol() 232 } 233 #if 0 /* anything that can fail? */ 234 if (_failcnt) 235 return CMD_WARNING; 236 #endif 237 #endif >>> CID 1474174: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "no_ipv6_protocol_magic", which dereferences it. 238 return no_ipv6_protocol_magic(self, vty, argc, argv, proto, rmap); 239 } 240 241 /* show_ipv6_protocol => "show ipv6 protocol [vrf <NAME$vrf_name|all$vrf_all>]" */ 242 DEFUN_CMD_FUNC_DECL(show_ipv6_protocol) 243 #define funcdecl_show_ipv6_protocol static int show_ipv6_protocol_magic(\ ** CID 1474173: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474173: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 382 in no_ip_protocol_nht_rmap() 376 } 377 #if 0 /* anything that can fail? */ 378 if (_failcnt) 379 return CMD_WARNING; 380 #endif 381 #endif >>> CID 1474173: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "no_ip_protocol_nht_rmap_magic", which dereferences it. 382 return no_ip_protocol_nht_rmap_magic(self, vty, argc, argv, proto, rmap); 383 } 384 385 /* show_ip_protocol_nht => "show ip nht route-map [vrf <NAME$vrf_name|all$vrf_all>]" */ 386 DEFUN_CMD_FUNC_DECL(show_ip_protocol_nht) 387 #define funcdecl_show_ip_protocol_nht static int show_ip_protocol_nht_magic(\ ** CID 1474172: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1474172: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_routemap_clippy.c: 190 in ipv6_protocol() 184 } 185 #if 0 /* anything that can fail? */ 186 if (_failcnt) 187 return CMD_WARNING; 188 #endif 189 #endif >>> CID 1474172: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "proto" to "ipv6_protocol_magic", which dereferences it. 190 return ipv6_protocol_magic(self, vty, argc, argv, proto, rmap); 191 } 192 193 /* no_ipv6_protocol => "no ipv6 protocol RR_IP6_PROTOCOL_MAP_STR_ZEBR $proto [route-map ROUTE-MAP$rmap]" */ 194 DEFUN_CMD_FUNC_DECL(no_ipv6_protocol) 195 #define funcdecl_no_ipv6_protocol static int no_ipv6_protocol_magic(\ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Oct '18

12 Oct '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1474171: Incorrect expression (USELESS_CALL) ________________________________________________________________________________________________________ *** CID 1474171: Incorrect expression (USELESS_CALL) /bgpd/bgp_mpath.c: 613 in bgp_path_info_mpath_update() 607 assert(new_mpath); 608 assert(prev_mpath); 609 if ((mpath_count < maxpaths) && (new_mpath != new_best) 610 && bgp_path_info_nexthop_cmp(prev_mpath, 611 new_mpath)) { 612 if (new_mpath == next_mpath) >>> CID 1474171: Incorrect expression (USELESS_CALL) >>> Calling "bgp_path_info_mpath_next(new_mpath)" is only useful for its return value, which is ignored. 613 bgp_path_info_mpath_next(new_mpath); 614 bgp_path_info_mpath_dequeue(new_mpath); 615 616 bgp_path_info_mpath_enqueue(prev_mpath, 617 new_mpath); 618 prev_mpath = new_mpath; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0