- dev - lists.frrouting.org

Trying meet.jit.si for FRR weekly meeting next week
by David Lamparter 26 Sep '18

26 Sep '18

Hi all, I've spent a little time looking at fully open-source videoconferencing services and it turns out jit.si is the most (actually: only) usable one. I'd like to try moving next week's meeting from BlueJeans to meet.jit.si (which is the free service they provide by just running their open source package somewhere.) The URL for the meeting will be: https://meet.jit.si/frr-weekly No registration or anything is required. There are Android and iOS apps, so if you use one of these devices please download the app. Other than that, maybe just try loading the URL above and see if it works :) The primary rationale for the change is that jit.si is fully open source which IMHO merits at least a try to see how FOSS is doing in the videoconferencing field. If we run into problems, we can just fall back to BlueJeans as usual. Cheers, David P.S.: the one major downside is that with the meet.jit.si service, we won't have a moderator for the room. Please make sure you're not sending noise into the conference and always mute your microphone when not speaking.

2 2

Reg. Frr-www gpg passphrase
by Roshan Nair 25 Sep '18

25 Sep '18

Hi, I am not sure if it's the right forum to ask queries on frr web server. If not, pls ignore. Apologies! While following steps in readme for source installation of frr web the following command asks for "pass phrase". Can some one provide pointers to what the pass phrase for the file is? Command: *Sudo gpg frrouting.ssl.tar.gpg*

3 2

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Sep '18

23 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473593: Control flow issues (DEADCODE) /zebra/rt_netlink.c: 2239 in netlink_macfdb_update() ________________________________________________________________________________________________________ *** CID 1473593: Control flow issues (DEADCODE) /zebra/rt_netlink.c: 2239 in netlink_macfdb_update() 2233 vid_present = 1; 2234 sprintf(vid_buf, " VLAN %u", vid); 2235 } 2236 addattr32(&req.n, sizeof(req), NDA_MASTER, br_if->ifindex); 2237 2238 if (IS_ZEBRA_DEBUG_KERNEL) >>> CID 1473593: Control flow issues (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Tx %s family %s...". 2239 zlog_debug("Tx %s family %s IF %s(%u)%s %sMAC %s%s", 2240 nl_msg_type_to_str(cmd), 2241 nl_family_to_str(req.ndm.ndm_family), ifp->name, 2242 ifp->ifindex, vid_present ? vid_buf : "", 2243 sticky ? "sticky " : "", 2244 prefix_mac2str(mac, buf, sizeof(buf)), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 21 Sep '18

21 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() ________________________________________________________________________________________________________ *** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() 1903 lsp = NULL; 1904 dict_delete_free(area->lspdb[level], 1905 dnode); 1906 } 1907 1908 if (fabricd_init_c) { >>> CID 1473285: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "lsp". 1909 fabricd_sync_incomplete |= 1910 ISIS_CHECK_FLAG(lsp->SSNflags, 1911 fabricd_init_c); 1912 } 1913 } 1914 } ** CID 1399484: Null pointer dereferences (NULL_RETURNS) /tools/permutations.c: 43 in main() ________________________________________________________________________________________________________ *** CID 1399484: Null pointer dereferences (NULL_RETURNS) /tools/permutations.c: 43 in main() 37 { 38 if (argc < 2) { 39 fprintf(stdout, USAGE "\n"); 40 exit(EXIT_SUCCESS); 41 } 42 struct cmd_element *cmd = calloc(1, sizeof(struct cmd_element)); >>> CID 1399484: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "cmd". 43 cmd->string = strdup(argv[1]); 44 45 struct graph *graph = graph_new(); 46 struct cmd_token *token = 47 cmd_token_new(START_TKN, cmd->attr, NULL, NULL); 48 graph_new_node(graph, token, NULL); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Bgpd 5.0.1 gets killed by watchdog timeout
by François 21 Sep '18

21 Sep '18

Hi! I've been using 5.0.1 deb package provided on github on Debian 9.5. It looks like I'm having the same issue as https://lists.frrouting.org/pipermail/frog/2017-May/000016.html Also, it seems that systemd is enabled https://github.com/FRRouting/frr/blob/18d93bbb5a2d6acc791726ad6de7f11d6818d… and also, libsystemd is linked to bgpd: $ ldd /usr/lib/frr/bgpd | grep system libsystemd.so.0 => /lib/x86_64-linux-gnu/libsystemd.so.0 (0x00007f6fc540c000) Am I missing something? Thanks! -- François

2 10

FRR support for FPM
by Tiwari, Mayank (Contractor) 21 Sep '18

21 Sep '18

Hi, We are using quagga in our solution for FPM connection and Reverse FPM connection with ONOS. In order to support BFD feature I need to upgrade from quagga to FRR. For that I was patching the changes present in quagga to FRR. During that patching process the following patch is causing compilation issue: diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c index 43d76a6..03c4a6b 100644 --- a/zebra/zebra_vty.c +++ b/zebra/zebra_vty.c @@ -20,6 +20,7 @@ #include <zebra.h> +#include "zebra_fpm.h" #include "memory.h" #include "zebra_memory.h" #include "if.h" + +/* function to write the fpm config info */ +static int config_write_fpm (struct vty *vty) +{ + return fpm_remote_srv_write (vty); +} + +/* Zebra node */ +static struct cmd_node zebra_node = +{ + ZEBRA_NODE, + "", + 1 +}; /* Route VTY. */ void zebra_vty_init(void) { /* Install configuration write function. */ install_node(&table_node, config_write_table); install_node(&forwarding_node, config_write_forwarding); + install_node (&zebra_node, config_write_fpm); install_element(VIEW_NODE, &show_ip_forwarding_cmd); install_element(CONFIG_NODE, &ip_forwarding_cmd); diff --git a/zebra/zebra_fpm.h b/zebra/zebra_fpm.h new file mode 100644 index 0000000..9291ffa --- /dev/null +++ b/zebra/zebra_fpm.h @@ -0,0 +1,35 @@ +/* + * Router ID for zebra daemon. + * + * Copyright (C) 2004 James R. Leu + * + * This file is part of Quagga routing suite. + * + * Quagga is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2, or (at your option) any + * later version. + * + * Quagga is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; see the file COPYING; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _ZEBRA_VTY_H_ +#define _ZEBRA_VTY_H_ + +#include <zebra.h> +#include "memory.h" +#include "prefix.h" +#include "zclient.h" +#include "if.h" + + +static int fpm_remote_srv_write (struct vty *vty ); + +#endif The function 'fpm_remote_srv_write' is already defined in zebra_fpm.c file which I need to use zebra_vty.c file. I have created a header with name zebra_fpm.h and declared that function there and later included this header in zebra_vty.c. The compilation of zebra_vty.c fails as it is not able to find 'fpm_remote_srv_write' function This is the compilation error: CCLD zebra/zebra_irdp.la CC zebra/zebra_fpm.lo CC zebra/zebra_fpm_netlink.lo ..... ..... CC zebra/zebra_vty.o In file included from zebra/zebra_vty.c:23:0: zebra/zebra_fpm.h:33:12: warning: 'fpm_remote_srv_write' used but never defined static int fpm_remote_srv_write (struct vty *vty ); ^ CC zebra/zebra_vxlan.o CC zebra/zserv.o CC zebra/zebra_netns_id.o CC zebra/zebra_netns_notify.o CC zebra/table_manager.o CC zebra/zapi_msg.o CCLD zebra/zebra zebra/zebra_vty.o: In function `config_write_fpm': /frr/zebra/zebra_vty.c:3697: undefined reference to `fpm_remote_srv_write' collect2: error: ld returned 1 exit status make[2]: *** [zebra/zebra] Error 1 Makefile:3246: recipe for target 'zebra/zebra' failed make[2]: Leaving directory '/frr' Makefile:4421: recipe for target 'all-recursive' failed make[1]: Leaving directory '/frr' make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 I have observed that zebra_fpm.c is compiled as zebra_fpm.lo instead of zebra_fpm.o. I am not sure if that can cause this issue. Please suggest what I am missing here and what approach I need to take to fix this issue. Thanks and Regards, Mayank

3 3

Fwd: [NetDev-People] Announcing Netdev 0x13 conference
by Donald Sharp 18 Sep '18

18 Sep '18

All - The next netdev conference is in Prague in late march of 2019, placed right before the next IETF. I am currently planning on attending/presenting at this conference and hope to see some of you there. This conference would be an excellent place to spend some face to face time with your fellow FRRouting developers as well as linux kernel developers. I also think that we would be well served if presentations from the FRR community were submitted at this conference as well. thanks! donald ---------- Forwarded message ---------- From: Jamal Hadi Salim via people <people(a)lists.netdevconf.org> Date: Tue, Sep 18, 2018 at 8:11 AM Subject: [NetDev-People] Announcing Netdev 0x13 conference To: people <people(a)netdevconf.org> Cc: lwn(a)lwn.net, "netdev(a)vger.kernel.org" <netdev(a)vger.kernel.org>, linux-wireless <linux-wireless(a)vger.kernel.org>, netfilter-devel(a)vger.kernel.org On behalf of the NetDev Society, this is a formal announcement that Netdev 0x13 conference will be held in Prague, Czech Republic. Tentative dates are March 20-22, 2019. We had a very successful 0x12 meeting. The summaries are posted here: https://lwn.net/Articles/763627/rss For more details, all the slides, papers and videos are now up. Visit: https://www.netdevconf.org/0x12/accepted-sessions.html At 0x12 we tried a new format where the first day constitutes developer working sessions via workshops and educational sessions via tutorials. We have received feedback which we are in the process of evaluating and we will be notifying you of any format changes. The window for suggestions is still open - please send email to people(a)netdevconf.org. We hope to announce the CFP much earlier than usual to give folks ample time to submit. For more frequent announcements join the people@netdevconf mailing list. If tweeter is your thing we also do announce @netdev01 The official 0x13 website is at: https://www.netdevconf.org/0x13 cheers, jamal _______________________________________________ people mailing list people(a)netdevconf.org https://lists.netdevconf.org/cgi-bin/mailman/listinfo/people

1 0

OpenFabric now included in FRR
by Christian Franke 17 Sep '18

17 Sep '18

All - I'm glad to announce the merging of OpenFabric (PR #2875 https://github.com/FRRouting/frr/pull/2875) into master. OpenFabric (https://tools.ietf.org/html/draft-white-openfabric-06) is one of the solutions provided for the currently ongoing effort in the IETF to develop routing protocols which cope well with densely connected topologies like spine-leaf and clos. For those topologies, established routing protocols often run into scaling issues because of large fan-out and the high degree of interconnection. OpenFabric is based on IS-IS. To improve the scaling properties, it uses a more optimized flooding algorithm which reduces the number of LSPs exchanged in the network to the minimum required to update all nodes. To to test FRR's implementation of OpenFabric, just build and run fabricd with a configuration as following: > ! > interface lo > ip address 100.0.1.1/32 > ip router openfabric 1 > ipv6 address 2001:db8:64::1:1/128 > ipv6 router openfabric 1 > openfabric passive > ! > interface eth0 > ip router openfabric 1 > ipv6 router openfabric 1 > ! > [...] > ! > interface ethX > ip router openfabric 1 > ipv6 router openfabric 1 > ! > router openfabric 1 > net 49.0001.0001.0001.00 > ! All Best, Chris

1 0

Nominate a couple people to be maintainers
by Donald Sharp 12 Sep '18

12 Sep '18

All - I would like to nominate both Sri Mohana and Mark Stapp to be maintainers to the FRR project. Both these individuals have contributed code as well as time spent reviewing new code coming in. thanks! donald

1 0

Slack invitation request
by Srinivas K 12 Sep '18

12 Sep '18

Hello, Can I please request an invitation to the public FRR Slack Channel? Kind Regards Srini

2 1