- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Sep '18

23 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473593: Control flow issues (DEADCODE) /zebra/rt_netlink.c: 2239 in netlink_macfdb_update() ________________________________________________________________________________________________________ *** CID 1473593: Control flow issues (DEADCODE) /zebra/rt_netlink.c: 2239 in netlink_macfdb_update() 2233 vid_present = 1; 2234 sprintf(vid_buf, " VLAN %u", vid); 2235 } 2236 addattr32(&req.n, sizeof(req), NDA_MASTER, br_if->ifindex); 2237 2238 if (IS_ZEBRA_DEBUG_KERNEL) >>> CID 1473593: Control flow issues (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Tx %s family %s...". 2239 zlog_debug("Tx %s family %s IF %s(%u)%s %sMAC %s%s", 2240 nl_msg_type_to_str(cmd), 2241 nl_family_to_str(req.ndm.ndm_family), ifp->name, 2242 ifp->ifindex, vid_present ? vid_buf : "", 2243 sticky ? "sticky " : "", 2244 prefix_mac2str(mac, buf, sizeof(buf)), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 21 Sep '18

21 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() ________________________________________________________________________________________________________ *** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() 1903 lsp = NULL; 1904 dict_delete_free(area->lspdb[level], 1905 dnode); 1906 } 1907 1908 if (fabricd_init_c) { >>> CID 1473285: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "lsp". 1909 fabricd_sync_incomplete |= 1910 ISIS_CHECK_FLAG(lsp->SSNflags, 1911 fabricd_init_c); 1912 } 1913 } 1914 } ** CID 1399484: Null pointer dereferences (NULL_RETURNS) /tools/permutations.c: 43 in main() ________________________________________________________________________________________________________ *** CID 1399484: Null pointer dereferences (NULL_RETURNS) /tools/permutations.c: 43 in main() 37 { 38 if (argc < 2) { 39 fprintf(stdout, USAGE "\n"); 40 exit(EXIT_SUCCESS); 41 } 42 struct cmd_element *cmd = calloc(1, sizeof(struct cmd_element)); >>> CID 1399484: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "cmd". 43 cmd->string = strdup(argv[1]); 44 45 struct graph *graph = graph_new(); 46 struct cmd_token *token = 47 cmd_token_new(START_TKN, cmd->attr, NULL, NULL); 48 graph_new_node(graph, token, NULL); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Bgpd 5.0.1 gets killed by watchdog timeout
by François 21 Sep '18

21 Sep '18

Hi! I've been using 5.0.1 deb package provided on github on Debian 9.5. It looks like I'm having the same issue as https://lists.frrouting.org/pipermail/frog/2017-May/000016.html Also, it seems that systemd is enabled https://github.com/FRRouting/frr/blob/18d93bbb5a2d6acc791726ad6de7f11d6818d… and also, libsystemd is linked to bgpd: $ ldd /usr/lib/frr/bgpd | grep system libsystemd.so.0 => /lib/x86_64-linux-gnu/libsystemd.so.0 (0x00007f6fc540c000) Am I missing something? Thanks! -- François

2 10

FRR support for FPM
by Tiwari, Mayank (Contractor) 20 Sep '18

20 Sep '18

Hi, We are using quagga in our solution for FPM connection and Reverse FPM connection with ONOS. In order to support BFD feature I need to upgrade from quagga to FRR. For that I was patching the changes present in quagga to FRR. During that patching process the following patch is causing compilation issue: diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c index 43d76a6..03c4a6b 100644 --- a/zebra/zebra_vty.c +++ b/zebra/zebra_vty.c @@ -20,6 +20,7 @@ #include <zebra.h> +#include "zebra_fpm.h" #include "memory.h" #include "zebra_memory.h" #include "if.h" + +/* function to write the fpm config info */ +static int config_write_fpm (struct vty *vty) +{ + return fpm_remote_srv_write (vty); +} + +/* Zebra node */ +static struct cmd_node zebra_node = +{ + ZEBRA_NODE, + "", + 1 +}; /* Route VTY. */ void zebra_vty_init(void) { /* Install configuration write function. */ install_node(&table_node, config_write_table); install_node(&forwarding_node, config_write_forwarding); + install_node (&zebra_node, config_write_fpm); install_element(VIEW_NODE, &show_ip_forwarding_cmd); install_element(CONFIG_NODE, &ip_forwarding_cmd); diff --git a/zebra/zebra_fpm.h b/zebra/zebra_fpm.h new file mode 100644 index 0000000..9291ffa --- /dev/null +++ b/zebra/zebra_fpm.h @@ -0,0 +1,35 @@ +/* + * Router ID for zebra daemon. + * + * Copyright (C) 2004 James R. Leu + * + * This file is part of Quagga routing suite. + * + * Quagga is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2, or (at your option) any + * later version. + * + * Quagga is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; see the file COPYING; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _ZEBRA_VTY_H_ +#define _ZEBRA_VTY_H_ + +#include <zebra.h> +#include "memory.h" +#include "prefix.h" +#include "zclient.h" +#include "if.h" + + +static int fpm_remote_srv_write (struct vty *vty ); + +#endif The function 'fpm_remote_srv_write' is already defined in zebra_fpm.c file which I need to use zebra_vty.c file. I have created a header with name zebra_fpm.h and declared that function there and later included this header in zebra_vty.c. The compilation of zebra_vty.c fails as it is not able to find 'fpm_remote_srv_write' function This is the compilation error: CCLD zebra/zebra_irdp.la CC zebra/zebra_fpm.lo CC zebra/zebra_fpm_netlink.lo ..... ..... CC zebra/zebra_vty.o In file included from zebra/zebra_vty.c:23:0: zebra/zebra_fpm.h:33:12: warning: 'fpm_remote_srv_write' used but never defined static int fpm_remote_srv_write (struct vty *vty ); ^ CC zebra/zebra_vxlan.o CC zebra/zserv.o CC zebra/zebra_netns_id.o CC zebra/zebra_netns_notify.o CC zebra/table_manager.o CC zebra/zapi_msg.o CCLD zebra/zebra zebra/zebra_vty.o: In function `config_write_fpm': /frr/zebra/zebra_vty.c:3697: undefined reference to `fpm_remote_srv_write' collect2: error: ld returned 1 exit status make[2]: *** [zebra/zebra] Error 1 Makefile:3246: recipe for target 'zebra/zebra' failed make[2]: Leaving directory '/frr' Makefile:4421: recipe for target 'all-recursive' failed make[1]: Leaving directory '/frr' make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 I have observed that zebra_fpm.c is compiled as zebra_fpm.lo instead of zebra_fpm.o. I am not sure if that can cause this issue. Please suggest what I am missing here and what approach I need to take to fix this issue. Thanks and Regards, Mayank

3 3

Fwd: [NetDev-People] Announcing Netdev 0x13 conference
by Donald Sharp 18 Sep '18

18 Sep '18

All - The next netdev conference is in Prague in late march of 2019, placed right before the next IETF. I am currently planning on attending/presenting at this conference and hope to see some of you there. This conference would be an excellent place to spend some face to face time with your fellow FRRouting developers as well as linux kernel developers. I also think that we would be well served if presentations from the FRR community were submitted at this conference as well. thanks! donald ---------- Forwarded message ---------- From: Jamal Hadi Salim via people <people(a)lists.netdevconf.org> Date: Tue, Sep 18, 2018 at 8:11 AM Subject: [NetDev-People] Announcing Netdev 0x13 conference To: people <people(a)netdevconf.org> Cc: lwn(a)lwn.net, "netdev(a)vger.kernel.org" <netdev(a)vger.kernel.org>, linux-wireless <linux-wireless(a)vger.kernel.org>, netfilter-devel(a)vger.kernel.org On behalf of the NetDev Society, this is a formal announcement that Netdev 0x13 conference will be held in Prague, Czech Republic. Tentative dates are March 20-22, 2019. We had a very successful 0x12 meeting. The summaries are posted here: https://lwn.net/Articles/763627/rss For more details, all the slides, papers and videos are now up. Visit: https://www.netdevconf.org/0x12/accepted-sessions.html At 0x12 we tried a new format where the first day constitutes developer working sessions via workshops and educational sessions via tutorials. We have received feedback which we are in the process of evaluating and we will be notifying you of any format changes. The window for suggestions is still open - please send email to people(a)netdevconf.org. We hope to announce the CFP much earlier than usual to give folks ample time to submit. For more frequent announcements join the people@netdevconf mailing list. If tweeter is your thing we also do announce @netdev01 The official 0x13 website is at: https://www.netdevconf.org/0x13 cheers, jamal _______________________________________________ people mailing list people(a)netdevconf.org https://lists.netdevconf.org/cgi-bin/mailman/listinfo/people

1 0

OpenFabric now included in FRR
by Christian Franke 17 Sep '18

17 Sep '18

All - I'm glad to announce the merging of OpenFabric (PR #2875 https://github.com/FRRouting/frr/pull/2875) into master. OpenFabric (https://tools.ietf.org/html/draft-white-openfabric-06) is one of the solutions provided for the currently ongoing effort in the IETF to develop routing protocols which cope well with densely connected topologies like spine-leaf and clos. For those topologies, established routing protocols often run into scaling issues because of large fan-out and the high degree of interconnection. OpenFabric is based on IS-IS. To improve the scaling properties, it uses a more optimized flooding algorithm which reduces the number of LSPs exchanged in the network to the minimum required to update all nodes. To to test FRR's implementation of OpenFabric, just build and run fabricd with a configuration as following: > ! > interface lo > ip address 100.0.1.1/32 > ip router openfabric 1 > ipv6 address 2001:db8:64::1:1/128 > ipv6 router openfabric 1 > openfabric passive > ! > interface eth0 > ip router openfabric 1 > ipv6 router openfabric 1 > ! > [...] > ! > interface ethX > ip router openfabric 1 > ipv6 router openfabric 1 > ! > router openfabric 1 > net 49.0001.0001.0001.00 > ! All Best, Chris

1 0

Nominate a couple people to be maintainers
by Donald Sharp 12 Sep '18

12 Sep '18

All - I would like to nominate both Sri Mohana and Mark Stapp to be maintainers to the FRR project. Both these individuals have contributed code as well as time spent reviewing new code coming in. thanks! donald

1 0

Slack invitation request
by Srinivas K 12 Sep '18

12 Sep '18

Hello, Can I please request an invitation to the public FRR Slack Channel? Kind Regards Srini

2 1

Re: [dev] [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230)
by Jia Chen 11 Sep '18

11 Sep '18

Just a question, Should configured distance be considered by Zebra/RTM stage rather than inside of BGP best path selection. If BGP best path selection need to be influenced, why using weight, local preference etc not enough? In another note, the deterministic behavior, are we talking about ordered/prioritized FIB downloading depending on route types? Thanks, Jay Configured distance From: dev <dev-bounces(a)lists.frrouting.org> on behalf of Mohan Singamsetty <msingamsetty(a)vmware.com> Date: Monday, September 10, 2018 at 9:40 AM To: Donald Sharp <sharpd(a)cumulusnetworks.com>, "ntriantafillis(a)gmail.com" <ntriantafillis(a)gmail.com>, FRRouting-Dev <dev(a)lists.frrouting.org>, Don Slice <dslice(a)cumulusnetworks.com>, Russ White <russ(a)riw.us> Subject: Re: [dev] [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230) We had this meeting to discuss issue #2230 and conclude on the fix. Date: 09-05-2018 Attendees: Donald, Nikos, Don, Mohan, Soman. Minutes: 1. Two issues were discussed. * FRR stack not being deterministic in downloading routes to RIB/FIB and the routes downloaded to RIB/FIB depends on sequence of commands executed or sequence of network events happened. Ideally the routes in RIB/FIB should be deterministic and consistent at a given time after executing set of same commands. * FRR stack not honoring the admin distance configured for routes and downloading routes with higher admin distance (higher in numerical value). Ideally routes with lower admin distances should be considered as best routes and should get downloaded to RIB/FIB. 2. Two Proposals were considered. * Consider admin distance configured for each route in BGP best bath algorithm to make FRR stack behave more deterministic and consistent with respect to downloading routes to RIB/FIB. * Use route maps to control the routes to be downloaded to RIB/FIB depending on the requirement and use case. Conclusion: 1. It was concluded that the FRR stack behavior should be deterministic even without using any route maps (without any additional configuration from user). 2. Team agreed to use proposal #1 (Using the admin distance of route/protocol inside the BGP best path algorithm to determine the best route) to move forward and address the above issues mentioned. 3. Admin distance will be the first thing to compare in FRR best bath path algorithm. This is in addition to the other 13 checks that FRR stack currently has. 4. There will be a #def to control the default behavior from build time. i.e. either to have the old behavior where admin distance of each route is not used inside the BGP best path algorithm or to have new behavior where admin distance is used inside BGP best path algorithm to fix the above issue. User can use this #def to build the FRR stack and get the default behavior that is needed. 5. There will be a CLI command also to control the default behavior as explained above. We will publish the design and start implementing this soon. Guys, please add more if I missed to add anything here. Thanks, Mohan From: Mohan Singamsetty <msingamsetty(a)vmware.com> Date: Tuesday, September 4, 2018 at 10:15 AM To: Donald Sharp <sharpd(a)cumulusnetworks.com>, "ntriantafillis(a)gmail.com" <ntriantafillis(a)gmail.com>, FRRouting-Dev <dev(a)lists.frrouting.org> Subject: Re: [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230) I am setting up a meeting to discuss this further on Wednesday (5th September) at 8 AM PST. Link for the bug and comments https://github.com/FRRouting/frr/issues/2230<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_FRRouting_f…> Donald, Nikos, Russ, Please let me know if this time works for you. If anyone else is interested to join, please let me know and I will add you to the meeting. Thanks, Mohan From: David Lamparter <notifications(a)github.com> Reply-To: FRRouting/frr <reply+009b114fa2e0109bec00750471786212a516d3548fe6032192cf0000000117a665b892a169ce133f1a52(a)reply.github.com> Date: Tuesday, September 4, 2018 at 8:24 AM To: FRRouting/frr <frr(a)noreply.github.com> Cc: Mohan Singamsetty <msingamsetty(a)vmware.com>, Comment <comment(a)noreply.github.com> Subject: Re: [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230) => meeting this week => rough consensus on call is that deterministic behaviour is desired — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__na01.safelinks.protect…>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__na01.safelinks.protect…>.

2 1

Re: [dev] Dataplane API
by Donald Sharp 10 Sep '18

10 Sep '18

I actually agree with both Vincent and Lou :) The current paradigm is a kernel based infrastructure and will be so for the foreseeable future. So if you are doing development *now* I would highly recommend working towards this paradigm. So Vincent is correct. Having said that, we are looking towards more formally defining the DataPlane API so that it becomes possible to allow a fully implemented dataplane api that if someone wanted to implement non-kernel based interfaces they could. So Lou is correct too! There is a lot of work here though, mainly of a infrastructure updates. I've currently (slowly) started trying to define this api( See https://github.com/FRRouting/frr/pull/2292 ). The current api line for the dataplane is fuzzy at best and lots of assumptions are made about behavior and how data structures are created. This line must be wedged apart as a first step. If you are unsure where to start here, please ask and we'll have suggestions. We also have additional goals for zebra such as true pthreads and nexthop-group route entry indirection to name a few. Please note we are not doing this work specifically to allow a full dataplane outside of a kernel, it should fall out if I do the work correctly for what I am interested in. I am doing this work because I think this work will allow me to do some work with route-aggregation as well as more efficiently pass data to the kernel for route installs. I'm sure other people have their own reasons, just as long as we keep those in mind and work together. thanks! donald On Tue, May 29, 2018 at 3:04 PM, Jay Chen <jchen1(a)paloaltonetworks.com> wrote: > A quick question about FRR interfaces. The Zebra get interface information/status from Kernel. > > In our platform, it is almost impossible to put interface into kernel (due to history reasons people object to do so). Is there anyone else facing the same situation and any suggestions for a work around? Or anything similarly to FPM existing for interface to bypass kernel (from interface manager to Zebra instead)? > > Thanks, > Jay > >

5 12