- dev - lists.frrouting.org

Re: [dev] [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230)
by Mohan Singamsetty 10 Sep '18

10 Sep '18

I am setting up a meeting to discuss this further on Wednesday (5th September) at 8 AM PST. Link for the bug and comments https://github.com/FRRouting/frr/issues/2230 Donald, Nikos, Russ, Please let me know if this time works for you. If anyone else is interested to join, please let me know and I will add you to the meeting. Thanks, Mohan From: David Lamparter <notifications(a)github.com> Reply-To: FRRouting/frr <reply+009b114fa2e0109bec00750471786212a516d3548fe6032192cf0000000117a665b892a169ce133f1a52(a)reply.github.com> Date: Tuesday, September 4, 2018 at 8:24 AM To: FRRouting/frr <frr(a)noreply.github.com> Cc: Mohan Singamsetty <msingamsetty(a)vmware.com>, Comment <comment(a)noreply.github.com> Subject: Re: [FRRouting/frr] Static blackhole route does not honor distance attribute (#2230) => meeting this week => rough consensus on call is that deterministic behaviour is desired — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com…>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com…>.

2 2

master git history rewound by 1 commit
by David Lamparter 10 Sep '18

10 Sep '18

Hi all, due to a mistaken merge yesterday evening EDT (about 15 hours ago), we've rewound the history to plop that one topmost commit off. We're currently waiting to see whether this causes nontrivial problems for anyone, so if you have any issues please send an e-mail or speak up on Slack. If it does cause issues, we'll re-push the ill-fated merge commit and do the revert on top of that. Apologies for any inconveniences caused, -David

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 Sep '18

09 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1473286: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1473286: Memory - corruptions (OVERRUN) /isisd/isis_spf.c: 1070 in isis_spf_loop() 1064 add_to_paths(spftree, vertex); 1065 if (!VTYPE_IS(vertex->type)) 1066 continue; 1067 1068 lsp = lsp_for_vertex(spftree, vertex); 1069 if (!lsp) { >>> CID 1473286: Memory - corruptions (OVERRUN) >>> Overrunning array "vertex->N.id" of 7 bytes by passing it to a function which accesses it at byte offset 7. 1070 zlog_warn("ISIS-Spf: No LSP found for %s", 1071 rawlspid_print(vertex->N.id)); /* FIXME */ 1072 continue; 1073 } 1074 1075 isis_spf_process_lsp(spftree, lsp, vertex->d_N, vertex->depth, ** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() ________________________________________________________________________________________________________ *** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() 1903 lsp = NULL; 1904 dict_delete_free(area->lspdb[level], 1905 dnode); 1906 } 1907 1908 if (fabricd_init_c) { >>> CID 1473285: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "lsp". 1909 fabricd_sync_incomplete |= 1910 ISIS_CHECK_FLAG(lsp->SSNflags, 1911 fabricd_init_c); 1912 } 1913 } 1914 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

BGP Views
by Donald Sharp 07 Sep '18

07 Sep '18

In today's technical meeting we discussed removing the ability to have views as an option in bgp. Before we do any such thing we decided to poll the community to see if anyone is using views and if so what is the use case that they are using them under. So if you have any insight into this we would love to hear from you! Thanks! donald

4 5

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Sep '18

06 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473200: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1473200: Uninitialized variables (UNINIT) /bfdd/bfd_packet.c: 754 in bp_bfd_echo_in() 748 ssize_t rlen; 749 struct sockaddr_any local, peer; 750 char port[MAXNAMELEN + 1], vrfname[MAXNAMELEN + 1]; 751 uint8_t msgbuf[1516]; 752 753 if (sd == bglobal.bg_echo) >>> CID 1473200: Uninitialized variables (UNINIT) >>> Using uninitialized element of array "port" when calling "bfd_recv_ipv4". 754 rlen = bfd_recv_ipv4(sd, msgbuf, sizeof(msgbuf), ttl, port, 755 sizeof(port), vrfname, sizeof(vrfname), 756 &local, &peer); 757 else 758 rlen = bfd_recv_ipv6(sd, msgbuf, sizeof(msgbuf), ttl, port, 759 sizeof(port), vrfname, sizeof(vrfname), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Sep '18

05 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473199: (DEADCODE) /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() ________________________________________________________________________________________________________ *** CID 1473199: (DEADCODE) /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() 4239 } else { 4240 tmp_seq = n->rem_seq; 4241 n_type = "remote"; 4242 } 4243 if (seq < tmp_seq) { 4244 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1473199: (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Ignore remote M...". 4245 zlog_debug("Ignore remote MACIP ADD VNI %u MAC %s%s%s as existing %s Neigh has higher seq %u", 4246 vni, 4247 prefix_mac2str(macaddr, 4248 buf, sizeof(buf)), 4249 ipa_len ? " IP " : "", 4250 ipa_len ? /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() 4239 } else { 4240 tmp_seq = n->rem_seq; 4241 n_type = "remote"; 4242 } 4243 if (seq < tmp_seq) { 4244 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1473199: (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Ignore remote M...". 4245 zlog_debug("Ignore remote MACIP ADD VNI %u MAC %s%s%s as existing %s Neigh has higher seq %u", 4246 vni, 4247 prefix_mac2str(macaddr, 4248 buf, sizeof(buf)), 4249 ipa_len ? " IP " : "", 4250 ipa_len ? ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Request for slack invite.
by Naveen Thanikachalam 03 Sep '18

03 Sep '18

Hello, I’d like to subscribe to the FRRouting slack workspace. Kindly send me an invitation. -Naveen T

1 0

duplicate frr in source tar name
by Michal Ruprich 31 Aug '18

31 Aug '18

Hi, is there any specific reason for naming every source file frr-frr-x.y.z? Why using the name frr twice? Regards, Michal Ruprich

2 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Aug '18

30 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473090: Incorrect expression (NO_EFFECT) /lib/frr_pthread.c: 335 in fpt_run() ________________________________________________________________________________________________________ *** CID 1473090: Incorrect expression (NO_EFFECT) /lib/frr_pthread.c: 335 in fpt_run() 329 int sleeper[2]; 330 pipe(sleeper); 331 thread_add_read(fpt->master, &fpt_dummy, NULL, sleeper[0], NULL); 332 333 fpt->master->handle_signals = false; 334 >>> CID 1473090: Incorrect expression (NO_EFFECT) >>> Comparing an array to null is not useful: "fpt->os_name", since the test will always evaluate as true. 335 if (fpt->os_name) 336 frr_pthread_set_name(fpt, NULL, fpt->os_name); 337 338 frr_pthread_notify_running(fpt); 339 340 struct thread task; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 29 Aug '18

29 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) /lib/ferr.c: 151 in log_ref_display() ________________________________________________________________________________________________________ *** CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) /lib/ferr.c: 151 in log_ref_display() 145 char pbuf[256]; 146 char ubuf[256]; 147 148 snprintf(pbuf, sizeof(pbuf), "\nError %"PRIu32" - %s", 149 ref->code, ref->title); 150 memset(ubuf, '=', strlen(pbuf)); >>> CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "strlen(pbuf) - 1UL" used as array index. 151 ubuf[strlen(pbuf) - 1] = '\0'; 152 153 vty_out(vty, "%s\n%s\n", pbuf, ubuf); 154 vty_out(vty, "Description:\n%s\n\n", ref->description); 155 vty_out(vty, "Recommendation:\n%s\n", ref->suggestion); 156 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0