- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 09 Sep '18

09 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1473286: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1473286: Memory - corruptions (OVERRUN) /isisd/isis_spf.c: 1070 in isis_spf_loop() 1064 add_to_paths(spftree, vertex); 1065 if (!VTYPE_IS(vertex->type)) 1066 continue; 1067 1068 lsp = lsp_for_vertex(spftree, vertex); 1069 if (!lsp) { >>> CID 1473286: Memory - corruptions (OVERRUN) >>> Overrunning array "vertex->N.id" of 7 bytes by passing it to a function which accesses it at byte offset 7. 1070 zlog_warn("ISIS-Spf: No LSP found for %s", 1071 rawlspid_print(vertex->N.id)); /* FIXME */ 1072 continue; 1073 } 1074 1075 isis_spf_process_lsp(spftree, lsp, vertex->d_N, vertex->depth, ** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() ________________________________________________________________________________________________________ *** CID 1473285: Null pointer dereferences (FORWARD_NULL) /isisd/isis_lsp.c: 1909 in lsp_tick() 1903 lsp = NULL; 1904 dict_delete_free(area->lspdb[level], 1905 dnode); 1906 } 1907 1908 if (fabricd_init_c) { >>> CID 1473285: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "lsp". 1909 fabricd_sync_incomplete |= 1910 ISIS_CHECK_FLAG(lsp->SSNflags, 1911 fabricd_init_c); 1912 } 1913 } 1914 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

BGP Views
by Donald Sharp 07 Sep '18

07 Sep '18

In today's technical meeting we discussed removing the ability to have views as an option in bgp. Before we do any such thing we decided to poll the community to see if anyone is using views and if so what is the use case that they are using them under. So if you have any insight into this we would love to hear from you! Thanks! donald

4 5

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Sep '18

06 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473200: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1473200: Uninitialized variables (UNINIT) /bfdd/bfd_packet.c: 754 in bp_bfd_echo_in() 748 ssize_t rlen; 749 struct sockaddr_any local, peer; 750 char port[MAXNAMELEN + 1], vrfname[MAXNAMELEN + 1]; 751 uint8_t msgbuf[1516]; 752 753 if (sd == bglobal.bg_echo) >>> CID 1473200: Uninitialized variables (UNINIT) >>> Using uninitialized element of array "port" when calling "bfd_recv_ipv4". 754 rlen = bfd_recv_ipv4(sd, msgbuf, sizeof(msgbuf), ttl, port, 755 sizeof(port), vrfname, sizeof(vrfname), 756 &local, &peer); 757 else 758 rlen = bfd_recv_ipv6(sd, msgbuf, sizeof(msgbuf), ttl, port, 759 sizeof(port), vrfname, sizeof(vrfname), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 06 Sep '18

06 Sep '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473199: (DEADCODE) /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() ________________________________________________________________________________________________________ *** CID 1473199: (DEADCODE) /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() 4239 } else { 4240 tmp_seq = n->rem_seq; 4241 n_type = "remote"; 4242 } 4243 if (seq < tmp_seq) { 4244 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1473199: (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Ignore remote M...". 4245 zlog_debug("Ignore remote MACIP ADD VNI %u MAC %s%s%s as existing %s Neigh has higher seq %u", 4246 vni, 4247 prefix_mac2str(macaddr, 4248 buf, sizeof(buf)), 4249 ipa_len ? " IP " : "", 4250 ipa_len ? /zebra/zebra_vxlan.c: 4245 in process_remote_macip_add() 4239 } else { 4240 tmp_seq = n->rem_seq; 4241 n_type = "remote"; 4242 } 4243 if (seq < tmp_seq) { 4244 if (IS_ZEBRA_DEBUG_VXLAN) >>> CID 1473199: (DEADCODE) >>> Execution cannot reach the expression """" inside this statement: "zlog_debug("Ignore remote M...". 4245 zlog_debug("Ignore remote MACIP ADD VNI %u MAC %s%s%s as existing %s Neigh has higher seq %u", 4246 vni, 4247 prefix_mac2str(macaddr, 4248 buf, sizeof(buf)), 4249 ipa_len ? " IP " : "", 4250 ipa_len ? ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Request for slack invite.
by Naveen Thanikachalam 03 Sep '18

03 Sep '18

Hello, I’d like to subscribe to the FRRouting slack workspace. Kindly send me an invitation. -Naveen T

1 0

duplicate frr in source tar name
by Michal Ruprich 31 Aug '18

31 Aug '18

Hi, is there any specific reason for naming every source file frr-frr-x.y.z? Why using the name frr twice? Regards, Michal Ruprich

2 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Aug '18

30 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473090: Incorrect expression (NO_EFFECT) /lib/frr_pthread.c: 335 in fpt_run() ________________________________________________________________________________________________________ *** CID 1473090: Incorrect expression (NO_EFFECT) /lib/frr_pthread.c: 335 in fpt_run() 329 int sleeper[2]; 330 pipe(sleeper); 331 thread_add_read(fpt->master, &fpt_dummy, NULL, sleeper[0], NULL); 332 333 fpt->master->handle_signals = false; 334 >>> CID 1473090: Incorrect expression (NO_EFFECT) >>> Comparing an array to null is not useful: "fpt->os_name", since the test will always evaluate as true. 335 if (fpt->os_name) 336 frr_pthread_set_name(fpt, NULL, fpt->os_name); 337 338 frr_pthread_notify_running(fpt); 339 340 struct thread task; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 29 Aug '18

29 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) /lib/ferr.c: 151 in log_ref_display() ________________________________________________________________________________________________________ *** CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) /lib/ferr.c: 151 in log_ref_display() 145 char pbuf[256]; 146 char ubuf[256]; 147 148 snprintf(pbuf, sizeof(pbuf), "\nError %"PRIu32" - %s", 149 ref->code, ref->title); 150 memset(ubuf, '=', strlen(pbuf)); >>> CID 1473088: Memory - corruptions (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "strlen(pbuf) - 1UL" used as array index. 151 ubuf[strlen(pbuf) - 1] = '\0'; 152 153 vty_out(vty, "%s\n%s\n", pbuf, ubuf); 154 vty_out(vty, "Description:\n%s\n\n", ref->description); 155 vty_out(vty, "Recommendation:\n%s\n", ref->suggestion); 156 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Aug '18

26 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 10 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 10 of 10 defect(s) ** CID 1473047: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8683 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473047: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8683 in route_vty_out_detail_header() 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) >>> CID 1473047: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...". 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) ** CID 1473046: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8677 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473046: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8677 in route_vty_out_detail_header() 8671 vty_out(vty, ", no best path"); 8672 8673 if (accept_own) 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) >>> CID 1473046: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...". 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) ** CID 1473045: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8695 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473045: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8695 in route_vty_out_detail_header() 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) >>> CID 1473045: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", accept loca...". 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) 8698 vty_out(vty, ", inform peer to blackhole prefix"); 8699 else if (no_export) 8700 vty_out(vty, ", not advertised to EBGP peer"); ** CID 1473044: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8689 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473044: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8689 in route_vty_out_detail_header() 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) >>> CID 1473044: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...". 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) ** CID 1473043: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8680 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473043: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8680 in route_vty_out_detail_header() 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) >>> CID 1473043: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...". 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) ** CID 1473042: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8698 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473042: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8698 in route_vty_out_detail_header() 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) >>> CID 1473042: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", inform peer...". 8698 vty_out(vty, ", inform peer to blackhole prefix"); 8699 else if (no_export) 8700 vty_out(vty, ", not advertised to EBGP peer"); 8701 else if (no_advertise) 8702 vty_out(vty, ", not advertised to any peer"); 8703 else if (local_as) ** CID 1473041: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8692 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473041: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8692 in route_vty_out_detail_header() 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) >>> CID 1473041: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...". 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) ** CID 1473040: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8686 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473040: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8686 in route_vty_out_detail_header() 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) >>> CID 1473040: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...". 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) ** CID 1473039: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8706 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473039: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8706 in route_vty_out_detail_header() 8700 vty_out(vty, ", not advertised to EBGP peer"); 8701 else if (no_advertise) 8702 vty_out(vty, ", not advertised to any peer"); 8703 else if (local_as) 8704 vty_out(vty, ", not advertised outside local AS"); 8705 else if (no_peer) >>> CID 1473039: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", inform EBGP...". 8706 vty_out(vty, 8707 ", inform EBGP peer not to advertise to their EBGP peers"); 8708 8709 if (suppress) 8710 vty_out(vty, 8711 ", Advertisements suppressed by an aggregate."); ** CID 1473038: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8674 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473038: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8674 in route_vty_out_detail_header() 8668 ? "Default-IP-Routing-Table" 8669 : bgp->name); 8670 } else 8671 vty_out(vty, ", no best path"); 8672 8673 if (accept_own) >>> CID 1473038: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", accept own ...". 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

2 1

FYI - Regarding CPP_NOTICE firing today if building w/ --enable-dev-build=yes
by Donald Sharp 24 Aug '18

24 Aug '18

If you are building w/ --enable-dev-build=yes and are seeing CPP_NOTICE's: zapi_ipv4_route, zapi_ipv6_route, zapi_ipv4_route_ipv6_nexthop as well as the zapi_ipv4 and zapi_ipv6 data structures should be removed now Please do a git pull to retrieve PR # 2901: commit 9b8c3903bdf0f681df17a532286bc717e1f607ad Merge: 529089b 0477276 Author: David Lamparter <equinox(a)diac24.net> Date: Fri Aug 24 19:41:17 2018 +0200 Merge pull request #2901 from donaldsharp/remove_zapi_deprecated Remove zapi deprecated This will go away then. The next scheduled CONFDATE is in a few days btw: ospf6d/ospf6_top.c:#if CONFDATE > 20180828 We should have something ready to go in on that date as well. donald

1 0