- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Aug '18

26 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 10 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 10 of 10 defect(s) ** CID 1473047: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8683 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473047: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8683 in route_vty_out_detail_header() 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) >>> CID 1473047: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...". 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) ** CID 1473046: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8677 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473046: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8677 in route_vty_out_detail_header() 8671 vty_out(vty, ", no best path"); 8672 8673 if (accept_own) 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) >>> CID 1473046: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark transl...". 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) ** CID 1473045: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8695 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473045: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8695 in route_vty_out_detail_header() 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) >>> CID 1473045: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", accept loca...". 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) 8698 vty_out(vty, ", inform peer to blackhole prefix"); 8699 else if (no_export) 8700 vty_out(vty, ", not advertised to EBGP peer"); ** CID 1473044: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8689 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473044: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8689 in route_vty_out_detail_header() 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) >>> CID 1473044: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...". 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) ** CID 1473043: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8680 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473043: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8680 in route_vty_out_detail_header() 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) >>> CID 1473043: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...". 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) ** CID 1473042: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8698 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473042: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8698 in route_vty_out_detail_header() 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) >>> CID 1473042: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", inform peer...". 8698 vty_out(vty, ", inform peer to blackhole prefix"); 8699 else if (no_export) 8700 vty_out(vty, ", not advertised to EBGP peer"); 8701 else if (no_advertise) 8702 vty_out(vty, ", not advertised to any peer"); 8703 else if (local_as) ** CID 1473041: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8692 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473041: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8692 in route_vty_out_detail_header() 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) >>> CID 1473041: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", mark routes...". 8692 vty_out(vty, 8693 ", mark routes to not be treated according to Long-lived BGP Graceful Restart operations"); 8694 else if (accept_own_nexthop) 8695 vty_out(vty, 8696 ", accept local nexthop"); 8697 else if (blackhole) ** CID 1473040: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8686 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473040: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8686 in route_vty_out_detail_header() 8680 vty_out(vty, 8681 ", attach RT as-is for VPNv4 route filtering"); 8682 else if (route_filter_translated_v6) 8683 vty_out(vty, 8684 ", mark translated RTs for VPNv6 route filtering"); 8685 else if (route_filter_v6) >>> CID 1473040: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", attach RT a...". 8686 vty_out(vty, 8687 ", attach RT as-is for VPNv6 route filtering"); 8688 else if (llgr_stale) 8689 vty_out(vty, 8690 ", mark routes to be retained for a longer time. Requeres support for Long-lived BGP Graceful Restart"); 8691 else if (no_llgr) ** CID 1473039: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8706 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473039: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8706 in route_vty_out_detail_header() 8700 vty_out(vty, ", not advertised to EBGP peer"); 8701 else if (no_advertise) 8702 vty_out(vty, ", not advertised to any peer"); 8703 else if (local_as) 8704 vty_out(vty, ", not advertised outside local AS"); 8705 else if (no_peer) >>> CID 1473039: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", inform EBGP...". 8706 vty_out(vty, 8707 ", inform EBGP peer not to advertise to their EBGP peers"); 8708 8709 if (suppress) 8710 vty_out(vty, 8711 ", Advertisements suppressed by an aggregate."); ** CID 1473038: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8674 in route_vty_out_detail_header() ________________________________________________________________________________________________________ *** CID 1473038: Possible Control flow issues (DEADCODE) /bgpd/bgp_route.c: 8674 in route_vty_out_detail_header() 8668 ? "Default-IP-Routing-Table" 8669 : bgp->name); 8670 } else 8671 vty_out(vty, ", no best path"); 8672 8673 if (accept_own) >>> CID 1473038: Possible Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, ", accept own ...". 8674 vty_out(vty, 8675 ", accept own local route exported and imported in different VRF"); 8676 else if (route_filter_translated_v4) 8677 vty_out(vty, 8678 ", mark translated RTs for VPNv4 route filtering"); 8679 else if (route_filter_v4) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

2 1

FYI - Regarding CPP_NOTICE firing today if building w/ --enable-dev-build=yes
by Donald Sharp 24 Aug '18

24 Aug '18

If you are building w/ --enable-dev-build=yes and are seeing CPP_NOTICE's: zapi_ipv4_route, zapi_ipv6_route, zapi_ipv4_route_ipv6_nexthop as well as the zapi_ipv4 and zapi_ipv6 data structures should be removed now Please do a git pull to retrieve PR # 2901: commit 9b8c3903bdf0f681df17a532286bc717e1f607ad Merge: 529089b 0477276 Author: David Lamparter <equinox(a)diac24.net> Date: Fri Aug 24 19:41:17 2018 +0200 Merge pull request #2901 from donaldsharp/remove_zapi_deprecated Remove zapi deprecated This will go away then. The next scheduled CONFDATE is in a few days btw: ospf6d/ospf6_top.c:#if CONFDATE > 20180828 We should have something ready to go in on that date as well. donald

1 0

Continued Discussion of Error Codes for FRR
by Donald Sharp 23 Aug '18

23 Aug '18

All - In today's technical meeting we spent quite a bit of time discussing David's error code PR: https://github.com/FRRouting/frr/pull/2841 Discussion centered around understanding out what it was and how we want FRR to work with error codes. Due to time constraints we decided to continue the discussion in a new meeting. This meeting will be held on Aug 22, 9:30 am EDT tomorrow. If you are interested please let me know and I'll add you to the meeting. donald

2 4

Next Release
by Donald Sharp 23 Aug '18

23 Aug '18

All - In today's dev meeting we discussed the October release of FRR (https://github.com/FRRouting/frr/blob/master/doc/developer/workflow.rst Releases subsection ). In order to meet this deadline we will need to pull the next branch. The current plan is to do this on Aug 28. At this time we are expecting to call this release 6.0. thanks! donald

1 1

A route-map scaling improvement that has just gone in.
by Donald Sharp 22 Aug '18

22 Aug '18

All - This morning, PR #2818 (https://github.com/FRRouting/frr/pulls/2818) was merged into the FRR master code base. This fixes Issue #2493(https://github.com/FRRouting/frr/issues/2493), where zebra was causing significant processing for route-map changes being made to the system in both BGP and Zebra. Here are some timings: Pre-route-map #2818 improvements for ZEBRA: ZEBRA: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 12 22568.749 121924 185 160855 162 414190 RWTEX TOTAL BGP: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 10 31159.647 121679 256 117558 220 117713 RWTEX TOTAL Create a Unused route-map: robot# conf t robot(config)# route-map BLAR permit 10 robot(config-route-map)# end ZEBRA: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 12 40671.587 136545 297 214461 226 414190 RWTEX TOTAL BGP: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 10 32043.610 122392 261 117558 227 117713 RWTEX TOTAL This is aproximately 19 cpu seconds split between BGP and zebra to handle a full BGP feed for a route-map change that no-process is currently using. After-route-map (#2818) improvements for ZEBRA: ZEBRA: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 11 11592.894 1216075 9 152939 5 120621 RWTEX TOTAL BGP: Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 9 8306.451 40216 206 116589 193 116801 RWTEX TOTAL Create a Unused route-map: robot# conf t robot(config)# route-map BLAR permit 10 robot(config-route-map)# end Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 11 11596.799 1216183 9 152939 5 120621 RWTEX TOTAL Total thread statistics ------------------------- CPU (user+system): Real (wall-clock): Active Runtime(ms) Invoked Avg uSec Max uSecs Avg uSec Max uSecs Type Thread 9 8320.976 40365 206 116589 193 116801 RWTEX TOTAL This adds up to negligible amounts of cpu time. This is a wonderful improvement in processing of route-map changes for zebra( and consequentially for bgp ). I'd like to thank Soman for doing this work. thanks! donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 22 Aug '18

22 Aug '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1472966: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_pbr.c: 1887 in bgp_pbr_policyroute_add_to_zebra_unit() ________________________________________________________________________________________________________ *** CID 1472966: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_pbr.c: 1887 in bgp_pbr_policyroute_add_to_zebra_unit() 1881 } 1882 1883 /* ipset create */ 1884 if (bpm && !bpm->installed) 1885 bgp_send_pbr_ipset_match(bpm, true); 1886 /* ipset add */ >>> CID 1472966: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "bpme" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1887 if (bpme && !bpme->installed) 1888 bgp_send_pbr_ipset_entry_match(bpme, true); 1889 1890 /* iptables */ 1891 if (bpm && !bpm->installed_in_iptable) 1892 bgp_send_pbr_iptable(bpa, bpm, true); ** CID 1472965: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_pbr.c: 1884 in bgp_pbr_policyroute_add_to_zebra_unit() ________________________________________________________________________________________________________ *** CID 1472965: Null pointer dereferences (REVERSE_INULL) /bgpd/bgp_pbr.c: 1884 in bgp_pbr_policyroute_add_to_zebra_unit() 1878 bgp_send_pbr_rule_action(bpa, true); 1879 bgp_zebra_announce_default(bgp, nh, 1880 AFI_IP, bpa->table_id, true); 1881 } 1882 1883 /* ipset create */ >>> CID 1472965: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "bpm" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1884 if (bpm && !bpm->installed) 1885 bgp_send_pbr_ipset_match(bpm, true); 1886 /* ipset add */ 1887 if (bpme && !bpme->installed) 1888 bgp_send_pbr_ipset_entry_match(bpme, true); 1889 ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

ospfclient and ospf_api_server
by Donald Sharp 21 Aug '18

21 Aug '18

All - Is anyone using this code? It was put into place in the 2003 timeframe and from a quick look at the git logs for the files since then I see 2 actual bug fixes, one in 2005 and one in 2013( to fix a CVE ). I cannot imagine that with the plethora of changes to ospf since then and some of the other concerns outlined to me (namely 1500 byte limit on opaque_lsa ) that this functionality provides anything useful. Is anyone planning on using this or see a need to keep this code? donald

3 2

vrf-lite support in linux
by Himanshu S 17 Aug '18

17 Aug '18

Hi, I am trying out the vrf-lite ( https://www.kernel.org/doc/Documentation/networking/vrf.txt) on ubuntu 16.04.1 (kernel version 4.15). I am able to try it out on virtual box vm. When I try to do the same on Ubuntu 16.04 image on AWS marketplace, adding vrf-lite through ip link command doesn't work. Seems like its not supported. Anyone tried it? TIA Himanshu

2 1

Invitation for slack channel
by Himanshu S 17 Aug '18

17 Aug '18

Could you please get an invite?

2 1

FRR support for FPM
by Mayank Tiwari 15 Aug '18

15 Aug '18

Hi, We are using quagga in our solution for FPM connection and Reverse FPM connection with ONOS. In order to support BFD feature I need to upgrade from quagga to FRR. For that I was patching the changes present in quagga to FRR. During that patching process the following patch is causing compilation issue: diff --git a/zebra/zebra_vty.c b/zebra/zebra_vty.c index 43d76a6..03c4a6b 100644 --- a/zebra/zebra_vty.c +++ b/zebra/zebra_vty.c @@ -20,6 +20,7 @@ #include <zebra.h> +#include "zebra_fpm.h" #include "memory.h" #include "zebra_memory.h" #include "if.h" + +/* function to write the fpm config info */ +static int config_write_fpm (struct vty *vty) +{ + return fpm_remote_srv_write (vty); +} + +/* Zebra node */ +static struct cmd_node zebra_node = +{ + ZEBRA_NODE, + "", + 1 +}; /* Route VTY. */ void zebra_vty_init(void) { /* Install configuration write function. */ install_node(&table_node, config_write_table); install_node(&forwarding_node, config_write_forwarding); + install_node (&zebra_node, config_write_fpm); install_element(VIEW_NODE, &show_ip_forwarding_cmd); install_element(CONFIG_NODE, &ip_forwarding_cmd); diff --git a/zebra/zebra_fpm.h b/zebra/zebra_fpm.h new file mode 100644 index 0000000..9291ffa --- /dev/null +++ b/zebra/zebra_fpm.h @@ -0,0 +1,35 @@ +/* + * Router ID for zebra daemon. + * + * Copyright (C) 2004 James R. Leu + * + * This file is part of Quagga routing suite. + * + * Quagga is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2, or (at your option) any + * later version. + * + * Quagga is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; see the file COPYING; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef _ZEBRA_VTY_H_ +#define _ZEBRA_VTY_H_ + +#include <zebra.h> +#include "memory.h" +#include "prefix.h" +#include "zclient.h" +#include "if.h" + + +static int fpm_remote_srv_write (struct vty *vty ); + +#endif The function 'fpm_remote_srv_write' is already defined in zebra_fpm.c file which I need to use zebra_vty.c file. I have created a header with name zebra_fpm.h and declared that function there and later included this header in zebra_vty.c. The compilation of zebra_vty.c fails as it is not able to find 'fpm_remote_srv_write' function This is the compilation error: CCLD zebra/zebra_irdp.la CC zebra/zebra_fpm.lo CC zebra/zebra_fpm_netlink.lo ….. ….. CC zebra/zebra_vty.o In file included from zebra/zebra_vty.c:23:0: zebra/zebra_fpm.h:33:12: warning: 'fpm_remote_srv_write' used but never defined static int fpm_remote_srv_write (struct vty *vty ); ^ CC zebra/zebra_vxlan.o CC zebra/zserv.o CC zebra/zebra_netns_id.o CC zebra/zebra_netns_notify.o CC zebra/table_manager.o CC zebra/zapi_msg.o CCLD zebra/zebra zebra/zebra_vty.o: In function `config_write_fpm': /frr/zebra/zebra_vty.c:3697: undefined reference to `fpm_remote_srv_write' collect2: error: ld returned 1 exit status make[2]: *** [zebra/zebra] Error 1 Makefile:3246: recipe for target 'zebra/zebra' failed make[2]: Leaving directory '/frr' Makefile:4421: recipe for target 'all-recursive' failed make[1]: Leaving directory '/frr' make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 I have observed that zebra_fpm.c is compiled as zebra_fpm.lo instead of zebra_fpm.o. I am not sure if that can cause this issue. Please suggest what I am missing here and what approach I need to take to fix this issue. Thanks and Regards, Mayank

2 4