- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 11 Jun '18

11 Jun '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 6 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 1469898: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1469898: Uninitialized variables (UNINIT) /lib/command.c: 270 in argv_concat() 264 int cnt = argc - shift; 265 const char *argstr[cnt]; 266 267 for (int i = 0; i < cnt; i++) 268 argstr[i] = argv[i + shift]->arg; 269 >>> CID 1469898: Uninitialized variables (UNINIT) >>> Using uninitialized element of array "argstr" when calling "frrstr_join". 270 return frrstr_join(argstr, cnt, " "); 271 } 272 273 vector cmd_make_strvec(const char *string) 274 { 275 if (!string) ** CID 1469897: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 6978 in route_vty_out_tag() ________________________________________________________________________________________________________ *** CID 1469897: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 6978 in route_vty_out_tag() 6972 } else if (attr->mp_nexthop_len 6973 == BGP_ATTR_NHLEN_IPV6_GLOBAL_AND_LL) { 6974 if (json) { 6975 inet_ntop(AF_INET6, 6976 &attr->mp_nexthop_global, 6977 buf_a, BUFSIZ); >>> CID 1469897: Memory - corruptions (OVERRUN) >>> Overrunning array "buf_b" of 512 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192U". 6978 inet_ntop(AF_INET6, 6979 &attr->mp_nexthop_local, 6980 buf_b, BUFSIZ); 6981 sprintf(buf_c, "%s(%s)", buf_a, buf_b); 6982 json_object_string_add( 6983 json_out, ** CID 1469896: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1469896: Null pointer dereferences (FORWARD_NULL) /vtysh/vtysh.c: 556 in vtysh_execute_func() 550 551 if (vline == NULL && vty->is_paged) { 552 vty_close_pager(vty); 553 return CMD_SUCCESS; 554 } 555 >>> CID 1469896: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "vline" to "cmd_execute_command", which dereferences it. 556 ret = cmd_execute_command(vline, vty, &cmd, 1); 557 cmd_free_strvec(vline); 558 if (ret != CMD_SUCCESS_DAEMON) 559 break; 560 } else if (cmd->func) { 561 (*cmd->func)(cmd, vty, 0, NULL); ** CID 1469895: Null pointer dereferences (FORWARD_NULL) /lib/vty.c: 129 in vty_set_include() ________________________________________________________________________________________________________ *** CID 1469895: Null pointer dereferences (FORWARD_NULL) /lib/vty.c: 129 in vty_set_include() 123 if (!regexp && vty->filter) { 124 regfree(&vty->include); 125 vty->filter = false; 126 return true; 127 } 128 >>> CID 1469895: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "regexp" to "regcomp", which dereferences it. 129 errcode = regcomp(&vty->include, regexp, 130 REG_EXTENDED | REG_NEWLINE | REG_NOSUB); 131 if (errcode) { 132 ret = false; 133 regerror(ret, &vty->include, errbuf, sizeof(errbuf)); 134 vty_out(vty, "%% Regex compilation error: %s", errbuf); ** CID 1469894: Null pointer dereferences (NULL_RETURNS) /lib/command.c: 1216 in handle_pipe_action() ________________________________________________________________________________________________________ *** CID 1469894: Null pointer dereferences (NULL_RETURNS) /lib/command.c: 1216 in handle_pipe_action() 1210 1211 if (!succ) { 1212 vty_out(vty, "%% Bad regexp '%s'\n", regexp); 1213 goto fail; 1214 } 1215 *cmd_out = XSTRDUP(MTYPE_TMP, cmd_in); >>> CID 1469894: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "strstr(*cmd_out, "|")". 1216 *(strstr(*cmd_out, "|")) = '\0'; 1217 } else { 1218 vty_out(vty, "%% Unknown action '%s'\n", token); 1219 goto fail; 1220 } 1221 ** CID 1469893: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 6975 in route_vty_out_tag() ________________________________________________________________________________________________________ *** CID 1469893: Memory - corruptions (OVERRUN) /bgpd/bgp_route.c: 6975 in route_vty_out_tag() 6969 AF_INET6, 6970 &attr->mp_nexthop_global, 6971 buf_a, BUFSIZ)); 6972 } else if (attr->mp_nexthop_len 6973 == BGP_ATTR_NHLEN_IPV6_GLOBAL_AND_LL) { 6974 if (json) { >>> CID 1469893: Memory - corruptions (OVERRUN) >>> Overrunning array "buf_a" of 512 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192U". 6975 inet_ntop(AF_INET6, 6976 &attr->mp_nexthop_global, 6977 buf_a, BUFSIZ); 6978 inet_ntop(AF_INET6, 6979 &attr->mp_nexthop_local, 6980 buf_b, BUFSIZ); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Slack invite
by Paco Aragon 31 May '18

31 May '18

Hi, I'm starting using the topotests for adding a test, and I would like to get a Slack invite for paco(a)voltanet.io , if possible (I saw invitation requests in the list, so I'm doing the same, please excuse the inconvenience) Thank you in advance :-) Paco

2 1

slack channel invite
by Yuriy Andamasov 30 May '18

30 May '18

Hello! Can we have invites to slack channel for yuriy(a)sentrium.io daniil(a)sentrium.io Thanks!

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 May '18

30 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() ________________________________________________________________________________________________________ *** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() 237 * for now, only match/set supported is 238 * - combination src/dst => redirect nexthop [ + rate] 239 * - combination src/dst => redirect VRF [ + rate] 240 * - combination src/dst => drop 241 * - combination srcport + @IP 242 */ >>> CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) >>> The expression "api->match_icmp_type_num || api->match_icmp_type_num" does not accomplish anything because it evaluates to either of its identical operands, "api->match_icmp_type_num". 243 if (api->match_icmp_type_num || api->match_icmp_type_num 244 || api->match_packet_length_num || api->match_dscp_num 245 || api->match_tcpflags_num) { 246 if (BGP_DEBUG(pbr, PBR)) { 247 bgp_pbr_print_policy_route(api); 248 zlog_debug("BGP: some SET actions not supported by Zebra. ignoring."); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Northbound API - Presentation this Friday
by Renato Westphal 23 May '18

23 May '18

Hi all, This Friday (18/May - 8am PST) I'll be making a presentation about my proposal to introduce a YANG-based northbound API in FRR. The main goal of this work is to provide a better interface to configure and monitor FRR programmatically. Everyone is welcomed to attend, no invitations needed. Link of the conference call: https://bluejeans.com/9192742159/ Best Regards, Renato.

2 4

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 May '18

18 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1469172: Error handling issues (CHECKED_RETURN) /bgpd/bgp_route.c: 2551 in bgp_maximum_prefix_restart_timer() ________________________________________________________________________________________________________ *** CID 1469172: Error handling issues (CHECKED_RETURN) /bgpd/bgp_route.c: 2551 in bgp_maximum_prefix_restart_timer() 2545 2546 if (bgp_debug_neighbor_events(peer)) 2547 zlog_debug( 2548 "%s Maximum-prefix restart timer expired, restore peering", 2549 peer->host); 2550 >>> CID 1469172: Error handling issues (CHECKED_RETURN) >>> Calling "peer_clear" without checking return value (as is done elsewhere 5 out of 6 times). 2551 peer_clear(peer, NULL); 2552 2553 return 0; 2554 } 2555 2556 int bgp_maximum_prefix_overflow(struct peer *peer, afi_t afi, safi_t safi, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

05/15/18 Technical Meeting Notes
by Quentin Young 15 May '18

15 May '18

05/15/18 FRR Technical Meeting Notes ==================================== 5.0 Status ----------- mwinter - testing looks good, just open issues & pr's that need to go into 5.0; will retest again when we have a release candidate Issues ------ #2201 - Doesn't seem like many people use this anymore; assigned mwinter #2204 - Partially fixed; needs unrelated changes to fully fix it; assigned dslice #2205 - User question; donaldsharp to update documentation #2228 - Assigned qlyoung #2206 - Fixed by #2226 (open) #2230 - Assigned donaldsharp #2232 - qlyoung & pguibert6WIND to discuss in slack #2233 - Question answered & closed, following up with Olson for further thoughts #2235 - Assigned pguibert6WIND for furhter investigation #2155 - cfra: haven't had time to work on it yet #2163 - donaldsharp will scrub #2147 - Various fixes, 4.0 should be fixed, pending fix for 5.0 to be reviewed by donaldsharp Pull Requests ------------- #1853 - rzalamena: manpage & documentation added, still open for review #2025 - Closed due to security and architectural concerns. Possibly revisit in the future w/ an architecture to segment the code away from FRR core. #2041 - Waiting on repsonse from vincentbernat #2034 - Waiting on response from vincentbernat #2144 - Merged #2122 - Some issues with state synchronization between staticd and zebra #2142 - donaldsharp to review #2186 - qlyoung to go look at how other projects handle packaging for multiple platforms & report back with better solution; closed #2198 - Fixes #2196, solution could be improved in the future; lberger to file issue to track better solution; donaldsharp to merge this one #2200 - rwestphal, mwinter to review #2210 - donaldsharp will rework patch and resubmit #2220 - lberger to try it again and report back, -ldl should not be necessary #2224 - cherry-pick, waiting on merge #2226 - qlyoung, donaldsharp to review #2231 - donaldsharp to review

1 0

Slack invite
by Wilhelm Wijkander 15 May '18

15 May '18

Would appreciate one... Regards, Wilhelm Wijkander

2 1

Request for Slack invite
by Simon Leinen 14 May '18

14 May '18

I'd like to participate in the FRRouting Slack channel. Our team uses FRR (Ubuntu/Docker/Cumulus versions) on most of our servers and switches. Thanks in advance! -- Simon.

2 1

Slack invite please
by Bruno Rijsman 14 May '18

14 May '18

Can I get a Slack invite please — Bruno

2 2