- dev - lists.frrouting.org

slack channel invite
by Yuriy Andamasov 29 May '18

29 May '18

Hello! Can we have invites to slack channel for yuriy(a)sentrium.io daniil(a)sentrium.io Thanks!

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 29 May '18

29 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() ________________________________________________________________________________________________________ *** CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) /bgpd/bgp_pbr.c: 243 in bgp_pbr_validate_policy_route() 237 * for now, only match/set supported is 238 * - combination src/dst => redirect nexthop [ + rate] 239 * - combination src/dst => redirect VRF [ + rate] 240 * - combination src/dst => drop 241 * - combination srcport + @IP 242 */ >>> CID 1469463: Incorrect expression (CONSTANT_EXPRESSION_RESULT) >>> The expression "api->match_icmp_type_num || api->match_icmp_type_num" does not accomplish anything because it evaluates to either of its identical operands, "api->match_icmp_type_num". 243 if (api->match_icmp_type_num || api->match_icmp_type_num 244 || api->match_packet_length_num || api->match_dscp_num 245 || api->match_tcpflags_num) { 246 if (BGP_DEBUG(pbr, PBR)) { 247 bgp_pbr_print_policy_route(api); 248 zlog_debug("BGP: some SET actions not supported by Zebra. ignoring."); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Northbound API - Presentation this Friday
by Renato Westphal 23 May '18

23 May '18

Hi all, This Friday (18/May - 8am PST) I'll be making a presentation about my proposal to introduce a YANG-based northbound API in FRR. The main goal of this work is to provide a better interface to configure and monitor FRR programmatically. Everyone is welcomed to attend, no invitations needed. Link of the conference call: https://bluejeans.com/9192742159/ Best Regards, Renato.

2 4

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 May '18

18 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1469172: Error handling issues (CHECKED_RETURN) /bgpd/bgp_route.c: 2551 in bgp_maximum_prefix_restart_timer() ________________________________________________________________________________________________________ *** CID 1469172: Error handling issues (CHECKED_RETURN) /bgpd/bgp_route.c: 2551 in bgp_maximum_prefix_restart_timer() 2545 2546 if (bgp_debug_neighbor_events(peer)) 2547 zlog_debug( 2548 "%s Maximum-prefix restart timer expired, restore peering", 2549 peer->host); 2550 >>> CID 1469172: Error handling issues (CHECKED_RETURN) >>> Calling "peer_clear" without checking return value (as is done elsewhere 5 out of 6 times). 2551 peer_clear(peer, NULL); 2552 2553 return 0; 2554 } 2555 2556 int bgp_maximum_prefix_overflow(struct peer *peer, afi_t afi, safi_t safi, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

05/15/18 Technical Meeting Notes
by Quentin Young 15 May '18

15 May '18

05/15/18 FRR Technical Meeting Notes ==================================== 5.0 Status ----------- mwinter - testing looks good, just open issues & pr's that need to go into 5.0; will retest again when we have a release candidate Issues ------ #2201 - Doesn't seem like many people use this anymore; assigned mwinter #2204 - Partially fixed; needs unrelated changes to fully fix it; assigned dslice #2205 - User question; donaldsharp to update documentation #2228 - Assigned qlyoung #2206 - Fixed by #2226 (open) #2230 - Assigned donaldsharp #2232 - qlyoung & pguibert6WIND to discuss in slack #2233 - Question answered & closed, following up with Olson for further thoughts #2235 - Assigned pguibert6WIND for furhter investigation #2155 - cfra: haven't had time to work on it yet #2163 - donaldsharp will scrub #2147 - Various fixes, 4.0 should be fixed, pending fix for 5.0 to be reviewed by donaldsharp Pull Requests ------------- #1853 - rzalamena: manpage & documentation added, still open for review #2025 - Closed due to security and architectural concerns. Possibly revisit in the future w/ an architecture to segment the code away from FRR core. #2041 - Waiting on repsonse from vincentbernat #2034 - Waiting on response from vincentbernat #2144 - Merged #2122 - Some issues with state synchronization between staticd and zebra #2142 - donaldsharp to review #2186 - qlyoung to go look at how other projects handle packaging for multiple platforms & report back with better solution; closed #2198 - Fixes #2196, solution could be improved in the future; lberger to file issue to track better solution; donaldsharp to merge this one #2200 - rwestphal, mwinter to review #2210 - donaldsharp will rework patch and resubmit #2220 - lberger to try it again and report back, -ldl should not be necessary #2224 - cherry-pick, waiting on merge #2226 - qlyoung, donaldsharp to review #2231 - donaldsharp to review

1 0

Slack invite
by Wilhelm Wijkander 15 May '18

15 May '18

Would appreciate one... Regards, Wilhelm Wijkander

2 1

Request for Slack invite
by Simon Leinen 14 May '18

14 May '18

I'd like to participate in the FRRouting Slack channel. Our team uses FRR (Ubuntu/Docker/Cumulus versions) on most of our servers and switches. Thanks in advance! -- Simon.

2 1

Slack invite please
by Bruno Rijsman 14 May '18

14 May '18

Can I get a Slack invite please — Bruno

2 2

Today's Technical Meeting Agenda
by Philippe Guibert 08 May '18

08 May '18

Hi all, For todays call, there will be a discussion about Yang based management. Which approach should be taken to enhance Yang int FRRouting. We, at 6WIND would like to share with you our feedback about Yang approach, and the issues identified. You can find the link below for more information. https://docs.google.com/presentation/d/1rVCpH2VI1TnkAzZInlDUHAp9Zo4PjjzY9qz… Thanks, Philippe

7 18

notes from frr api discussion, 5/4/18
by Mark Stapp 04 May '18

04 May '18

Donald organized a conference call to focus on management and api issues. He suggested that I send around my notes, to give folks some overview of the discussion. I don't have a full attendee list, I'm sorry to say. And of course, if I've misrepresented something that someone said, please feel free to correct "the record"... * preso from 6Wind about their use of vty ** using xml transport between their own mgmt system and converting to vty ** command ordering an issue in cli/vty, as is feedback/validation ** planning to go forward with a yang-based schema, want api access, believe cli and api need to be converged as a single path ** Q from Donald: how do you handle shared objects, like route-map, acl, and prefix-list. "it's important that whatever solution we have understands that we have some shared/universal data" ** Renato W. gave a verbal overview of his 'northbound' proposal that has been mentioned on the regular dev call and in the yang slack channel; he will present slides and details soon we tried to list a few higher-level points : * attributes or objects? are we configuring individual attributes, or entire objects (or lists of objects)? * validation/handling logic inside daemons: what do they need to be able to do internally to ensure correctness, and what can be done by model-level validation (a benefit of models)? * sync vs. async (for transport, and for interaction with the daemon code) * shared/global objects (along the lines of Donald's point from earlier) * locking (per-attr? per-object? per-transaction - whatever that is?) what are the sorts of needs and expectations as we see more multi-threading in frr? * multi-admin (transactions concept): is this something that is a goal for frr, or is it the responsibility of external management systems? * impact on code (cli, running/protocol code, opportunity to auto-generate some config handler code?) * performance/mem - input of large config, paging of large data sets, e.g. * error-handling, feedback * multi-daemon, multi-process coordination (ease of daemon management, "it's really hard to set up mpls right now" [DS] ** behavior on restart among daemons, e.g. we discussed a follow-on meeting to continue the discussion, time tbd... Cheers, Mark

1 0