- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 03 May '18

03 May '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1468512: Control flow issues (DEADCODE) /bgpd/bgp_pbr.c: 234 in bgp_pbr_build_and_validate_entry() ________________________________________________________________________________________________________ *** CID 1468512: Control flow issues (DEADCODE) /bgpd/bgp_pbr.c: 234 in bgp_pbr_build_and_validate_entry() 228 ecom = info->attr->ecommunity; 229 for (i = 0; i < ecom->size; i++) { 230 ecom_eval = (struct ecommunity_val *) 231 ecom->val + (i * ECOMMUNITY_SIZE); 232 233 if (action_count > ACTIONS_MAX_NUM) { >>> CID 1468512: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "if (term_bgp_debug_pbr & 2U...". 234 if (BGP_DEBUG(pbr, PBR_ERROR)) 235 zlog_err("%s: flowspec actions exceeds limit (max %u)", 236 __func__, action_count); 237 break; 238 } 239 api_action = &api->actions[action_count]; ** CID 1468511: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468511: Null pointer dereferences (FORWARD_NULL) /pimd/pim_msdp.c: 259 in pim_msdp_sa_new() 253 sa->uptime = pim_time_monotonic_sec(); 254 255 /* insert into misc tables for easy access */ 256 sa = hash_get(pim->msdp.sa_hash, sa, hash_alloc_intern); 257 if (!sa) { 258 zlog_err("%s: PIM hash get failure", __PRETTY_FUNCTION__); >>> CID 1468511: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "sa" to "pim_msdp_sa_free", which dereferences it. 259 pim_msdp_sa_free(sa); 260 return NULL; 261 } 262 listnode_add_sort(pim->msdp.sa_list, sa); 263 264 if (PIM_DEBUG_MSDP_EVENTS) { ** CID 1468510: Null pointer dereferences (NULL_RETURNS) ________________________________________________________________________________________________________ *** CID 1468510: Null pointer dereferences (NULL_RETURNS) /ospf6d/ospf6_intra.c: 1326 in ospf6_intra_prefix_update_route_origin() 1320 struct ospf6_route *g_route, *nroute; 1321 1322 /* Update Global ospf6 route path */ 1323 g_route = ospf6_route_lookup(&oa_route->prefix, 1324 ospf6->route_table); 1325 >>> CID 1468510: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be null "g_route" when calling "ospf6_route_lock". 1326 for (ospf6_route_lock(g_route); g_route && 1327 ospf6_route_is_prefix(&oa_route->prefix, g_route); 1328 g_route = nroute) { 1329 nroute = ospf6_route_next(g_route); 1330 if (g_route->type != oa_route->type) 1331 continue; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

documentation now on the website
by Quentin Young 02 May '18

02 May '18

Hi folks, Updated documentation is now on the FRR website. User guide: https://frrouting.org/user-guide/ <https://frrouting.org/user-guide/> Developer’s guide: https://frrouting.org/dev-guide/ <https://frrouting.org/dev-guide/> This was built from the tip of master and should be accurate for the upcoming 4.0 release. Eventually I will work on a way to publish versioned documentation for each release. The developer documentation will be rolling. Thanks, Quentin

4 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Apr '18

26 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1468416: Error handling issues (CHECKED_RETURN) /bgpd/bgp_rd.c: 213 in form_auto_rd() ________________________________________________________________________________________________________ *** CID 1468416: Error handling issues (CHECKED_RETURN) /bgpd/bgp_rd.c: 213 in form_auto_rd() 207 { 208 char buf[100]; 209 210 prd->family = AF_UNSPEC; 211 prd->prefixlen = 64; 212 sprintf(buf, "%s:%hu", inet_ntoa(router_id), rd_id); >>> CID 1468416: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix_rd" without checking return value (as is done elsewhere 15 out of 16 times). 213 str2prefix_rd(buf, prd); ** CID 1468415: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468415: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 361 in af_route_map_vpn_imexport() 355 } 356 #if 0 /* anything that can fail? */ 357 if (_failcnt) 358 return CMD_WARNING; 359 #endif 360 #endif >>> CID 1468415: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap_str" to "af_route_map_vpn_imexport_magic", which dereferences it. 361 return af_route_map_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rmap_str); 362 } 363 364 /* af_import_vrf_route_map => "[no] import vrf route-map RMAP$rmap_str" */ 365 DEFUN_CMD_FUNC_DECL(af_import_vrf_route_map) 366 #define funcdecl_af_import_vrf_route_map static int af_import_vrf_route_map_magic(\ ** CID 1468414: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468414: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 409 in af_import_vrf_route_map() 403 } 404 #if 0 /* anything that can fail? */ 405 if (_failcnt) 406 return CMD_WARNING; 407 #endif 408 #endif >>> CID 1468414: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap_str" to "af_import_vrf_route_map_magic", which dereferences it. 409 return af_import_vrf_route_map_magic(self, vty, argc, argv, no, rmap_str); 410 } 411 412 /* bgp_imexport_vrf => "[no] import vrf NAME$import_name" */ 413 DEFUN_CMD_FUNC_DECL(bgp_imexport_vrf) 414 #define funcdecl_bgp_imexport_vrf static int bgp_imexport_vrf_magic(\ ** CID 1468413: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468413: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 457 in bgp_imexport_vrf() 451 } 452 #if 0 /* anything that can fail? */ 453 if (_failcnt) 454 return CMD_WARNING; 455 #endif 456 #endif >>> CID 1468413: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "import_name" to "bgp_imexport_vrf_magic", which dereferences it. 457 return bgp_imexport_vrf_magic(self, vty, argc, argv, no, import_name); 458 } 459 460 /* bgp_imexport_vpn => "[no] <import|export>$direction_str vpn" */ 461 DEFUN_CMD_FUNC_DECL(bgp_imexport_vpn) 462 #define funcdecl_bgp_imexport_vpn static int bgp_imexport_vpn_magic(\ ** CID 1465490: Error handling issues (CHECKED_RETURN) /pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req() ________________________________________________________________________________________________________ *** CID 1465490: Error handling issues (CHECKED_RETURN) /pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req() 811 } 812 /* 813 * 6.4 Forwarding Traceroute Requests: 814 * Previous-hop router not known, 815 * packet is sent to an appropriate multicast address 816 */ >>> CID 1465490: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 115 out of 117 times). 817 inet_aton(MCAST_ALL_ROUTERS, &nh_addr); 818 } 819 820 /* 6.2.2 8. If this router is the Rendez-vous Point */ 821 if (pim_rp_i_am_rp(pim, mtracep->grp_addr)) { 822 mtrace_rsp_set_fwd_code(rspp, MTRACE_FWD_CODE_REACHED_RP); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Invite to FRRouting slack
by quentusrex＠gmail.com 24 Apr '18

24 Apr '18

My name is William King, CTO of Flowroute located in Seattle, WA. Looking to evaluate migrating from BIRD to FRRouting, and better connect with the community. -William

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Apr '18

20 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1468032: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468032: Null pointer dereferences (FORWARD_NULL) /pbrd/pbr_vty_clippy.c: 217 in pbr_map_nexthop() 211 } 212 #if 1 /* anything that can fail? */ 213 if (_failcnt) 214 return CMD_WARNING; 215 #endif 216 #endif >>> CID 1468032: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "addr" to "pbr_map_nexthop_magic", which dereferences it. 217 return pbr_map_nexthop_magic(self, vty, argc, argv, no, addr, addr_str, intf, name); 218 } 219 220 /* pbr_policy => "[no] pbr-policy NAME$mapname" */ 221 DEFUN_CMD_FUNC_DECL(pbr_policy) 222 #define funcdecl_pbr_policy static int pbr_policy_magic(\ ** CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) /pbrd/pbr_zebra.c: 497 in pbr_send_pbr_map() ________________________________________________________________________________________________________ *** CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) /pbrd/pbr_zebra.c: 497 in pbr_send_pbr_map() 491 492 void pbr_send_pbr_map(struct pbr_map_sequence *pbrms, 493 struct pbr_map_interface *pmi, bool install) 494 { 495 struct pbr_map *pbrm = pbrms->parent; 496 struct stream *s; >>> CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) >>> Potentially overflowing expression "1 << pmi->install_bit" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). 497 uint64_t is_installed = 1 << pmi->install_bit; 498 499 is_installed &= pbrms->installed; 500 501 DEBUGD(&pbr_dbg_zebra, "%s: for %s %d(%" PRIu64 ")", 502 __PRETTY_FUNCTION__, pbrm->name, install, is_installed); ** CID 1468030: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468030: Null pointer dereferences (FORWARD_NULL) /lib/nexthop_group_clippy.c: 67 in ecmp_nexthops() 61 } 62 #if 1 /* anything that can fail? */ 63 if (_failcnt) 64 return CMD_WARNING; 65 #endif 66 #endif >>> CID 1468030: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "addr" to "ecmp_nexthops_magic", which dereferences it. 67 return ecmp_nexthops_magic(self, vty, argc, argv, no, addr, addr_str, intf, name); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Apr '18

17 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1467945: Memory - corruptions (UNINIT) /zebra/redistribute.c: 534 in zebra_add_import_table_entry() ________________________________________________________________________________________________________ *** CID 1467945: Memory - corruptions (UNINIT) /zebra/redistribute.c: 534 in zebra_add_import_table_entry() 528 if (rmap_name) 529 ret = zebra_import_table_route_map_check( 530 afi, re->type, &rn->p, re->ng.nexthop, re->vrf_id, 531 re->tag, rmap_name); 532 533 if (ret != RMAP_MATCH) { >>> CID 1467945: Memory - corruptions (UNINIT) >>> Using uninitialized value "same". 534 UNSET_FLAG(same->flags, ZEBRA_FLAG_SELECTED); 535 zebra_del_import_table_entry(rn, re); 536 return 0; 537 } 538 539 prefix_copy(&p, &rn->p); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

PR without a review for 18 days
by Donald Sharp 16 Apr '18

16 Apr '18

This PR has been without a review for 18 days, without a review: https://github.com/FRRouting/frr/pull/1988 I am planning to push this in at 10:30 AM EDT April 17. Speak now if you want to look at this. thanks! donald

3 2

another slack invite request
by Ronald van der Pol 13 Apr '18

13 Apr '18

Can someone invite me on the slack channel? Thanks. rvdp

2 1

Slack Invite
by Bruce Smith 12 Apr '18

12 Apr '18

FRR Devs, I'm a FRR user and definitely would enjoy being in the slack. Could someone please invite me? Thank You, Bruce Smith

2 1

Slack Invitation Request
by Mike Detwiler 12 Apr '18

12 Apr '18

Hello, My name is Mike Detwiler, and I'm very interested in participating in the FRRouting project. Please add me to the public Slack channel. Cheers, -Mike

2 1