- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Mar '18

30 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1467125: Resource leaks (RESOURCE_LEAK) /bgpd/bgp_flowspec.c: 176 in bgp_nlri_parse_flowspec() ________________________________________________________________________________________________________ *** CID 1467125: Resource leaks (RESOURCE_LEAK) /bgpd/bgp_flowspec.c: 176 in bgp_nlri_parse_flowspec() 170 snprintf(local_string, BGP_FLOWSPEC_NLRI_STRING_MAX, 171 "FS Rx %s %s %s %s", withdraw ? 172 "Withdraw":"Update", 173 afi2str(afi), return_string, 174 attr != NULL ? ec_string : ""); 175 zlog_info("%s", local_string); >>> CID 1467125: Resource leaks (RESOURCE_LEAK) >>> Variable "s" going out of scope leaks the storage it points to. 176 } 177 /* Process the route. */ 178 if (!withdraw) 179 ret = bgp_update(peer, &p, 0, attr, 180 afi, safi, 181 ZEBRA_ROUTE_BGP, BGP_ROUTE_NORMAL, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Question about EVPN route types
by Jay Chen 29 Mar '18

29 Mar '18

Hi all, I got a question about what EVPN route types are supported already in the latest version. It looks like type-2, type-3, and type-5 are supported. Type-1, and type-4 are not yet. If it is true, any plan the missing types are going to be supported? Another quick question, the fpm/fpm_pb.c file looks empty. Is there a missing patch need to be patched? It will be very helpful if anyone can point to a brief example how fpm is used by a switch that has a hardware forwarding path? Thanks, Jay

6 8

C99 fixed-width patch
by Quentin Young 28 Mar '18

28 Mar '18

Hi folks, PR #1854 switched all of our fixed width types over to types present in the C99 standard. Since we used a lot of nonstandard types this was a pretty big patch and may have caused conflicts with open pull requests or your private branches, so you may want to check. If you’re using these types in some new code, you can try using the conversion script in tools/convert-fixedwidth.sh followed by a `git clang-format` to replicate the process that was done to master and hopefully reduce some of the conflicts. Quentin

1 0

FRR Technical Meeting Notes 03/27/18
by Quentin Young 27 Mar '18

27 Mar '18

FRR Technical Meeting Notes 03/27/18 ==================================== Issues ------ - #1949: Donald - We need to discuss integration of namespace VRF more because the codebase has an implicit assumption that the default VRF is zero. - #1953: Quentin to rebase and poke Martin if CI still fails - #1960: Donald and Philippe to discuss further - #1965: Christian - It's a feature request. Added to FR page and closed issue. - #1967: Seems legit, we'll start looking. Pull Requests ------------- - #1817: Just a few minor nits from Quentin, then g2g - #1824: Needs additional reviewers, Donald will take another look - #1833: Paul to clean up and then we will merge - #1853: Lots of folks asking about BFD, needs reviewers, configure switch needs to be fixed; Donald will help with autotools - #1854: Needs a rebase, then should be g2g - #1881: g2g once Olivier updates topotests - #1894: Lou fixed today, Quentin to look again - #1903: Needs reviewers - #1905: Donald to review new changes - #1915: [Merged] - #1916: Needs reviewers - #1921: Needs reviewers - #1928: Lou to take another look and probably merge - #1950: Proposed change to fix #1949 - #1959: Assigned Martin for review - #1966: Renato to review - #1969: \ #1970: / Donald to take a look at these

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Mar '18

27 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1466892: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 570 in bgp_info_cmp() ________________________________________________________________________________________________________ *** CID 1466892: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 570 in bgp_info_cmp() 564 "%s: %s wins over %s due to preferred BGP_ROUTE type", 565 pfx_buf, new_buf, exist_buf); 566 return 1; 567 } 568 569 if (!(exist->sub_type == BGP_ROUTE_NORMAL || >>> CID 1466892: Incorrect expression (COPY_PASTE_ERROR) >>> "new" in "new->sub_type" looks like a copy-paste error. 570 new->sub_type == BGP_ROUTE_IMPORTED)) { 571 if (debug) 572 zlog_debug( 573 "%s: %s loses to %s due to preferred BGP_ROUTE type", 574 pfx_buf, new_buf, exist_buf); 575 return 0; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

FRR 4.0 Released
by Quentin Young 25 Mar '18

25 Mar '18

Greetings operators and interested parties, The FRRouting contributors are proud to announce that the latest release of FRR is available for download. The team has spent several months integrating code and developing enhancements towards making FRR the best open routing suite available. The project thanks all contributors to this latest release, big and small! Documentation is located on the project website: https://frrouting.org/user-guide/ We have also begun to flesh out documentation for contributors and those interested in contributing: https://frrouting.org/dev-guide/ Feedback and documentation improvements are always welcome. Change Summary ============== General ------- * Implemented tab completion for interface names, prefix-lists, route-maps and BGP peer-names New protocols ------------- Added: * RFC 6126 -- Added BABEL protocol daemon * RFC 7868 -- Added EIGRP protocol daemon (experimental) BGP --- Added: * RFC 6810 -- RPKI integration * RFC 3107 -- v4 labeled unicast with partial implementation of draft-ietf-idr-bgp-prefix-sid * RFC 6514 -- Encodings and Procedures for Multicast in MPLS/BGP IP VPN's * RFC 7432 -- MPLS-Based Ethernet VPN (EVPN) * draft-ietf-bess-evpn-overlay * draft-ietf-bess-evpn-inter-subnet-forwarding * draft-ietf-bess-evpn-prefix-advertisement * draft-ietf-idr-tunnel-encaps * draft-ietf-bess-evpn-proxy-arp-nd ISIS ---- Added: * RFC 5120 -- ISIS-MT PIM --- Added: * VRF support OSPFv2 ------ Added: * VRF support * draft-ietf-ospf-segment-routing-extensions-24 (experimental) ZEBRA ----- * Cross-VRF static route leaking Bugfixes ======== * Too many to count.

3 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Mar '18

23 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1465679: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vty.c: 265 in zebra_static_route_holdem() ________________________________________________________________________________________________________ *** CID 1465679: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vty.c: 265 in zebra_static_route_holdem() 259 return CMD_SUCCESS; 260 } 261 262 if (!negate) 263 listnode_add_sort(static_list, shr); 264 >>> CID 1465679: Resource leaks (RESOURCE_LEAK) >>> Variable "shr" going out of scope leaks the storage it points to. 265 return CMD_SUCCESS; 266 } 267 268 static int zebra_static_route_leak( 269 struct vty *vty, struct zebra_vrf *zvrf, struct zebra_vrf *nh_zvrf, 270 afi_t afi, safi_t safi, const char *negate, const char *dest_str, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Broken CI and builds
by Donald Sharp 22 Mar '18

22 Mar '18

All - PR #1938 broke Lou's CI system and PR's submitted after this fix will fail Lou's CI. The fix for this was in PR #1947 which has been pushed into the tree. If your PR is failing Lou's CI, I would suggest rebasing and force pushing to get #1947. donald

1 0

Open source routing @ ietf meetup
by Lou Berger 22 Mar '18

22 Mar '18

Hi, We're continuing with the informal Open source routing @ ietf meetup. Anyone interested in joining a "bring your own lunch" gathering of folks using/building open source routing code, please drop in to "Richmond/Chelsea/Tower" on Thursday during lunch (noon). There is no agenda or slides. Please feel free to bring a topic that you'd like to discuss or just come and listen. Cheers, Lou [1] https://datatracker.ietf.org/meeting/101/floor-plan?room=richmond-chelsea-t…

2 1

BGP VPN-VRF route leaking per RFC 4364
by Donald Sharp 22 Mar '18

22 Mar '18

2 1