- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Apr '18

26 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1468416: Error handling issues (CHECKED_RETURN) /bgpd/bgp_rd.c: 213 in form_auto_rd() ________________________________________________________________________________________________________ *** CID 1468416: Error handling issues (CHECKED_RETURN) /bgpd/bgp_rd.c: 213 in form_auto_rd() 207 { 208 char buf[100]; 209 210 prd->family = AF_UNSPEC; 211 prd->prefixlen = 64; 212 sprintf(buf, "%s:%hu", inet_ntoa(router_id), rd_id); >>> CID 1468416: Error handling issues (CHECKED_RETURN) >>> Calling "str2prefix_rd" without checking return value (as is done elsewhere 15 out of 16 times). 213 str2prefix_rd(buf, prd); ** CID 1468415: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468415: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 361 in af_route_map_vpn_imexport() 355 } 356 #if 0 /* anything that can fail? */ 357 if (_failcnt) 358 return CMD_WARNING; 359 #endif 360 #endif >>> CID 1468415: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap_str" to "af_route_map_vpn_imexport_magic", which dereferences it. 361 return af_route_map_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rmap_str); 362 } 363 364 /* af_import_vrf_route_map => "[no] import vrf route-map RMAP$rmap_str" */ 365 DEFUN_CMD_FUNC_DECL(af_import_vrf_route_map) 366 #define funcdecl_af_import_vrf_route_map static int af_import_vrf_route_map_magic(\ ** CID 1468414: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468414: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 409 in af_import_vrf_route_map() 403 } 404 #if 0 /* anything that can fail? */ 405 if (_failcnt) 406 return CMD_WARNING; 407 #endif 408 #endif >>> CID 1468414: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rmap_str" to "af_import_vrf_route_map_magic", which dereferences it. 409 return af_import_vrf_route_map_magic(self, vty, argc, argv, no, rmap_str); 410 } 411 412 /* bgp_imexport_vrf => "[no] import vrf NAME$import_name" */ 413 DEFUN_CMD_FUNC_DECL(bgp_imexport_vrf) 414 #define funcdecl_bgp_imexport_vrf static int bgp_imexport_vrf_magic(\ ** CID 1468413: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468413: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 457 in bgp_imexport_vrf() 451 } 452 #if 0 /* anything that can fail? */ 453 if (_failcnt) 454 return CMD_WARNING; 455 #endif 456 #endif >>> CID 1468413: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "import_name" to "bgp_imexport_vrf_magic", which dereferences it. 457 return bgp_imexport_vrf_magic(self, vty, argc, argv, no, import_name); 458 } 459 460 /* bgp_imexport_vpn => "[no] <import|export>$direction_str vpn" */ 461 DEFUN_CMD_FUNC_DECL(bgp_imexport_vpn) 462 #define funcdecl_bgp_imexport_vpn static int bgp_imexport_vpn_magic(\ ** CID 1465490: Error handling issues (CHECKED_RETURN) /pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req() ________________________________________________________________________________________________________ *** CID 1465490: Error handling issues (CHECKED_RETURN) /pimd/pim_igmp_mtrace.c: 817 in igmp_mtrace_recv_qry_req() 811 } 812 /* 813 * 6.4 Forwarding Traceroute Requests: 814 * Previous-hop router not known, 815 * packet is sent to an appropriate multicast address 816 */ >>> CID 1465490: Error handling issues (CHECKED_RETURN) >>> Calling "inet_aton" without checking return value (as is done elsewhere 115 out of 117 times). 817 inet_aton(MCAST_ALL_ROUTERS, &nh_addr); 818 } 819 820 /* 6.2.2 8. If this router is the Rendez-vous Point */ 821 if (pim_rp_i_am_rp(pim, mtracep->grp_addr)) { 822 mtrace_rsp_set_fwd_code(rspp, MTRACE_FWD_CODE_REACHED_RP); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Invite to FRRouting slack
by quentusrex＠gmail.com 24 Apr '18

24 Apr '18

My name is William King, CTO of Flowroute located in Seattle, WA. Looking to evaluate migrating from BIRD to FRRouting, and better connect with the community. -William

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Apr '18

20 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1468032: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468032: Null pointer dereferences (FORWARD_NULL) /pbrd/pbr_vty_clippy.c: 217 in pbr_map_nexthop() 211 } 212 #if 1 /* anything that can fail? */ 213 if (_failcnt) 214 return CMD_WARNING; 215 #endif 216 #endif >>> CID 1468032: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "addr" to "pbr_map_nexthop_magic", which dereferences it. 217 return pbr_map_nexthop_magic(self, vty, argc, argv, no, addr, addr_str, intf, name); 218 } 219 220 /* pbr_policy => "[no] pbr-policy NAME$mapname" */ 221 DEFUN_CMD_FUNC_DECL(pbr_policy) 222 #define funcdecl_pbr_policy static int pbr_policy_magic(\ ** CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) /pbrd/pbr_zebra.c: 497 in pbr_send_pbr_map() ________________________________________________________________________________________________________ *** CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) /pbrd/pbr_zebra.c: 497 in pbr_send_pbr_map() 491 492 void pbr_send_pbr_map(struct pbr_map_sequence *pbrms, 493 struct pbr_map_interface *pmi, bool install) 494 { 495 struct pbr_map *pbrm = pbrms->parent; 496 struct stream *s; >>> CID 1468031: Integer handling issues (OVERFLOW_BEFORE_WIDEN) >>> Potentially overflowing expression "1 << pmi->install_bit" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). 497 uint64_t is_installed = 1 << pmi->install_bit; 498 499 is_installed &= pbrms->installed; 500 501 DEBUGD(&pbr_dbg_zebra, "%s: for %s %d(%" PRIu64 ")", 502 __PRETTY_FUNCTION__, pbrm->name, install, is_installed); ** CID 1468030: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1468030: Null pointer dereferences (FORWARD_NULL) /lib/nexthop_group_clippy.c: 67 in ecmp_nexthops() 61 } 62 #if 1 /* anything that can fail? */ 63 if (_failcnt) 64 return CMD_WARNING; 65 #endif 66 #endif >>> CID 1468030: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "addr" to "ecmp_nexthops_magic", which dereferences it. 67 return ecmp_nexthops_magic(self, vty, argc, argv, no, addr, addr_str, intf, name); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 17 Apr '18

17 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1467945: Memory - corruptions (UNINIT) /zebra/redistribute.c: 534 in zebra_add_import_table_entry() ________________________________________________________________________________________________________ *** CID 1467945: Memory - corruptions (UNINIT) /zebra/redistribute.c: 534 in zebra_add_import_table_entry() 528 if (rmap_name) 529 ret = zebra_import_table_route_map_check( 530 afi, re->type, &rn->p, re->ng.nexthop, re->vrf_id, 531 re->tag, rmap_name); 532 533 if (ret != RMAP_MATCH) { >>> CID 1467945: Memory - corruptions (UNINIT) >>> Using uninitialized value "same". 534 UNSET_FLAG(same->flags, ZEBRA_FLAG_SELECTED); 535 zebra_del_import_table_entry(rn, re); 536 return 0; 537 } 538 539 prefix_copy(&p, &rn->p); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

PR without a review for 18 days
by Donald Sharp 16 Apr '18

16 Apr '18

This PR has been without a review for 18 days, without a review: https://github.com/FRRouting/frr/pull/1988 I am planning to push this in at 10:30 AM EDT April 17. Speak now if you want to look at this. thanks! donald

3 2

another slack invite request
by Ronald van der Pol 13 Apr '18

13 Apr '18

Can someone invite me on the slack channel? Thanks. rvdp

2 1

Slack Invite
by Bruce Smith 12 Apr '18

12 Apr '18

FRR Devs, I'm a FRR user and definitely would enjoy being in the slack. Could someone please invite me? Thank You, Bruce Smith

2 1

Slack Invitation Request
by Mike Detwiler 12 Apr '18

12 Apr '18

Hello, My name is Mike Detwiler, and I'm very interested in participating in the FRRouting project. Please add me to the public Slack channel. Cheers, -Mike

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 12 Apr '18

12 Apr '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 12 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 12 of 12 defect(s) ** CID 1467832: Null pointer dereferences (NULL_RETURNS) /pbrd/pbr_nht.c: 217 in pbr_nhgroup_add_cb() ________________________________________________________________________________________________________ *** CID 1467832: Null pointer dereferences (NULL_RETURNS) /pbrd/pbr_nht.c: 217 in pbr_nhgroup_add_cb() 211 nhgc = nhgc_find(name); 212 pnhgc = pbr_nht_add_group(name); 213 214 DEBUGD(&pbr_dbg_nht, "%s: Added nexthop-group %s", __PRETTY_FUNCTION__, 215 name); 216 >>> CID 1467832: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a null pointer "nhgc". 217 pbr_nht_install_nexthop_group(pnhgc, nhgc->nhg); 218 pbr_map_check_nh_group_change(name); 219 } 220 221 void pbr_nhgroup_add_nexthop_cb(const struct nexthop_group_cmd *nhgc, 222 const struct nexthop *nhop) ** CID 1467831: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1467831: Null pointer dereferences (FORWARD_NULL) /pbrd/pbr_vty_clippy.c: 148 in pbr_map_nexthop_group() 142 } 143 #if 0 /* anything that can fail? */ 144 if (_failcnt) 145 return CMD_WARNING; 146 #endif 147 #endif >>> CID 1467831: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "name" to "pbr_map_nexthop_group_magic", which dereferences it. 148 return pbr_map_nexthop_group_magic(self, vty, argc, argv, no, name); 149 } 150 151 /* pbr_map_nexthop => "[no] set nexthop <A.B.C.D|X:X::X:X>$addr [INTERFACE]$intf [nexthop-vrf NAME$name]" */ 152 DEFUN_CMD_FUNC_DECL(pbr_map_nexthop) 153 #define funcdecl_pbr_map_nexthop static int pbr_map_nexthop_magic(\ ** CID 1467830: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1467830: Null pointer dereferences (FORWARD_NULL) /pbrd/pbr_vty_clippy.c: 265 in pbr_policy() 259 } 260 #if 0 /* anything that can fail? */ 261 if (_failcnt) 262 return CMD_WARNING; 263 #endif 264 #endif >>> CID 1467830: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "mapname" to "pbr_policy_magic", which dereferences it. 265 return pbr_policy_magic(self, vty, argc, argv, no, mapname); 266 } 267 268 /* show_pbr => "show pbr [json$json]" */ 269 DEFUN_CMD_FUNC_DECL(show_pbr) 270 #define funcdecl_show_pbr static int show_pbr_magic(\ ** CID 1467829: Resource leaks (RESOURCE_LEAK) /pbrd/pbr_vty.c: 348 in pbr_policy_magic() ________________________________________________________________________________________________________ *** CID 1467829: Resource leaks (RESOURCE_LEAK) /pbrd/pbr_vty.c: 348 in pbr_policy_magic() 342 if (pbrm) 343 pbr_map_add_interface(pbrm, ifp); 344 } 345 } 346 } 347 >>> CID 1467829: Resource leaks (RESOURCE_LEAK) >>> Variable "pbr_ifp" going out of scope leaks the storage it points to. 348 return CMD_SUCCESS; 349 } 350 351 DEFPY (show_pbr, 352 show_pbr_cmd, 353 "show pbr [json$json]", ** CID 1467828: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 779 in pbr_nht_get_installed() ________________________________________________________________________________________________________ *** CID 1467828: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 779 in pbr_nht_get_installed() 773 bool pbr_nht_get_installed(const char *name) 774 { 775 struct pbr_nexthop_group_cache find; 776 struct pbr_nexthop_group_cache *pnhgc; 777 778 memset(&find, 0, sizeof(find)); >>> CID 1467828: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "find.name" by copying "name" without checking the length. 779 strcpy(find.name, name); 780 781 pnhgc = hash_lookup(pbr_nhg_hash, &find); 782 783 if (!pnhgc) 784 return false; ** CID 1467827: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 436 in pbr_nht_change_group() ________________________________________________________________________________________________________ *** CID 1467827: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 436 in pbr_nht_change_group() 430 431 nhgc = nhgc_find(name); 432 if (!nhgc) 433 return; 434 435 memset(&find, 0, sizeof(find)); >>> CID 1467827: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "find.name" by copying "name" without checking the length. 436 strcpy(find.name, name); 437 pnhgc = hash_lookup(pbr_nhg_hash, &find); 438 439 if (!pnhgc) { 440 DEBUGD(&pbr_dbg_nht, 441 "%s: Could not find nexthop-group cache w/ name '%s'", ** CID 1467826: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 511 in pbr_nht_delete_individual_nexthop() ________________________________________________________________________________________________________ *** CID 1467826: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 511 in pbr_nht_delete_individual_nexthop() 505 pbrm->valid = false; 506 pbrms->nhs_installed = false; 507 pbrms->installed = false; 508 pbrms->reason |= PBR_MAP_INVALID_NO_NEXTHOPS; 509 510 memset(&find, 0, sizeof(find)); >>> CID 1467826: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "&find.name[0]" by copying "pbrms->internal_nhg_name" without checking the length. 511 strcpy(&find.name[0], pbrms->internal_nhg_name); 512 pnhgc = hash_lookup(pbr_nhg_hash, &find); 513 514 nh = pbrms->nhg->nexthop; 515 nh_afi = nh->type; 516 lup.nexthop = nh; ** CID 1467825: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 760 in pbr_nht_get_table() ________________________________________________________________________________________________________ *** CID 1467825: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 760 in pbr_nht_get_table() 754 uint32_t pbr_nht_get_table(const char *name) 755 { 756 struct pbr_nexthop_group_cache find; 757 struct pbr_nexthop_group_cache *pnhgc; 758 759 memset(&find, 0, sizeof(find)); >>> CID 1467825: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "find.name" by copying "name" without checking the length. 760 strcpy(find.name, name); 761 pnhgc = hash_lookup(pbr_nhg_hash, &find); 762 763 if (!pnhgc) { 764 DEBUGD(&pbr_dbg_nht, 765 "%s: Could not find nexthop-group cache w/ name '%s'", ** CID 1467824: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 605 in pbr_nht_nexthop_group_valid() ________________________________________________________________________________________________________ *** CID 1467824: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 605 in pbr_nht_nexthop_group_valid() 599 { 600 struct pbr_nexthop_group_cache *pnhgc; 601 struct pbr_nexthop_group_cache lookup; 602 603 DEBUGD(&pbr_dbg_nht, "%s: %s", __PRETTY_FUNCTION__, name); 604 >>> CID 1467824: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "lookup.name" by copying "name" without checking the length. 605 strcpy(lookup.name, name); 606 pnhgc = hash_get(pbr_nhg_hash, &lookup, NULL); 607 if (!pnhgc) 608 return false; 609 DEBUGD(&pbr_dbg_nht, "%s: \t%d %d", __PRETTY_FUNCTION__, pnhgc->valid, 610 pnhgc->installed); ** CID 1467823: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 546 in pbr_nht_add_group() ________________________________________________________________________________________________________ *** CID 1467823: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_nht.c: 546 in pbr_nht_add_group() 540 if (!nhgc) { 541 zlog_warn("%s: Could not find group %s to add", 542 __PRETTY_FUNCTION__, name); 543 return NULL; 544 } 545 >>> CID 1467823: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "lookup.name" by copying "name" without checking the length. 546 strcpy(lookup.name, name); 547 pnhgc = hash_get(pbr_nhg_hash, &lookup, pbr_nhgc_alloc); 548 DEBUGD(&pbr_dbg_nht, "%s: Retrieved NHGC @ %p", __PRETTY_FUNCTION__, 549 pnhgc); 550 551 for (ALL_NEXTHOPS(nhgc->nhg, nhop)) { ** CID 1467822: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_map.c: 271 in pbrms_get() ________________________________________________________________________________________________________ *** CID 1467822: Security best practices violations (STRING_OVERFLOW) /pbrd/pbr_map.c: 271 in pbrms_get() 265 struct pbr_map_sequence *pbrms; 266 struct listnode *node; 267 268 pbrm = pbrm_find(name); 269 if (!pbrm) { 270 pbrm = XCALLOC(MTYPE_PBR_MAP, sizeof(*pbrm)); >>> CID 1467822: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "pbrm->name" by copying "name" without checking the length. 271 strcpy(pbrm->name, name); 272 273 pbrm->seqnumbers = list_new(); 274 pbrm->seqnumbers->cmp = 275 (int (*)(void *, void *))pbr_map_sequence_compare; 276 pbrm->seqnumbers->del = ** CID 1467821: (STRING_OVERFLOW) /pbrd/pbr_vty.c: 332 in pbr_policy_magic() /pbrd/pbr_vty.c: 341 in pbr_policy_magic() ________________________________________________________________________________________________________ *** CID 1467821: (STRING_OVERFLOW) /pbrd/pbr_vty.c: 332 in pbr_policy_magic() 326 327 if (pbrm) 328 pbr_map_interface_delete(pbrm, ifp); 329 } 330 } else { 331 if (strcmp(pbr_ifp->mapname, "") == 0) { >>> CID 1467821: (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "pbr_ifp->mapname" by copying "mapname" without checking the length. 332 strcpy(pbr_ifp->mapname, mapname); 333 334 if (pbrm) 335 pbr_map_add_interface(pbrm, ifp); 336 } else { 337 if (!(strcmp(pbr_ifp->mapname, mapname) == 0)) { /pbrd/pbr_vty.c: 341 in pbr_policy_magic() 335 pbr_map_add_interface(pbrm, ifp); 336 } else { 337 if (!(strcmp(pbr_ifp->mapname, mapname) == 0)) { 338 old_pbrm = pbrm_find(pbr_ifp->mapname); 339 if (old_pbrm) 340 pbr_map_interface_delete(old_pbrm, ifp); >>> CID 1467821: (STRING_OVERFLOW) >>> You might overrun the 100-character fixed-size string "pbr_ifp->mapname" by copying "mapname" without checking the length. 341 strcpy(pbr_ifp->mapname, mapname); 342 if (pbrm) 343 pbr_map_add_interface(pbrm, ifp); 344 } 345 } 346 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

4/10 Technical Meeting Notes
by Quentin Young 11 Apr '18

11 Apr '18

Issues ====== - #2018: Vincent, Philippe: we would like to be able to call iptables & other external programs from zebra Donald, Lou: Security concerns here, would be better to use a module Lou: Perhaps use FPM to interface with Zebra without integrating this code directly into Zebra Vincent, Philippe: We'll take a look - #2030: Donald: Requested that start/stop of FRR on Alpine be similar to other platforms, submitter agreed, work in progress - #2040: Unsure if bug, probable workaround commented in issue Pull Requests ============= - #1853: Donald to continue looking at this PR, still some config-related CI issues to clear up - #1881: Olivier: not quite correct yet, will update to use label manager & change CLI - #1883: Quentin & Donald: It does not make sense to add a checkpatch patch that will run for a single PR and never again Lou: Can't guarantee that it will never run again, and important to have clear policy Paul: How about we document agreed-upon exceptions as a compromise? All: sounds good - #1905: Donald to look again - #1916: Waiting on Mitesh to do what needs to be done - #1950: Donald to review again - #1976: Donald: NetNS is a poor abstraction that requires this patch... Vincent: This is how it's done on non-VRF supporting platforms [provides some references] Donald: Will read references, review again and continue conversation - #2009: Merged - #2025: See discussion for #2018 - #2033: Donald + Lou to review - #2035: In discussions - #2036: Philippe has review comments, Donald to look at changes addressing previous comments - #2038: Merged - #2039: Broken packaging for now - #2043: Debug cleanups & route replace semantic improvements for Zebra Renato to review

3 2