- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 19 Dec '17

19 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1463076: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1474 in rib_process() ________________________________________________________________________________________________________ *** CID 1463076: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_rib.c: 1474 in rib_process() 1468 if (IS_ZEBRA_DEBUG_RIB) 1469 srcdest_rnode2str(rn, buf, sizeof(buf)); 1470 1471 if (IS_ZEBRA_DEBUG_RIB_DETAILED) 1472 zlog_debug("%u:%s: Processing rn %p", vrf_id, buf, rn); 1473 >>> CID 1463076: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "dest". 1474 old_fib = dest->selected_fib; 1475 1476 RNODE_FOREACH_RE_SAFE (rn, re, next) { 1477 if (IS_ZEBRA_DEBUG_RIB_DETAILED) 1478 zlog_debug( 1479 "%u:%s: Examine re %p (type %d) status %x flags %x " ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Serious problem with snmp!
by Mostafa Salari 17 Dec '17

17 Dec '17

Hi 1. I installed net-snmp 5.7.3 on Ubuntu 1704 (but the following problem was observed on many versions of Ubuntu like 1604, 1404) 2. Then I configure FRR3 with *--enable-snmp=agentx* switch! As i think, this switch is necessary for the purpose of accessing routing MIBs which must be responsed by zebra. 3. Now, I make FRR and see the following error make[2]: Entering directory '/home/theuser/frr/FRR3' CLIPPY ospfd/ospf_vty_clippy.c CLIPPY lib/plist_clippy.c CC lib/lib_libfrrsnmp_la-agentx.lo CC lib/lib_libfrrsnmp_la-smux.lo CC lib/lib_libfrrsnmp_la-snmp.lo CCLD lib/libfrrsnmp.la /usr/bin/ld: /usr/local/lib/libnetsnmp.a(scapi.o): relocation R_X86_64_PC32 against symbol `usmHMACMD5AuthProtocol' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status Makefile:2379: *recipe for target 'lib/libfrrsnmp.la <http://libfrrsnmp.la>' failed* make[2]: *** [lib/libfrrsnmp.la] Error 1 make[2]: Leaving directory '/home/theuser/frr/FRR3' Makefile:3194: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/home/theuser/frr/FRR3' Makefile:1867: recipe for target 'all' failed Note that: If net-snmp was not installed, there was no error when making FRR, BUT a similar error was raised when trying to make net-snmp after frr !!! If i disable --enable-snmp=agentx there is no error! But the system will not respond to snmp requests that ask for routing information.

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 Dec '17

14 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1462961: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1462961: Memory - corruptions (OVERRUN) /bgpd/rfapi/rfapi_vty.c: 1532 in rfapiPrintRd() 1526 } 1527 1528 void rfapiPrintRd(struct vty *vty, struct prefix_rd *prd) 1529 { 1530 char buf[RD_ADDRSTRLEN]; 1531 >>> CID 1462961: Memory - corruptions (OVERRUN) >>> Overrunning array "buf" of 28 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192UL". 1532 prefix_rd2str(prd, buf, BUFSIZ); 1533 vty_out(vty, "%s", buf); 1534 } 1535 1536 void rfapiPrintAdvertisedInfo(struct vty *vty, struct rfapi_descriptor *rfd, 1537 safi_t safi, struct prefix *p) ** CID 1462960: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1629 in vnc_nve_group_export_no_prefixlist() ________________________________________________________________________________________________________ *** CID 1462960: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1629 in vnc_nve_group_export_no_prefixlist() 1623 if (!listnode_lookup(bgp->rfapi_cfg->nve_groups_sequential, rfg)) { 1624 /* Not in list anymore */ 1625 vty_out(vty, "Current NVE group no longer exists\n"); 1626 return CMD_WARNING_CONFIG_FAILED; 1627 } 1628 >>> CID 1462960: Error handling issues (CHECKED_RETURN) >>> Calling "argv_find_and_parse_afi" without checking return value (as is done elsewhere 8 out of 10 times). 1629 argv_find_and_parse_afi(argv, argc, &idx, &afi); 1630 if (argv[idx-1]->text[0] == 'z') 1631 is_bgp = 0; 1632 idx += 2; /* skip afi and keyword */ 1633 1634 if (is_bgp) { ** CID 1462959: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1694 in vnc_nve_group_export_prefixlist() ________________________________________________________________________________________________________ *** CID 1462959: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1694 in vnc_nve_group_export_prefixlist() 1688 if (!listnode_lookup(bgp->rfapi_cfg->nve_groups_sequential, rfg)) { 1689 /* Not in list anymore */ 1690 vty_out(vty, "Current NVE group no longer exists\n"); 1691 return CMD_WARNING_CONFIG_FAILED; 1692 } 1693 >>> CID 1462959: Error handling issues (CHECKED_RETURN) >>> Calling "argv_find_and_parse_afi" without checking return value (as is done elsewhere 8 out of 10 times). 1694 argv_find_and_parse_afi(argv, argc, &idx, &afi); 1695 if (argv[idx-1]->text[0] == 'z') 1696 is_bgp = 0; 1697 idx = argc - 1; 1698 1699 if (is_bgp) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Missing developer documentation
by Olivier Dugeon 12 Dec '17

12 Dec '17

Hiall, There is missing developer documentation in FRR. In PR #805 I try to update an old Zebra hacking document, but that seems too old to be publish, so I prefer to remove it as suggested during the PR review. For me, the main problem is how to start writing a such documentation ? First, it is too huge and to complicated to be written by only one person. Second, we need a dedicated space (e.g. a new doc project inside FRRouting) to collectively write such documentation and then push into frr master documents when they are ready. Finally, we need to organize themselves in order to collectively decided how to write them, to formalize the document through a common template, to harmonize the documentation... I would start by proposing: * start discussion about this new topic (create a new issue in github) during regular meeting * decide the document format (Markdown, in line github Wiki, LaTeX, TeXi ...) * create a new doc project within FRRouting * propose template * propose Table of Content for each document (perhaps partially common) * open contribution to the different documents Comments are welcome. Regards Olivier

4 6

a question on rst format -
by Lou Berger 11 Dec '17

11 Dec '17

Hi, Am I the only one who doesn't know about (or remember) the discussion on moving to rst as our single documentation format for the project? BTW I'm okay with the answer either way... Thanks, Lou

1 0

Discussion on "Linux Foundation Networking Projects"
by Martin Winter 06 Dec '17

06 Dec '17

All, We got approached by the Linux Foundation about some new "Linux Foundation Networking Projects" Umbrella they are planning to set up to combine various network projects. We (FRR) are a Linux Foundation project, but a lightweight one at this time, with basically only the assets held by the LF, so very unlike other projects which had formal companies set up with funding through the LF etc. They are in the process to form a new "Linux Foundation Networking Projects" umbrella and the TSC was approached to see if we are interested to join this. I expect the LF wants a decision by around mid December, so I want to discuss this at the next meeting. At next weeks meeting (Dec 6) there is ONLY a discussion, no decision will be made. However, the TSC is likely to make a decision the week after. Join the call to raise your opinions or just to listen on everyones thoughts. From the original meeting invitation by the Linux Foundation to the TSC: > Hello Open Source Networking Project Developers: > > The Linux Foundation is proud and humbled to host such a collection of > critical and influential open source networking projects for > enterprise, > cloud, and carriers alike. Over the past 5 years these projects have > formed, grown, and matured into key infrastructure components on which > tomorrow’s networking solutions are based. > > Through this journey, members across various networking projects have > requested alignment of the business governance and a greater > opportunity > for technical leverage and collaboration. To that end, the Linux > Foundation has embarked on a plan to provide a structure that allows > for > aligned governance & cross project collaboration while maintaining the > technical independence of all projects. > > To explain this exciting opportunity, answer questions, and get your > feedback, we are hosting a pair of Webinars next week on Nov. 6th, and > 7th. If you’ve been hearing about “Harmonization”, and/or > “Umbrella” > activities and want to understand where we are with those initiatives, > please join us for this Webinar. If you want more details, then please listen to the recording of the call at https://zoom.us/recording/play/M3L8MOR27hz2zWpIbY5--8iTOsn0ASbBJvs--VtbhDX5… - Martin Winter

5 8

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Dec '17

05 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1462467: (DEADCODE) /zebra/zebra_rib.c: 1345 in rib_process_update_fib() /zebra/zebra_rib.c: 1353 in rib_process_update_fib() ________________________________________________________________________________________________________ *** CID 1462467: (DEADCODE) /zebra/zebra_rib.c: 1345 in rib_process_update_fib() 1339 */ 1340 if (!nh_active || !installed) { 1341 if (IS_ZEBRA_DEBUG_RIB) { 1342 char buf[SRCDEST2STR_BUFFER]; 1343 srcdest_rnode2str(rn, buf, sizeof(buf)); 1344 if (new != old) >>> CID 1462467: (DEADCODE) >>> Execution cannot reach the expression ""install failed"" inside this statement: "zlog_debug("%u:%s: Deleting...". 1345 zlog_debug( 1346 "%u:%s: Deleting route rn %p, re %p (type %d) " 1347 "old %p (type %d) - %s", 1348 zvrf_id(zvrf), buf, rn, new, 1349 new->type, old, old->type, 1350 nh_active ? "install failed" /zebra/zebra_rib.c: 1353 in rib_process_update_fib() 1347 "old %p (type %d) - %s", 1348 zvrf_id(zvrf), buf, rn, new, 1349 new->type, old, old->type, 1350 nh_active ? "install failed" 1351 : "nexthop inactive"); 1352 else >>> CID 1462467: (DEADCODE) >>> Execution cannot reach the expression ""install failed"" inside this statement: "zlog_debug("%u:%s: Deleting...". 1353 zlog_debug( 1354 "%u:%s: Deleting route rn %p, re %p (type %d) - %s", 1355 zvrf_id(zvrf), buf, rn, new, 1356 new->type, 1357 nh_active ? "install failed" 1358 : "nexthop inactive"); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 Dec '17

01 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1462351: Program hangs (LOCK) /bgpd/bgp_io.c: 348 in bgp_process_reads() ________________________________________________________________________________________________________ *** CID 1462351: Program hangs (LOCK) /bgpd/bgp_io.c: 348 in bgp_process_reads() 342 &peer->t_read); 343 if (added_pkt) 344 thread_add_timer_msec(bm->master, bgp_process_packet, 345 peer, 0, &peer->t_process_packet); 346 } 347 >>> CID 1462351: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 348 return 0; 349 } 350 351 /** 352 * Flush peer output buffer. 353 * ** CID 1462350: Program hangs (LOCK) /bgpd/bgp_packet.c: 2286 in bgp_process_packet() ________________________________________________________________________________________________________ *** CID 1462350: Program hangs (LOCK) /bgpd/bgp_packet.c: 2286 in bgp_process_packet() 2280 bm->master, bgp_process_packet, peer, 0, 2281 &peer->t_process_packet); 2282 } 2283 pthread_mutex_unlock(&peer->io_mtx); 2284 } 2285 >>> CID 1462350: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 2286 return 0; ** CID 1462349: Program hangs (LOCK) /bgpd/bgp_packet.c: 560 in bgp_write_notify() ________________________________________________________________________________________________________ *** CID 1462349: Program hangs (LOCK) /bgpd/bgp_packet.c: 560 in bgp_write_notify() 554 555 pthread_mutex_lock(&peer->io_mtx); 556 { 557 /* There should be at least one packet. */ 558 s = stream_fifo_pop(peer->obuf); 559 if (!s) >>> CID 1462349: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 560 return 0; 561 assert(stream_get_endp(s) >= BGP_HEADER_SIZE); 562 } 563 pthread_mutex_unlock(&peer->io_mtx); 564 565 /* Stop collecting data within the socket */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

gcc error in Configure
by Mostafa Salari 30 Nov '17

30 Nov '17

Hi I tried to install FRR on my own ubuntu1704, with the following configuration: sudo ./configure LIBS="-L/usr/lib/ -lpthread -ldl -lpq" CC=gcc-4.8 --sysconfdir=/usr/local/myrouter --localstatedir=/usr/local/myrouter/state --enable-vtysh --disable-babel --enable-fpm --enable-group=rahyab --enable-user=rahyab --disable-doc but the following error raised with c compiler error (in config.log) gcc-4.8: error: unrecognized command line option '-qversion' gcc-4.8: fatal error: no input files I tried gcc-6 also! How can i proceed :) Thanks

2 1

Redistribution based on source protocol's attributes
by Srinivas K 28 Nov '17

28 Nov '17

Does FRR support BGP route redistribution into OSPF using route-maps with filtering based on BGP attributes like Cisco. If not let me know how to archive it. Ex: Based on BGP community want to set metric-type, metric and tag values (in OSPF) route-map BGP-TO-OSPF deny 5 match community 1 set metric-type type-1 set metric 10 set tag 10101 exit router ospf redistribute bgp route-map BGP-TO-OSPF exit

3 4