- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 14 Dec '17

14 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1462961: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1462961: Memory - corruptions (OVERRUN) /bgpd/rfapi/rfapi_vty.c: 1532 in rfapiPrintRd() 1526 } 1527 1528 void rfapiPrintRd(struct vty *vty, struct prefix_rd *prd) 1529 { 1530 char buf[RD_ADDRSTRLEN]; 1531 >>> CID 1462961: Memory - corruptions (OVERRUN) >>> Overrunning array "buf" of 28 bytes by passing it to a function which accesses it at byte offset 8191 using argument "8192UL". 1532 prefix_rd2str(prd, buf, BUFSIZ); 1533 vty_out(vty, "%s", buf); 1534 } 1535 1536 void rfapiPrintAdvertisedInfo(struct vty *vty, struct rfapi_descriptor *rfd, 1537 safi_t safi, struct prefix *p) ** CID 1462960: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1629 in vnc_nve_group_export_no_prefixlist() ________________________________________________________________________________________________________ *** CID 1462960: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1629 in vnc_nve_group_export_no_prefixlist() 1623 if (!listnode_lookup(bgp->rfapi_cfg->nve_groups_sequential, rfg)) { 1624 /* Not in list anymore */ 1625 vty_out(vty, "Current NVE group no longer exists\n"); 1626 return CMD_WARNING_CONFIG_FAILED; 1627 } 1628 >>> CID 1462960: Error handling issues (CHECKED_RETURN) >>> Calling "argv_find_and_parse_afi" without checking return value (as is done elsewhere 8 out of 10 times). 1629 argv_find_and_parse_afi(argv, argc, &idx, &afi); 1630 if (argv[idx-1]->text[0] == 'z') 1631 is_bgp = 0; 1632 idx += 2; /* skip afi and keyword */ 1633 1634 if (is_bgp) { ** CID 1462959: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1694 in vnc_nve_group_export_prefixlist() ________________________________________________________________________________________________________ *** CID 1462959: Error handling issues (CHECKED_RETURN) /bgpd/rfapi/bgp_rfapi_cfg.c: 1694 in vnc_nve_group_export_prefixlist() 1688 if (!listnode_lookup(bgp->rfapi_cfg->nve_groups_sequential, rfg)) { 1689 /* Not in list anymore */ 1690 vty_out(vty, "Current NVE group no longer exists\n"); 1691 return CMD_WARNING_CONFIG_FAILED; 1692 } 1693 >>> CID 1462959: Error handling issues (CHECKED_RETURN) >>> Calling "argv_find_and_parse_afi" without checking return value (as is done elsewhere 8 out of 10 times). 1694 argv_find_and_parse_afi(argv, argc, &idx, &afi); 1695 if (argv[idx-1]->text[0] == 'z') 1696 is_bgp = 0; 1697 idx = argc - 1; 1698 1699 if (is_bgp) { ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Missing developer documentation
by Olivier Dugeon 12 Dec '17

12 Dec '17

Hiall, There is missing developer documentation in FRR. In PR #805 I try to update an old Zebra hacking document, but that seems too old to be publish, so I prefer to remove it as suggested during the PR review. For me, the main problem is how to start writing a such documentation ? First, it is too huge and to complicated to be written by only one person. Second, we need a dedicated space (e.g. a new doc project inside FRRouting) to collectively write such documentation and then push into frr master documents when they are ready. Finally, we need to organize themselves in order to collectively decided how to write them, to formalize the document through a common template, to harmonize the documentation... I would start by proposing: * start discussion about this new topic (create a new issue in github) during regular meeting * decide the document format (Markdown, in line github Wiki, LaTeX, TeXi ...) * create a new doc project within FRRouting * propose template * propose Table of Content for each document (perhaps partially common) * open contribution to the different documents Comments are welcome. Regards Olivier

4 6

a question on rst format -
by Lou Berger 11 Dec '17

11 Dec '17

Hi, Am I the only one who doesn't know about (or remember) the discussion on moving to rst as our single documentation format for the project? BTW I'm okay with the answer either way... Thanks, Lou

1 0

Discussion on "Linux Foundation Networking Projects"
by Martin Winter 06 Dec '17

06 Dec '17

All, We got approached by the Linux Foundation about some new "Linux Foundation Networking Projects" Umbrella they are planning to set up to combine various network projects. We (FRR) are a Linux Foundation project, but a lightweight one at this time, with basically only the assets held by the LF, so very unlike other projects which had formal companies set up with funding through the LF etc. They are in the process to form a new "Linux Foundation Networking Projects" umbrella and the TSC was approached to see if we are interested to join this. I expect the LF wants a decision by around mid December, so I want to discuss this at the next meeting. At next weeks meeting (Dec 6) there is ONLY a discussion, no decision will be made. However, the TSC is likely to make a decision the week after. Join the call to raise your opinions or just to listen on everyones thoughts. From the original meeting invitation by the Linux Foundation to the TSC: > Hello Open Source Networking Project Developers: > > The Linux Foundation is proud and humbled to host such a collection of > critical and influential open source networking projects for > enterprise, > cloud, and carriers alike. Over the past 5 years these projects have > formed, grown, and matured into key infrastructure components on which > tomorrow’s networking solutions are based. > > Through this journey, members across various networking projects have > requested alignment of the business governance and a greater > opportunity > for technical leverage and collaboration. To that end, the Linux > Foundation has embarked on a plan to provide a structure that allows > for > aligned governance & cross project collaboration while maintaining the > technical independence of all projects. > > To explain this exciting opportunity, answer questions, and get your > feedback, we are hosting a pair of Webinars next week on Nov. 6th, and > 7th. If you’ve been hearing about “Harmonization”, and/or > “Umbrella” > activities and want to understand where we are with those initiatives, > please join us for this Webinar. If you want more details, then please listen to the recording of the call at https://zoom.us/recording/play/M3L8MOR27hz2zWpIbY5--8iTOsn0ASbBJvs--VtbhDX5… - Martin Winter

5 8

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 05 Dec '17

05 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1462467: (DEADCODE) /zebra/zebra_rib.c: 1345 in rib_process_update_fib() /zebra/zebra_rib.c: 1353 in rib_process_update_fib() ________________________________________________________________________________________________________ *** CID 1462467: (DEADCODE) /zebra/zebra_rib.c: 1345 in rib_process_update_fib() 1339 */ 1340 if (!nh_active || !installed) { 1341 if (IS_ZEBRA_DEBUG_RIB) { 1342 char buf[SRCDEST2STR_BUFFER]; 1343 srcdest_rnode2str(rn, buf, sizeof(buf)); 1344 if (new != old) >>> CID 1462467: (DEADCODE) >>> Execution cannot reach the expression ""install failed"" inside this statement: "zlog_debug("%u:%s: Deleting...". 1345 zlog_debug( 1346 "%u:%s: Deleting route rn %p, re %p (type %d) " 1347 "old %p (type %d) - %s", 1348 zvrf_id(zvrf), buf, rn, new, 1349 new->type, old, old->type, 1350 nh_active ? "install failed" /zebra/zebra_rib.c: 1353 in rib_process_update_fib() 1347 "old %p (type %d) - %s", 1348 zvrf_id(zvrf), buf, rn, new, 1349 new->type, old, old->type, 1350 nh_active ? "install failed" 1351 : "nexthop inactive"); 1352 else >>> CID 1462467: (DEADCODE) >>> Execution cannot reach the expression ""install failed"" inside this statement: "zlog_debug("%u:%s: Deleting...". 1353 zlog_debug( 1354 "%u:%s: Deleting route rn %p, re %p (type %d) - %s", 1355 zvrf_id(zvrf), buf, rn, new, 1356 new->type, 1357 nh_active ? "install failed" 1358 : "nexthop inactive"); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 01 Dec '17

01 Dec '17

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 1462351: Program hangs (LOCK) /bgpd/bgp_io.c: 348 in bgp_process_reads() ________________________________________________________________________________________________________ *** CID 1462351: Program hangs (LOCK) /bgpd/bgp_io.c: 348 in bgp_process_reads() 342 &peer->t_read); 343 if (added_pkt) 344 thread_add_timer_msec(bm->master, bgp_process_packet, 345 peer, 0, &peer->t_process_packet); 346 } 347 >>> CID 1462351: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 348 return 0; 349 } 350 351 /** 352 * Flush peer output buffer. 353 * ** CID 1462350: Program hangs (LOCK) /bgpd/bgp_packet.c: 2286 in bgp_process_packet() ________________________________________________________________________________________________________ *** CID 1462350: Program hangs (LOCK) /bgpd/bgp_packet.c: 2286 in bgp_process_packet() 2280 bm->master, bgp_process_packet, peer, 0, 2281 &peer->t_process_packet); 2282 } 2283 pthread_mutex_unlock(&peer->io_mtx); 2284 } 2285 >>> CID 1462350: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 2286 return 0; ** CID 1462349: Program hangs (LOCK) /bgpd/bgp_packet.c: 560 in bgp_write_notify() ________________________________________________________________________________________________________ *** CID 1462349: Program hangs (LOCK) /bgpd/bgp_packet.c: 560 in bgp_write_notify() 554 555 pthread_mutex_lock(&peer->io_mtx); 556 { 557 /* There should be at least one packet. */ 558 s = stream_fifo_pop(peer->obuf); 559 if (!s) >>> CID 1462349: Program hangs (LOCK) >>> Returning without unlocking "peer->io_mtx". 560 return 0; 561 assert(stream_get_endp(s) >= BGP_HEADER_SIZE); 562 } 563 pthread_mutex_unlock(&peer->io_mtx); 564 565 /* Stop collecting data within the socket */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

gcc error in Configure
by Mostafa Salari 30 Nov '17

30 Nov '17

Hi I tried to install FRR on my own ubuntu1704, with the following configuration: sudo ./configure LIBS="-L/usr/lib/ -lpthread -ldl -lpq" CC=gcc-4.8 --sysconfdir=/usr/local/myrouter --localstatedir=/usr/local/myrouter/state --enable-vtysh --disable-babel --enable-fpm --enable-group=rahyab --enable-user=rahyab --disable-doc but the following error raised with c compiler error (in config.log) gcc-4.8: error: unrecognized command line option '-qversion' gcc-4.8: fatal error: no input files I tried gcc-6 also! How can i proceed :) Thanks

2 1

Redistribution based on source protocol's attributes
by Srinivas K 28 Nov '17

28 Nov '17

Does FRR support BGP route redistribution into OSPF using route-maps with filtering based on BGP attributes like Cisco. If not let me know how to archive it. Ex: Based on BGP community want to set metric-type, metric and tag values (in OSPF) route-map BGP-TO-OSPF deny 5 match community 1 set metric-type type-1 set metric 10 set tag 10101 exit router ospf redistribute bgp route-map BGP-TO-OSPF exit

3 4

draft-keyur-idr-bgp-prefix-limit-orf
by Marco Marzetti 22 Nov '17

22 Nov '17

Dear Developer of FRR, We're working on a draft called draft-keyur-idr-bgp-prefix-limit-orf that you can find on IETF's website at this URL: https://tools.ietf.org/html/dr aft-keyur-idr-bgp-prefix-limit-orf-02 Its goal is to allow BGP speakers to exchange maxprefix values in-band by making use of the ORF capability. We think the ideas expressed in the draft are very simple, but we would like to hear from you how hard it would be to get them implemented in your software. Let me briefly explain how it is supposed to work. Peer A and B set up a BGP session and set ORF as one of the active capabilities. Every time administrators of A change/set/remove maxprefix router A sends an ORF message indicating to router B the new value along with the behavior that router B must follow. In case that the Match field is set to DENY router B will consider the value as purely informational and will follow the usual behavior. Else, in case Match is set to PERMIT, router B will not advertise any prefix if that would cause the amount of advertised (non withdrawn) prefixes to exceed router's A maxprefix value. Please note that what described above is just a coarse summary of what is stated within the draft. We encourage you to read it to better understand what we're working on. In case that you're wondering why draft-keyur-idr-bgp-prefix-limit-orf could be useful here some real world cases: 1) Life safer for unplanned redistribution or fat fingers. In MPLS L3VPNs service providers often impose strict maxprefix limit as those are commercial values discussed before of signing the contracts. An unplanned increment in the advertisements may break the VPN. In that case spokes may prefer to not to announce some routes and still be able to reach the rest of the network from the larger part of the site than loosing all connectivity. And hubs can advertise both default and more specific routes for traffic engineering without the risk of breaking the network. Almost the same applies to FlowSpec where you could prefer to not to advertise some "rules" than to get all of them withdrawn because of an error. 2) Easier and faster method to share maxprefix betweem peers. Maxprefix is one of the few protection mechanisms used by autonomous systems when peering in the DFZ. When networks merge or transit providers get new large customers their NOCs have to reach all the peering partners in an attempt to get maxprefix updated. This is usually done by broadcasting the request by email to all peers (maybe multiple times) a few weeks before of the increment. Then "cross the fingers" and send the additional advertisements. What often happens is emails got lost or unnoticed by the network engineers of the receiving network and AS to AS connectivity breaks for some hours or even days. With the proposed solution the NOCs would be able to verify if the change has been executed before of touching anything. At this very moment we're in the process of refining the draft before of submitting it to the IETF community, but we do understand that internet standards are useful only if they're supported by vendors. For this reason we would like to hear from you how hard it could be to add the features of draft-keyur-idr-bgp-prefix-limit-orf in FRR. In case that it would be too complicated please let us know how we could make things easier. Thank you in advance for the comments or the suggestions you would like to make. Regards -- Marco

1 0

BGP RPKI available in FRouting!
by Donald Sharp 17 Nov '17

17 Nov '17

All - I'd like to announce the arrival of BGP RPKI (RFC 6810) to FRRouting. I'd like to thank Marcel for taking the time to submit this code. To use this code, ensure that you have installed a new dependant library rtrlib available here: http://rtrlib.realmv6.org/ And configure FRR with `--enable-rpki` when compiling it. Thanks! donald

2 1