- dev - lists.frrouting.org

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 07 Feb '18

07 Feb '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 8 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 8 of 8 defect(s) ** CID 1464999: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_ext.c: 1193 in ospf_ext_link_lsa_originate1() ________________________________________________________________________________________________________ *** CID 1464999: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_ext.c: 1193 in ospf_ext_link_lsa_originate1() 1187 /* Flood new LSA through area. */ 1188 ospf_flood_through_area(area, NULL /*nbr */, new); 1189 1190 if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { 1191 char area_id[INET_ADDRSTRLEN]; 1192 >>> CID 1464999: Memory - illegal accesses (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "area_id" of size 16 bytes might leave the destination string unterminated. 1193 strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); 1194 zlog_debug( 1195 "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " 1196 "Extended Link Opaque LSA: Area(%s), Link(%s)", 1197 __func__, new->data->type, inet_ntoa(new->data->id), 1198 area_id, exti->ifp->name); ** CID 1464998: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1464998: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_ext.c: 1396 in ospf_ext_pref_lsa_refresh() 1390 zlog_warn("EXT (%s): ospf_lsa_install() error", __func__); 1391 ospf_lsa_unlock(&new); 1392 return NULL; 1393 } 1394 1395 /* Flood updated LSA through the Prefix Area according to the RFC7684 */ >>> CID 1464998: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "area" to "ospf_flood_through_area", which dereferences it. 1396 ospf_flood_through_area(area, NULL /*nbr */, new); 1397 1398 /* Debug logging. */ 1399 if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { 1400 zlog_debug( 1401 "EXT (%s): LSA[Type%u:%s] Refresh Extended Prefix LSA", ** CID 1464997: (BUFFER_SIZE_WARNING) /ospfd/ospf_sr.c: 2169 in show_vty_sr_node() /ospfd/ospf_sr.c: 2183 in show_vty_sr_node() ________________________________________________________________________________________________________ *** CID 1464997: (BUFFER_SIZE_WARNING) /ospfd/ospf_sr.c: 2169 in show_vty_sr_node() 2163 "\n\n Prefix or Link Label In Label Out " 2164 "Node or Adj. SID Interface Nexthop\n"); 2165 vty_out(vty, 2166 "------------------ -------- --------- " 2167 "--------------------- --------- ---------------\n"); 2168 for (ALL_LIST_ELEMENTS_RO(srn->ext_prefix, node, srp)) { >>> CID 1464997: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "pref" of size 16 bytes might leave the destination string unterminated. 2169 strncpy(pref, inet_ntoa(srp->nhlfe.prefv4.prefix), 16); 2170 snprintf(sid, 22, "SR Pfx (idx %u)", srp->sid); 2171 if (srp->nhlfe.label_out == MPLS_IMP_NULL_LABEL) 2172 sprintf(label, "pop"); 2173 else 2174 sprintf(label, "%u", srp->nhlfe.label_out); /ospfd/ospf_sr.c: 2183 in show_vty_sr_node() 2177 srp->nhlfe.prefv4.prefixlen, srp->nhlfe.label_in, label, 2178 sid, itf ? itf->name : "-", 2179 inet_ntoa(srp->nhlfe.nexthop)); 2180 } 2181 2182 for (ALL_LIST_ELEMENTS_RO(srn->ext_link, node, srl)) { >>> CID 1464997: (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "pref" of size 16 bytes might leave the destination string unterminated. 2183 strncpy(pref, inet_ntoa(srl->nhlfe[0].prefv4.prefix), 16); 2184 snprintf(sid, 22, "SR Adj. (lbl %u)", srl->sid[0]); 2185 if (srl->nhlfe[0].label_out == MPLS_IMP_NULL_LABEL) 2186 sprintf(label, "pop"); 2187 else 2188 sprintf(label, "%u", srl->nhlfe[0].label_out); ** CID 1464996: Null pointer dereferences (REVERSE_INULL) /ospfd/ospf_sr.c: 153 in sr_node_new() ________________________________________________________________________________________________________ *** CID 1464996: Null pointer dereferences (REVERSE_INULL) /ospfd/ospf_sr.c: 153 in sr_node_new() 147 new->ext_link = list_new(); 148 new->ext_prefix = list_new(); 149 new->ext_link->del = del_sr_link; 150 new->ext_prefix->del = del_sr_pref; 151 152 /* Check if list are correctly created */ >>> CID 1464996: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "new->ext_prefix" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 153 if (new->ext_link == NULL || new->ext_prefix == NULL) { 154 list_delete_original(new->ext_link); 155 list_delete_original(new->ext_prefix); 156 XFREE(MTYPE_OSPF_SR_PARAMS, new); 157 return NULL; 158 } ** CID 1464995: Null pointer dereferences (REVERSE_INULL) /ospfd/ospf_sr.c: 153 in sr_node_new() ________________________________________________________________________________________________________ *** CID 1464995: Null pointer dereferences (REVERSE_INULL) /ospfd/ospf_sr.c: 153 in sr_node_new() 147 new->ext_link = list_new(); 148 new->ext_prefix = list_new(); 149 new->ext_link->del = del_sr_link; 150 new->ext_prefix->del = del_sr_pref; 151 152 /* Check if list are correctly created */ >>> CID 1464995: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "new->ext_link" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 153 if (new->ext_link == NULL || new->ext_prefix == NULL) { 154 list_delete_original(new->ext_link); 155 list_delete_original(new->ext_prefix); 156 XFREE(MTYPE_OSPF_SR_PARAMS, new); 157 return NULL; 158 } ** CID 1464994: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_sr.c: 443 in get_nexthop_by_addr() ________________________________________________________________________________________________________ *** CID 1464994: Null pointer dereferences (FORWARD_NULL) /ospfd/ospf_sr.c: 443 in get_nexthop_by_addr() 437 struct ospf_route *or; 438 struct ospf_path *path; 439 struct listnode *node; 440 struct route_node *rn; 441 442 /* Sanity Check */ >>> CID 1464994: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "top". 443 if ((top == NULL) && (top->new_table)) 444 return NULL; 445 446 if (IS_DEBUG_OSPF_SR) 447 zlog_debug(" |- Search Nexthop for prefix %s/%u", 448 inet_ntoa(p.prefix), p.prefixlen); ** CID 1464993: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_ext.c: 1143 in ospf_ext_pref_lsa_originate1() ________________________________________________________________________________________________________ *** CID 1464993: Memory - illegal accesses (BUFFER_SIZE_WARNING) /ospfd/ospf_ext.c: 1143 in ospf_ext_pref_lsa_originate1() 1137 /* Flood new LSA through area. */ 1138 ospf_flood_through_area(area, NULL /*nbr */, new); 1139 1140 if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { 1141 char area_id[INET_ADDRSTRLEN]; 1142 >>> CID 1464993: Memory - illegal accesses (BUFFER_SIZE_WARNING) >>> Calling strncpy with a maximum size argument of 16 bytes on destination array "area_id" of size 16 bytes might leave the destination string unterminated. 1143 strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); 1144 zlog_debug( 1145 "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " 1146 "Extended Prefix Opaque LSA: Area(%s), Link(%s)", 1147 __func__, new->data->type, inet_ntoa(new->data->id), 1148 area_id, exti->ifp->name); ** CID 1464992: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /ospfd/ospf_ext.c: 177 in ospf_ext_term() ________________________________________________________________________________________________________ *** CID 1464992: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /ospfd/ospf_ext.c: 177 in ospf_ext_term() 171 * @param - none 172 * @return - none 173 */ 174 void ospf_ext_term(void) 175 { 176 >>> CID 1464992: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> The "or" condition "OspfEXT.scope != 10 || OspfEXT.scope != 11" will always be true because "OspfEXT.scope" cannot be equal to two different values at the same time, so it must be not equal to at least one of them. 177 if ((OspfEXT.scope != OSPF_OPAQUE_AREA_LSA) 178 || (OspfEXT.scope != OSPF_OPAQUE_AS_LSA)) 179 zlog_warn( 180 "EXT: Unable to unregister Extended Prefix " 181 "Opaque LSA functions: Wrong scope!"); 182 else ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

dev/4.0
by Donald Sharp 07 Feb '18

07 Feb '18

All - I just pulled the dev/4.0 branch. We will now be working towards stabilization of the 4.0 changes and expect a release within a month or two. Additionally I've updated the master branch to build as 4.1-dev. We will be accepting new features on the master branch. donald

1 0

Debian Packaging
by Dan White 06 Feb '18

06 Feb '18

The Quagga Debian maintainer has expressed his intent to orphan his involvement with its packaging: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=884919 FRRouting Debian packaging is currently distributed via its github page: https://github.com/FRRouting/frr/releases I would guess Cumulus maintains their own private repository, along with ptm packages. What plans are there for moving packaging into Debian main?

3 4

Manpage content
by Quentin Young 01 Feb '18

01 Feb '18

Hi folks, As part of the work I’m doing to convert all of our docs to RST, I’ve now reached the point where I am converting over the manpages from groff and want some community input on content. As it stands the manpages have not been significantly updated since ~2004 and contain little more than a brief summary of option flags. Now that all of the user documentation is in RST, as far as I can see we have two options: 1. Keep the manpages separate, with their current minimal content. Example (converted) manpage source: (bgpd.rst) http://ix.io/F0E <http://ix.io/F0E> (common-options.rst) http://ix.io/F0G <http://ix.io/F0G> 2. Add the standard SYNOPSIS, DESCRIPTION, OPTIONS etc. sections, as in the source above, to the top of each chapter in the user documentation that covers a daemon, and then generate manpages from the same source we use to generate the various other manuals (web, info, pdf, etc). The only downside I see to option #2 is that some of the manpages have small novels written inside them (for example the 24 paragraph section on MED in the BGP chapter), which degrades their usefulness as the “quick reference” people tend to use them for these days. Whereas the upside is 13 less (albeit small) files to update when things change and a significant increase in the amount of overall information in the manpages. Thoughts?

3 3

MPLS use cases and Linux Kernel Interactions
by Donald Sharp 01 Feb '18

01 Feb '18

All - We plan to have a MPLS use case and Linux Kernel Interactions meeting this Wed at 10am EDT. If you would like to attend please let me know and I'll get you an invite. thanks! donald

2 3

PR has sat for 14 days
by Donald Sharp 01 Feb '18

01 Feb '18

https://github.com/FRRouting/frr/pull/1654 This PR has sat for 14 days without anyone looking at it. I will push this in on Saturday the 3, if we do not start getting some reviews. donald

1 0

ABOUT TO TRANSFER YOUR FUND
by Mrs Robin Sanders 31 Jan '18

31 Jan '18

1 0

AT&T to Release “dNOS” Software Framework Into Open Source to Accelerate Network White Box Adoption
by Olivier Dugeon 31 Jan '18

31 Jan '18

Hi all, Do you see this news: http://about.att.com/story/dnos_software_framework_into_open_source.html As AT&T mention the asset of Vyatta, do you know if they continue to use Quagga or if they have switch to FRR ? Perhaps it is time to contact AT&T as in their previous white paper about dNOS, they are very criticism against Quagga. Regards Olivier

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 31 Jan '18

31 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1464494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2023 in ipv6_route_address_interface_magic() ________________________________________________________________________________________________________ *** CID 1464494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2023 in ipv6_route_address_interface_magic() 2017 if (!nh_zvrf) { 2018 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2019 nexthop_vrf); 2020 return CMD_WARNING_CONFIG_FAILED; 2021 } 2022 >>> CID 1464494: Null pointer dereferences (NULL_RETURNS) >>> Assigning: "zvrf" = null return value from "zebra_vrf_lookup_by_name". 2023 zvrf = zebra_vrf_lookup_by_name(vrf); 2024 if (!nh_zvrf) { 2025 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2026 vrf); 2027 return CMD_WARNING_CONFIG_FAILED; 2028 } ** CID 1464493: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2114 in ipv6_route_magic() ________________________________________________________________________________________________________ *** CID 1464493: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2114 in ipv6_route_magic() 2108 if (!nh_zvrf) { 2109 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2110 nexthop_vrf); 2111 return CMD_WARNING_CONFIG_FAILED; 2112 } 2113 >>> CID 1464493: Null pointer dereferences (NULL_RETURNS) >>> Assigning: "zvrf" = null return value from "zebra_vrf_lookup_by_name". 2114 zvrf = zebra_vrf_lookup_by_name(vrf); 2115 if (!nh_zvrf) { 2116 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2117 vrf); 2118 return CMD_WARNING_CONFIG_FAILED; 2119 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 26 Jan '18

26 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1464403: Control flow issues (DEADCODE) /zebra/zebra_ptm.c: 1011 in zebra_ptm_bfd_client_register() ________________________________________________________________________________________________________ *** CID 1464403: Control flow issues (DEADCODE) /zebra/zebra_ptm.c: 1011 in zebra_ptm_bfd_client_register() 1005 ZEBRA_PTM_BFD_CLIENT_FLAG_REG); 1006 1007 return 0; 1008 1009 stream_failure: 1010 if (out_ctxt) >>> CID 1464403: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "ptm_lib_cleanup_msg(ptm_hdl...". 1011 ptm_lib_cleanup_msg(ptm_hdl, out_ctxt); 1012 return 0; 1013 } 1014 1015 /* BFD client deregister */ 1016 void zebra_ptm_bfd_client_deregister(int proto) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0