- dev - lists.frrouting.org

MPLS use cases and Linux Kernel Interactions
by Donald Sharp 01 Feb '18

01 Feb '18

All - We plan to have a MPLS use case and Linux Kernel Interactions meeting this Wed at 10am EDT. If you would like to attend please let me know and I'll get you an invite. thanks! donald

2 3

PR has sat for 14 days
by Donald Sharp 01 Feb '18

01 Feb '18

https://github.com/FRRouting/frr/pull/1654 This PR has sat for 14 days without anyone looking at it. I will push this in on Saturday the 3, if we do not start getting some reviews. donald

1 0

ABOUT TO TRANSFER YOUR FUND
by Mrs Robin Sanders 31 Jan '18

31 Jan '18

1 0

AT&T to Release “dNOS” Software Framework Into Open Source to Accelerate Network White Box Adoption
by Olivier Dugeon 31 Jan '18

31 Jan '18

Hi all, Do you see this news: http://about.att.com/story/dnos_software_framework_into_open_source.html As AT&T mention the asset of Vyatta, do you know if they continue to use Quagga or if they have switch to FRR ? Perhaps it is time to contact AT&T as in their previous white paper about dNOS, they are very criticism against Quagga. Regards Olivier

2 1

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 30 Jan '18

30 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 2 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1464494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2023 in ipv6_route_address_interface_magic() ________________________________________________________________________________________________________ *** CID 1464494: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2023 in ipv6_route_address_interface_magic() 2017 if (!nh_zvrf) { 2018 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2019 nexthop_vrf); 2020 return CMD_WARNING_CONFIG_FAILED; 2021 } 2022 >>> CID 1464494: Null pointer dereferences (NULL_RETURNS) >>> Assigning: "zvrf" = null return value from "zebra_vrf_lookup_by_name". 2023 zvrf = zebra_vrf_lookup_by_name(vrf); 2024 if (!nh_zvrf) { 2025 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2026 vrf); 2027 return CMD_WARNING_CONFIG_FAILED; 2028 } ** CID 1464493: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2114 in ipv6_route_magic() ________________________________________________________________________________________________________ *** CID 1464493: Null pointer dereferences (NULL_RETURNS) /zebra/zebra_vty.c: 2114 in ipv6_route_magic() 2108 if (!nh_zvrf) { 2109 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2110 nexthop_vrf); 2111 return CMD_WARNING_CONFIG_FAILED; 2112 } 2113 >>> CID 1464493: Null pointer dereferences (NULL_RETURNS) >>> Assigning: "zvrf" = null return value from "zebra_vrf_lookup_by_name". 2114 zvrf = zebra_vrf_lookup_by_name(vrf); 2115 if (!nh_zvrf) { 2116 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2117 vrf); 2118 return CMD_WARNING_CONFIG_FAILED; 2119 } ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 25 Jan '18

25 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1464403: Control flow issues (DEADCODE) /zebra/zebra_ptm.c: 1011 in zebra_ptm_bfd_client_register() ________________________________________________________________________________________________________ *** CID 1464403: Control flow issues (DEADCODE) /zebra/zebra_ptm.c: 1011 in zebra_ptm_bfd_client_register() 1005 ZEBRA_PTM_BFD_CLIENT_FLAG_REG); 1006 1007 return 0; 1008 1009 stream_failure: 1010 if (out_ctxt) >>> CID 1464403: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "ptm_lib_cleanup_msg(ptm_hdl...". 1011 ptm_lib_cleanup_msg(ptm_hdl, out_ctxt); 1012 return 0; 1013 } 1014 1015 /* BFD client deregister */ 1016 void zebra_ptm_bfd_client_deregister(int proto) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Jan '18

24 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1464359: Null pointer dereferences (FORWARD_NULL) /ospf6d/ospf6_spf.c: 1032 in ospf6_create_single_router_lsa() ________________________________________________________________________________________________________ *** CID 1464359: Null pointer dereferences (FORWARD_NULL) /ospf6d/ospf6_spf.c: 1032 in ospf6_create_single_router_lsa() 1026 lsa->header = (struct ospf6_lsa_header *)new_header; 1027 1028 lsa->lsdb = area->temp_router_lsa_lsdb; 1029 1030 /* Fill Larger LSA Payload */ 1031 end = ospf6_lsdb_head(lsdb, 2, type, adv_router, &rtr_lsa); >>> CID 1464359: Null pointer dereferences (FORWARD_NULL) >>> Comparing "rtr_lsa" to null implies that "rtr_lsa" might be null. 1032 if (rtr_lsa) { 1033 if (!OSPF6_LSA_IS_MAXAGE(rtr_lsa)) { 1034 /* Append first Link State ID LSA */ 1035 lsa_header = (struct ospf6_lsa_header *)rtr_lsa->header; 1036 memcpy(new_header, lsa_header, 1037 ntohs(lsa_header->length)); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 24 Jan '18

24 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 8 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 8 of 8 defect(s) ** CID 1464358: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 2107 in ipv6_route_magic() ________________________________________________________________________________________________________ *** CID 1464358: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 2107 in ipv6_route_magic() 2101 nexthop_vrf); 2102 return CMD_WARNING_CONFIG_FAILED; 2103 } 2104 2105 zvrf = zebra_vrf_lookup_by_name(vrf); 2106 if (!nh_zvrf) { >>> CID 1464358: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...". 2107 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2108 vrf); 2109 return CMD_WARNING_CONFIG_FAILED; 2110 } 2111 2112 return zebra_static_route_leak(vty, zvrf, nh_zvrf, ** CID 1464357: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 192 in ip_route_blackhole_vrf() ________________________________________________________________________________________________________ *** CID 1464357: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 192 in ip_route_blackhole_vrf() 186 #if 7 /* anything to parse? */ 187 int _i; 188 #if 1 /* anything that can fail? */ 189 unsigned _fail = 0, _failcnt = 0; 190 #endif 191 const char *no = NULL; >>> CID 1464357: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix" = "NULL". 192 const char *prefix = NULL; 193 struct in_addr mask = { INADDR_ANY }; 194 const char *mask_str = NULL; 195 const char *flag = NULL; 196 long tag = 0; 197 const char *tag_str = NULL; ** CID 1464356: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1439 in ipv6_route_vrf() ________________________________________________________________________________________________________ *** CID 1464356: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1439 in ipv6_route_vrf() 1433 int _i; 1434 #if 1 /* anything that can fail? */ 1435 unsigned _fail = 0, _failcnt = 0; 1436 #endif 1437 const char *no = NULL; 1438 struct prefix_ipv6 prefix = { }; >>> CID 1464356: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 1439 const char *prefix_str = NULL; 1440 struct prefix_ipv6 from = { }; 1441 const char *from_str = NULL; 1442 struct in6_addr gate = IN6ADDR_ANY_INIT; 1443 const char *gate_str = NULL; 1444 const char *ifname = NULL; ** CID 1464355: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 2016 in ipv6_route_address_interface_magic() ________________________________________________________________________________________________________ *** CID 1464355: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 2016 in ipv6_route_address_interface_magic() 2010 nexthop_vrf); 2011 return CMD_WARNING_CONFIG_FAILED; 2012 } 2013 2014 zvrf = zebra_vrf_lookup_by_name(vrf); 2015 if (!nh_zvrf) { >>> CID 1464355: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...". 2016 vty_out(vty, "%% nexthop vrf %s is not defined\n", 2017 vrf); 2018 return CMD_WARNING_CONFIG_FAILED; 2019 } 2020 2021 return zebra_static_route_leak(vty, zvrf, nh_zvrf, ** CID 1464354: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 591 in ip_route_magic() ________________________________________________________________________________________________________ *** CID 1464354: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 591 in ip_route_magic() 585 nexthop_vrf); 586 return CMD_WARNING_CONFIG_FAILED; 587 } 588 589 zvrf = zebra_vrf_lookup_by_name(vrf); 590 if (!nh_zvrf) { >>> CID 1464354: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...". 591 vty_out(vty, "%% nexthop vrf %s is not defined\n", 592 vrf); 593 return CMD_WARNING_CONFIG_FAILED; 594 } 595 596 return zebra_static_route_leak(vty, zvrf, nh_zvrf, ** CID 1464353: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 487 in ip_route_address_interface_magic() ________________________________________________________________________________________________________ *** CID 1464353: Control flow issues (DEADCODE) /zebra/zebra_vty.c: 487 in ip_route_address_interface_magic() 481 nexthop_vrf); 482 return CMD_WARNING_CONFIG_FAILED; 483 } 484 485 zvrf = zebra_vrf_lookup_by_name(vrf); 486 if (!nh_zvrf) { >>> CID 1464353: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "vty_out(vty, "%% nexthop vr...". 487 vty_out(vty, "%% nexthop vrf %s is not defined\n", 488 vrf); 489 return CMD_WARNING_CONFIG_FAILED; 490 } 491 492 return zebra_static_route_leak(vty, zvrf, nh_zvrf, ** CID 1464352: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1230 in ipv6_route_address_interface_vrf() ________________________________________________________________________________________________________ *** CID 1464352: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1230 in ipv6_route_address_interface_vrf() 1224 int _i; 1225 #if 1 /* anything that can fail? */ 1226 unsigned _fail = 0, _failcnt = 0; 1227 #endif 1228 const char *no = NULL; 1229 struct prefix_ipv6 prefix = { }; >>> CID 1464352: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 1230 const char *prefix_str = NULL; 1231 struct prefix_ipv6 from = { }; 1232 const char *from_str = NULL; 1233 struct in6_addr gate = IN6ADDR_ANY_INIT; 1234 const char *gate_str = NULL; 1235 const char *ifname = NULL; ** CID 1464351: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1031 in ipv6_route_blackhole_vrf() ________________________________________________________________________________________________________ *** CID 1464351: Null pointer dereferences (FORWARD_NULL) /zebra/zebra_vty_clippy.c: 1031 in ipv6_route_blackhole_vrf() 1025 int _i; 1026 #if 1 /* anything that can fail? */ 1027 unsigned _fail = 0, _failcnt = 0; 1028 #endif 1029 const char *no = NULL; 1030 struct prefix_ipv6 prefix = { }; >>> CID 1464351: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "prefix_str" = "NULL". 1031 const char *prefix_str = NULL; 1032 struct prefix_ipv6 from = { }; 1033 const char *from_str = NULL; 1034 const char *flag = NULL; 1035 long tag = 0; 1036 const char *tag_str = NULL; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Static VRF Route Leaking
by Donald Sharp 23 Jan '18

23 Jan '18

All - I'd like to thanks Philippe Guibert, Lou Berger, Renato Westphal and Russ White working with me to get static route leaking into the FRR code base on master. To configure: vrf DONNA ip route 4.3.2.1/32 99.1.2.3 nexthop-vrf EVA ! vrf EVA ip route 9.1.2.3/32 44.3.2.4 nexthop-vrf DONNA ! These two commands create a static route that leaks the nexthops into the appropriate vrf's. At this point in time, BGP has not been modified to take advantage of vrf route leaking in the traditional manner, but the underpinnings in zebra and the zapi protocol are now there. donald

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 18 Jan '18

18 Jan '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1464192: Insecure data handling (INTEGER_OVERFLOW) /vtysh/vtysh.c: 204 in vtysh_client_run() ________________________________________________________________________________________________________ *** CID 1464192: Insecure data handling (INTEGER_OVERFLOW) /vtysh/vtysh.c: 204 in vtysh_client_run() 198 } 199 200 /* else if no callback, dump raw */ 201 if (!callback) { 202 if (fp) 203 fwrite(buf, 1, textlen, fp); >>> CID 1464192: Insecure data handling (INTEGER_OVERFLOW) >>> Overflowed or truncated value (or a value computed from an overflowed or truncated value) "bufvalid - buf - textlen" used as critical argument to function. 204 memmove(buf, buf + textlen, bufvalid - buf - textlen); 205 bufvalid -= textlen; 206 } 207 208 if (bufvalid == buf + bufsz) { 209 char *new; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0… To manage Coverity Scan email notifications for "frr(a)lists.nox.tf", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0