- dev - lists.frrouting.org

C99 fixed-width patch
by Quentin Young 28 Mar '18

28 Mar '18

Hi folks, PR #1854 switched all of our fixed width types over to types present in the C99 standard. Since we used a lot of nonstandard types this was a pretty big patch and may have caused conflicts with open pull requests or your private branches, so you may want to check. If you’re using these types in some new code, you can try using the conversion script in tools/convert-fixedwidth.sh followed by a `git clang-format` to replicate the process that was done to master and hopefully reduce some of the conflicts. Quentin

1 0

FRR Technical Meeting Notes 03/27/18
by Quentin Young 27 Mar '18

27 Mar '18

FRR Technical Meeting Notes 03/27/18 ==================================== Issues ------ - #1949: Donald - We need to discuss integration of namespace VRF more because the codebase has an implicit assumption that the default VRF is zero. - #1953: Quentin to rebase and poke Martin if CI still fails - #1960: Donald and Philippe to discuss further - #1965: Christian - It's a feature request. Added to FR page and closed issue. - #1967: Seems legit, we'll start looking. Pull Requests ------------- - #1817: Just a few minor nits from Quentin, then g2g - #1824: Needs additional reviewers, Donald will take another look - #1833: Paul to clean up and then we will merge - #1853: Lots of folks asking about BFD, needs reviewers, configure switch needs to be fixed; Donald will help with autotools - #1854: Needs a rebase, then should be g2g - #1881: g2g once Olivier updates topotests - #1894: Lou fixed today, Quentin to look again - #1903: Needs reviewers - #1905: Donald to review new changes - #1915: [Merged] - #1916: Needs reviewers - #1921: Needs reviewers - #1928: Lou to take another look and probably merge - #1950: Proposed change to fix #1949 - #1959: Assigned Martin for review - #1966: Renato to review - #1969: \ #1970: / Donald to take a look at these

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 27 Mar '18

27 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1466892: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 570 in bgp_info_cmp() ________________________________________________________________________________________________________ *** CID 1466892: Incorrect expression (COPY_PASTE_ERROR) /bgpd/bgp_route.c: 570 in bgp_info_cmp() 564 "%s: %s wins over %s due to preferred BGP_ROUTE type", 565 pfx_buf, new_buf, exist_buf); 566 return 1; 567 } 568 569 if (!(exist->sub_type == BGP_ROUTE_NORMAL || >>> CID 1466892: Incorrect expression (COPY_PASTE_ERROR) >>> "new" in "new->sub_type" looks like a copy-paste error. 570 new->sub_type == BGP_ROUTE_IMPORTED)) { 571 if (debug) 572 zlog_debug( 573 "%s: %s loses to %s due to preferred BGP_ROUTE type", 574 pfx_buf, new_buf, exist_buf); 575 return 0; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

FRR 4.0 Released
by Quentin Young 25 Mar '18

25 Mar '18

Greetings operators and interested parties, The FRRouting contributors are proud to announce that the latest release of FRR is available for download. The team has spent several months integrating code and developing enhancements towards making FRR the best open routing suite available. The project thanks all contributors to this latest release, big and small! Documentation is located on the project website: https://frrouting.org/user-guide/ We have also begun to flesh out documentation for contributors and those interested in contributing: https://frrouting.org/dev-guide/ Feedback and documentation improvements are always welcome. Change Summary ============== General ------- * Implemented tab completion for interface names, prefix-lists, route-maps and BGP peer-names New protocols ------------- Added: * RFC 6126 -- Added BABEL protocol daemon * RFC 7868 -- Added EIGRP protocol daemon (experimental) BGP --- Added: * RFC 6810 -- RPKI integration * RFC 3107 -- v4 labeled unicast with partial implementation of draft-ietf-idr-bgp-prefix-sid * RFC 6514 -- Encodings and Procedures for Multicast in MPLS/BGP IP VPN's * RFC 7432 -- MPLS-Based Ethernet VPN (EVPN) * draft-ietf-bess-evpn-overlay * draft-ietf-bess-evpn-inter-subnet-forwarding * draft-ietf-bess-evpn-prefix-advertisement * draft-ietf-idr-tunnel-encaps * draft-ietf-bess-evpn-proxy-arp-nd ISIS ---- Added: * RFC 5120 -- ISIS-MT PIM --- Added: * VRF support OSPFv2 ------ Added: * VRF support * draft-ietf-ospf-segment-routing-extensions-24 (experimental) ZEBRA ----- * Cross-VRF static route leaking Bugfixes ======== * Too many to count.

3 3

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 23 Mar '18

23 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1465679: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vty.c: 265 in zebra_static_route_holdem() ________________________________________________________________________________________________________ *** CID 1465679: Resource leaks (RESOURCE_LEAK) /zebra/zebra_vty.c: 265 in zebra_static_route_holdem() 259 return CMD_SUCCESS; 260 } 261 262 if (!negate) 263 listnode_add_sort(static_list, shr); 264 >>> CID 1465679: Resource leaks (RESOURCE_LEAK) >>> Variable "shr" going out of scope leaks the storage it points to. 265 return CMD_SUCCESS; 266 } 267 268 static int zebra_static_route_leak( 269 struct vty *vty, struct zebra_vrf *zvrf, struct zebra_vrf *nh_zvrf, 270 afi_t afi, safi_t safi, const char *negate, const char *dest_str, ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0

Broken CI and builds
by Donald Sharp 22 Mar '18

22 Mar '18

All - PR #1938 broke Lou's CI system and PR's submitted after this fix will fail Lou's CI. The fix for this was in PR #1947 which has been pushed into the tree. If your PR is failing Lou's CI, I would suggest rebasing and force pushing to get #1947. donald

1 0

Open source routing @ ietf meetup
by Lou Berger 22 Mar '18

22 Mar '18

Hi, We're continuing with the informal Open source routing @ ietf meetup. Anyone interested in joining a "bring your own lunch" gathering of folks using/building open source routing code, please drop in to "Richmond/Chelsea/Tower" on Thursday during lunch (noon). There is no agenda or slides. Please feel free to bring a topic that you'd like to discuss or just come and listen. Cheers, Lou [1] https://datatracker.ietf.org/meeting/101/floor-plan?room=richmond-chelsea-t…

2 1

BGP VPN-VRF route leaking per RFC 4364
by Donald Sharp 22 Mar '18

22 Mar '18

2 1

Technical Meeting Notes
by Donald Sharp 21 Mar '18

21 Mar '18

Technical meeting notes - 3/20/18 Donald, Emmanuel, Paul Z, Rafael, Quentin, Mark Stapp, Philippe, Martin, Christian, Daniel, Alistair, Jafar, Don New Issues: 1879 - Quentin looking at it - in progress 1887 - static route refactoring - Donald submitted to treat static routes as just another route type 1892 - frr install on ubuntu (particular version) crash - Martin taking it but next week for the work 1895 - Quentin has open pull request for this one 1899 - zebra socket problem (not reading all data). need to improve read data handling Possible known issue with loopback devices? Suggested by Renato? Asked Renato to respond. 1906 - request for feature - ospfv3 authentication trailer - added to feature request list 1907 - FRR not running on FreeBSD (ns init failure) - Martin Assigned to Philippe 1910 - ospfv3 lsa fragment - fixed by Chirag - waiting for response from submitter that fixed for them 1917 - show advertised in bgp with peer group fails after a while Need details on reproducing - fixed in 4.0 (according to submitter) fixed in master? Would like it fixed in 3.0 (if we can identify what fixed it) - git bisect Asked submitter for recreate steps and if receiver still has the routes 1923 - licenses on ldpd and babeld - Martin responding - assigned to him Leave open for another few days and then close if no response 1926 - interface netns not removed from zebra - Philippe - assigned to him as well Working on it and will discuss with Renato 1930 - Centos 7 chroot build failing - Martin fixed in master and will put also in 4.0 assigned to Martin 1934 - document api/abi versioning scheme - Quentin need a way for coders to know the api exposed by a version number Assigned to Quentin older - 1850 - Paul looking at changes made by Donald - didn't fix problem reported by Paul. Still in progress PRs: 1817 - flowspec client - Philippe Donald will look at it and asked others on reviewer list to review. Static analysis also had warning which Philippe will look at 1824 - table manager for zebra - Philippe Failure in CI system - asking Lou to take a look at the CI failures 1825 - Fron Chirag - ospfv3 intra prefix lsa after restart Jafar looking at it 1853 - bfd changes - Rafael Fixing warnings - getting closer 1854 - C99 fixed with integer types - Quentin Asking Lou to look at response to changes requested 1871 - zebra pbr rule added to fwmark tag Philippe asked questions about the approach Donald took Donald said need encode function in lib/zclient.c Unclear the end discussion - as Donald 1881 - ospf SR SRGB limits - Olivier - new topo tests next week by Olivier 1882 - Community.md document that we don't dismiss comments on a review (Lou) No real disagreement but look at it when Lou is back 1883 - Community.md needs more documentation on the style requirements (Paul) Checkpatch is useful but do we care about everything it complains about? Quentin's response - Linux style guide source of truth but can be reiterated here Checkpatch is a strong suggestion with specific exceptions. 95% of the time, it's right. Paul tweaking the language a bit to reflect this discussion 1894 - vtysh needs -u to avoid using enable mode Quentin tested and doesn't quite work - needs to be fixed 1903 - PBR by Donald Philippe will look but needs more eyes Also needs to rebase, fix conflicts and resubmit Philippe has questions about future match criteria 1904 - Documentation cleanup - Quentin - Still in progress Martin will review when done 1905 - ipset table for zebra - Philippe - Renato reviewing 1913 - vpn-policy cli - Paul He believes he has addressed all of the comments in the PR If reviewers agree, ready to push Donald will re-review 1915 - evpn ipv6 external routing - Philippe reviewing - could use other eyes on it 1916 - evpn bug fixes - looking for reviewer 1921 - pim stuff - cleanup of how vrf info is used to be more efficient (rather than iterating) Jafar reviewing 1927 - zebra delete interface that disappeared - work in progress by Philippe 1928 - bgp flowspec get vrf from RT - Philippe Adding an API to get this information from the RT Paul or Lou volunteer? Paul will discuss with Philippe offline 1931 - pimd mtrace fixes - Donald looking at it 1933 - move community.md to developer/workflow.rst - Quentin - Jafar reviewing 1935 - document code style tools - Quentin - Lou? Not there to respond. Martin will ask him 1937 - bgp vpn vrf leak cli documentation - Quentin will merge it 1938 - bgpd - fix peer withdrawal and route leaking for vpns and vrfs - Paul reviewing 1939 - redhat tarball - waiting for CI to finish Martin has rpki packages building and needs someone to do testing on it if someone is willing

1 0

New Defects reported by Coverity Scan for freerangerouting/frr
by scan-admin＠coverity.com 20 Mar '18

20 Mar '18

Hi, Please find the latest report on new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 5 new defect(s) introduced to freerangerouting/frr found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s) ** CID 1465852: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1465852: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 356 in af_route_map_vpn_imexport() 350 } 351 #if 0 /* anything that can fail? */ 352 if (_failcnt) 353 return CMD_WARNING; 354 #endif 355 #endif >>> CID 1465852: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "direction_str" to "af_route_map_vpn_imexport_magic", which dereferences it. 356 return af_route_map_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rmap_str); 357 } 358 359 /* bgp_imexport_vpn => "[no] <import|export>$direction_str vpn" */ 360 DEFUN_CMD_FUNC_DECL(bgp_imexport_vpn) 361 #define funcdecl_bgp_imexport_vpn static int bgp_imexport_vpn_magic(\ ** CID 1465851: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1465851: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 404 in bgp_imexport_vpn() 398 } 399 #if 0 /* anything that can fail? */ 400 if (_failcnt) 401 return CMD_WARNING; 402 #endif 403 #endif >>> CID 1465851: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "direction_str" to "bgp_imexport_vpn_magic", which dereferences it. 404 return bgp_imexport_vpn_magic(self, vty, argc, argv, no, direction_str); 405 } 406 407 /* show_ip_bgp_instance_updgrps_adj_s => "show [ip]$ip bgp [<view|vrf> VIEWVRFNAME$vrf] [<ipv4|ipv6>$afi <unicast|multicast|vpn>$safi] update-groups [SUBGROUP-ID]$sgid <advertise-queue|advertised-routes|packet-queue>$rtq" */ 408 DEFUN_CMD_FUNC_DECL(show_ip_bgp_instance_updgrps_adj_s) 409 #define funcdecl_show_ip_bgp_instance_updgrps_adj_s static int show_ip_bgp_instance_updgrps_adj_s_magic(\ ** CID 1465850: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1465850: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 250 in af_nexthop_vpn_export() 244 } 245 #if 1 /* anything that can fail? */ 246 if (_failcnt) 247 return CMD_WARNING; 248 #endif 249 #endif >>> CID 1465850: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "nexthop_str" to "af_nexthop_vpn_export_magic", which dereferences it. 250 return af_nexthop_vpn_export_magic(self, vty, argc, argv, no, nexthop_str, nexthop_str_str); 251 } 252 253 /* af_rt_vpn_imexport => "[no] <rt|route-target> vpn <import|export|both>$direction_str RTLIST..." */ 254 DEFUN_CMD_FUNC_DECL(af_rt_vpn_imexport) 255 #define funcdecl_af_rt_vpn_imexport static int af_rt_vpn_imexport_magic(\ ** CID 1465849: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1465849: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 138 in af_rd_vpn_export() 132 } 133 #if 0 /* anything that can fail? */ 134 if (_failcnt) 135 return CMD_WARNING; 136 #endif 137 #endif >>> CID 1465849: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "rd_str" to "af_rd_vpn_export_magic", which dereferences it. 138 return af_rd_vpn_export_magic(self, vty, argc, argv, no, rd_str); 139 } 140 141 /* af_label_vpn_export => "[no] label vpn export (0-1048575)$label_val" */ 142 DEFUN_CMD_FUNC_DECL(af_label_vpn_export) 143 #define funcdecl_af_label_vpn_export static int af_label_vpn_export_magic(\ ** CID 1465848: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1465848: Null pointer dereferences (FORWARD_NULL) /bgpd/bgp_vty_clippy.c: 303 in af_rt_vpn_imexport() 297 } 298 #if 0 /* anything that can fail? */ 299 if (_failcnt) 300 return CMD_WARNING; 301 #endif 302 #endif >>> CID 1465848: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "direction_str" to "af_rt_vpn_imexport_magic", which dereferences it. 303 return af_rt_vpn_imexport_magic(self, vty, argc, argv, no, direction_str, rtlist); 304 } 305 306 /* af_route_map_vpn_imexport => "[no] route-map vpn <import|export>$direction_str RMAP$rmap_str" */ 307 DEFUN_CMD_FUNC_DECL(af_route_map_vpn_imexport) 308 #define funcdecl_af_route_map_vpn_imexport static int af_route_map_vpn_imexport_magic(\ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V0…

1 0